Profile images using absolute URLs instead of relative URLs

Our local install of GitLab 7.6.2 16f0968c uses absolute URLs instead of relative URLs for custom profile images. This breaks for people who are using SSH tunnels to redirect (e.g., a localhost port) to their gitlab server, since it insists on rewriting profile images with the full name of the gitlab server.

It uses relative URLs for custom group images, as well as most other images; this only impacts custom profile images.

+1 (7.12.2)

+1 (8.0.3)

mentioned in issue #2952 (closed)

Mentioned in issue #2952 (closed)

@haynes This seems fairly easy to get started on. There are 3 instances of gitlab_config.url that could be removed (project, group and user URLs) and a lot more instances of Gitlab.config.gitlab.url that would need to be checked manually to see if they could be removed. I'm not sure this could be reliably done in a single MR since it would probably be easy to miss a location that is adding the FQDN to URLs. This can probably have the up for grabs label.

added ~123454 ~131895 labels

@espadav8 Thank you 😃
I agree this is a pretty good starting point. I've added the labels.

removed ~131895 label

@haynes can you try to estimate the difficulty and set issue weight?

@adamniedzielski I'd say very easy. It comes down to a lot of search and replace. (see the comment from @espadav8 )
It's just a lot of files to adjust if you want to do this for all urls.
But It's easy to only do a part of this and split it in several MRs.

So i'd say.... difficulty 1/10, work for all: 5/10

@dtisdall As far as I can tell, this has meanwhile been fixed (checked on gitlab.com with 10.0.3-ee, eff7821). Can you confirm?

added awaiting feedback label

Sorry, I've changed employers and no longer use GitLab so can't confirm the fix. Thanks for checking back in, though.

@winh I can confirm that the group images are linked with a relative path like data-src="/uploads/-/system/group/avatar/5/mygroup.jpg" as well as profile images like data-src="/uploads/-/system/user/avatar/2/avatar.png"

Checked on 10.0.2 06a5a331.

@dtisdall @formwandler Thank you both for the feedback! ❤️ I'm closing this then. 😃

closed

removed awaiting feedback label