GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-11-13T05:35:26Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14724Make sure that every job has a stage assigned2017-11-13T05:35:26ZGrzegorz BizonMake sure that every job has a stage assigned## What does this MR do?
This MR is needed to ensure that every CI/CD job has a stage assigned. Jobs for pages deployments and external commit statuses in particular.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entr...## What does this MR do?
This MR is needed to ensure that every CI/CD job has a stage assigned. Jobs for pages deployments and external commit statuses in particular.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] Tests added for this feature/bug
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
See #3875610.1https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14712Add docs for GKE integration2017-10-25T00:07:35ZAchilleas PipinellisAdd docs for GKE integration## What does this MR do?
Adds docs for the new GKE cluster integration https://gitlab.com/gitlab-org/gitlab-ce/issues/35954.## What does this MR do?
Adds docs for the new GKE cluster integration https://gitlab.com/gitlab-org/gitlab-ce/issues/35954.10.1Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14642namespace should be lowercased in kubernetes2017-10-08T13:23:29Zusername-removed-197097namespace should be lowercased in kubernetes## What does this MR do?
This is making namespace lowercase in kubernetes, otherwise namespaces cannot be created. This was partially addressed, but this covers a case that was missed when the default namespace is generated from the proj...## What does this MR do?
This is making namespace lowercase in kubernetes, otherwise namespaces cannot be created. This was partially addressed, but this covers a case that was missed when the default namespace is generated from the project group-name.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Autodevops fails for projects with uppercase in their name.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38692.10.0username-removed-197097username-removed-197097https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14496Extend KubernetesService to use username/password2017-10-03T05:40:02ZShinya MaedaExtend KubernetesService to use username/password## What does this MR do?
This MR extends KubernetesService to use username/password
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the...## What does this MR do?
This MR extends KubernetesService to use username/password
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Related
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14470
- https://gitlab.com/gitlab-org/gitlab-ce/issues/35954Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14439WIP: DRY and refactor CI/CD Variables2017-10-05T11:50:29ZGrzegorz BizonWIP: DRY and refactor CI/CD Variables## What does this MR do?
This MR refactors how we handle CI/CD Variables collections.
## Why was this MR needed?
We have a lot of duplication regarding CI/CD variables what causes some problems and productivity loss.
## Does ...## What does this MR do?
This MR refactors how we handle CI/CD Variables collections.
## Why was this MR needed?
We have a lot of duplication regarding CI/CD variables what causes some problems and productivity loss.
## Does this MR meet the acceptance criteria?
- [ ] Tests added for this feature/bug
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
Related gitlab-org/gitlab-ce#3304210.1https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14271Cleanup Deployments table2017-09-28T11:26:08ZZeger-Jan van de Wegzegerjan@gitlab.comCleanup Deployments table## Does this MR meet the acceptance criteria?
- [X] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [-] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/d...## Does this MR meet the acceptance criteria?
- [X] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [-] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [-] API support added
- [-] Tests added for this feature/bug
- Review
- [-] Has been reviewed by UX
- [-] Has been reviewed by Frontend
- [-] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [-] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [-] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [-] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Part of gitlab-org/gitlab-ce#31803 (Skipped changes that required the application to change)10.1Zeger-Jan van de Wegzegerjan@gitlab.comZeger-Jan van de Wegzegerjan@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14199document basic coverage regex2017-09-27T03:11:56Zusername-removed-5332document basic coverage regex## What does this MR do?
Document regex for basic "Coverage 82.9%" statement.## What does this MR do?
Document regex for basic "Coverage 82.9%" statement.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14106Prefer to use /cache over external cache2017-09-07T15:10:20ZKamil TrzcińśkiPrefer to use /cache over external cache## What does this MR do?
Use disk cache instead of external cache.
This also adds a disclaimer how to make changes to `cache` and `artifacts`. Since this has significant implication it should be approved either by ~"CI/CD" or ~Edge t...## What does this MR do?
Use disk cache instead of external cache.
This also adds a disclaimer how to make changes to `cache` and `artifacts`. Since this has significant implication it should be approved either by ~"CI/CD" or ~Edge team.
@stanhu Is that a good place to enforce that rule?
## Why was this MR needed?
This is to solve my woes of https://gitlab.com/gitlab-com/infrastructure/issues/2724.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-com/infrastructure/issues/2724
cc @stanhu @rymaihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14009Fail jobs if its dependency is missing2017-12-07T21:16:41ZShinya MaedaFail jobs if its dependency is missing## What does this MR do?
This MR fails jobs if its dependency is missing.
Old MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13922
This MR is on top of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13937
## Are t...## What does this MR do?
This MR fails jobs if its dependency is missing.
Old MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13922
This MR is on top of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13937
## Are there points in the code the reviewer needs to double check?
Doesn't this break current architecture?
## Why was this MR needed?
Originally issued at https://gitlab.com/gitlab-org/gitlab-ce/issues/34834 as ~Deliverable
## Screenshots (if relevant)
TBD
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [-] API support added
- [x] Tests added for this feature/bug
- Review
- [-] Has been reviewed by UX
- [-] Has been reviewed by Frontend
- [x] Has been reviewed by Backend
- [-] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close https://gitlab.com/gitlab-org/gitlab-ce/issues/34834
/cc @ayufan10.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13989Check trigger_request.variables dependencies2017-09-15T14:34:32ZShinya MaedaCheck trigger_request.variables dependencies## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13917Resolve "Pages API"2017-10-24T23:59:38Zusername-removed-745767Resolve "Pages API"## What does this MR do?
Add's CRUD API end points for Pages Domains.
## Are there points in the code the reviewer needs to double check?
Yes! :smile:
- Is it appropriate to expose raw certificate and key? See `pages/domains/...## What does this MR do?
Add's CRUD API end points for Pages Domains.
## Are there points in the code the reviewer needs to double check?
Yes! :smile:
- Is it appropriate to expose raw certificate and key? See `pages/domains/:domain/details`.
- This introduces ability to edit an existing domain that is not possible in the UI. Primary use cases are:
- Update expiring certificate
- Convert existing domain from http to https
- Is API json schema correctly declared?
- Should there be a distinction between a single domain response and a list response?
- Review security policy (probably a separate issue but here for reference)
- The existing Domain Pages UI controllers only utilize `authorize_read_pages` and `authorize_update_pages`.
- Current policy… (owner,admin: `remove_pages`), (master: `admin_pages`,`read_pages`,`update_pages`)
- Are the tests handled in a reasonable way?
- Does every role need to be tested?
- Should the endpoints be disabled and return a particular response code if the pages facility is not enabled? See `require_pages_enabled`.
## Why was this MR needed?
Through the API, it is not currently possible to add, update, or remove pages domains with optional certificate on projects. Requested in issue #23000.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2300010.1username-removed-745767username-removed-745767https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13893WIP: Expose per-project pipeline ID ($CI_PIPELINE_IID)2017-09-26T13:46:17ZShinya MaedaWIP: Expose per-project pipeline ID ($CI_PIPELINE_IID)## What does this MR do?
This MR creates new column `iid` on `ci_pipelines` and expose it as `$CI_PIPELINE_IID`.
This `iid` is per-project basis.
## Are there points in the code the reviewer needs to double check?
Does this migration ...## What does this MR do?
This MR creates new column `iid` on `ci_pipelines` and expose it as `$CI_PIPELINE_IID`.
This `iid` is per-project basis.
## Are there points in the code the reviewer needs to double check?
Does this migration work on production(GitLab.com)?
## Why was this MR needed?
Originally demanded at https://gitlab.com/gitlab-org/gitlab-ce/issues/3691. It got about 50 upvotes.
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close https://gitlab.com/gitlab-org/gitlab-ce/issues/3691
/cc @ayufan @bikebilly @grzesiek @godfat10.2Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13827Fix documentation of gitlabUrl variable2017-09-07T14:29:41Zusername-removed-209175Fix documentation of gitlabUrl variable## What does this MR do?
fixes wrong mentions of `gitlabURL` which should be `gitlabUrl`## What does this MR do?
fixes wrong mentions of `gitlabURL` which should be `gitlabUrl`https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13689add note about after_script being run separately2017-10-24T23:59:31Zusername-removed-365516add note about after_script being run separatelySee the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html
## What does this MR do?
clarify execution of after_scriptSee the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html
## What does this MR do?
clarify execution of after_scriptusername-removed-365516username-removed-365516https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13644Expose `duration` in Job API entity2017-11-06T20:40:23Zusername-removed-35242mehdi@lahmam.comExpose `duration` in Job API entity## What does this MR do?
Expose `duration` in Job API entity, as suggested by #35794
## Are there points in the code the reviewer needs to double check?
I haven't added any specs are the current ones doesn't test neither all serialize...## What does this MR do?
Expose `duration` in Job API entity, as suggested by #35794
## Are there points in the code the reviewer needs to double check?
I haven't added any specs are the current ones doesn't test neither all serialized job attributes, but I'm thinking about a refactor for all the API::Jobs to better rely on schemas (and define missing ones). I can tackle this in a separate MR if it sounds good to you.
## Why was this MR needed?
To close #35794, but mostly at another excuse for me to contribute more to GitLab and getting progressively more familiar with its code base.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#35794https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13358Forbid blocked users to create a pipeline2017-08-21T15:12:08ZShinya MaedaForbid blocked users to create a pipeline## What does this MR do?
This MR forbids blocked users to create a pipeline
## Are there points in the code the reviewer needs to double check?
Does this resolve https://gitlab.com/gitlab-com/infrastructure/issues/2425#note_36958576?
...## What does this MR do?
This MR forbids blocked users to create a pipeline
## Are there points in the code the reviewer needs to double check?
Does this resolve https://gitlab.com/gitlab-com/infrastructure/issues/2425#note_36958576?
## Why was this MR needed?
Due to https://gitlab.com/gitlab-com/infrastructure/issues/2425#note_36958576
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- Review
- Has been reviewed by UX
- Has been reviewed by Frontend
- [x] Has been reviewed by Backend
- Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
- https://gitlab.com/gitlab-com/infrastructure/issues/2425#note_36958576Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13055WIP: Gitlab CI run pipelines based on commit filename matching2017-10-04T23:33:05Zusername-removed-823308WIP: Gitlab CI run pipelines based on commit filename matching## What does this MR do?
This is an RFC WIP MR meant to close #19232, as a PoC. This is not ready for merge.
The attempt here was to add a key to the job config for Gitlab CI, so that the job is only run if any of the files in the most...## What does this MR do?
This is an RFC WIP MR meant to close #19232, as a PoC. This is not ready for merge.
The attempt here was to add a key to the job config for Gitlab CI, so that the job is only run if any of the files in the most recent commit match. The issue called for a child key of `only` called `paths`. However, implementing it in this way would require more refactoring of current `only`-config logic than we were willing to take for our PoC.
Instead, we introduced a brand new config called `include_paths`, which accepts a list of filename regexes that will be checked against the filenames of the last commit. It is configured like so:
```yml
job:
script: ...
include_paths:
- app/
- *.rb
- ...
```
Theoretically, it should be simple to also add functionality for `exclude_paths`, it will just take more time commitment to accomplish.
## Are there points in the code the reviewer needs to double check?
The main thing to look out for is whether my code is conforming to architectural style of Gitlab's codebase. Also, I am open to better ideas on how to input the list of filenames from the commit into the `CI::GitlabCiYamlProcessor` class. I prefer to have it check all commits since the last time the pipeline ran (last "push"?), instead of just the last commit.
## Why was this MR needed?
This offers finer-grain control over what jobs to run. This can result in considerable cost and time savings for lengthy build pipelines, that simple commits would otherwise trigger.
The linked issue documents this use-case well.
## Does this MR meet the acceptance criteria?
**Note that not all criteria is met, but that's because this is just a PoC. This is not ready for merge yet.**
**Also, note that CI pipeline builds from my fork are failing. Some failures, such as rubocop, are things that I need to look at before merge. The reasons for other failures, like karma and spinach, are unknown to me.
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#19232username-removed-823308username-removed-823308https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12986Hide pipeline schedule 'take ownership' for current owner2017-09-28T12:53:53Zusername-removed-419655Hide pipeline schedule 'take ownership' for current owner## What does this MR do?
Hide pipeline schedule 'take ownership' button for current owner of pipeline schedule
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
If you're already the owner...## What does this MR do?
Hide pipeline schedule 'take ownership' button for current owner of pipeline schedule
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
If you're already the owner, you don't need to see the take ownership button
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #352859.5username-removed-419655username-removed-419655https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12838Use admin_build for erase (Forbid Developer to erase job)2017-09-26T13:46:30ZShinya MaedaUse admin_build for erase (Forbid Developer to erase job)## What does this MR do?
This MR uses `admin_build` for `JobsController#erase`. This is for preventing developers to erase builds.
Old MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11538.
## Are there points in the code...## What does this MR do?
This MR uses `admin_build` for `JobsController#erase`. This is for preventing developers to erase builds.
Old MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11538.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
This is required at #31771
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close #3177110.2Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12791WIP: Resolve "Make a PoC for job's details page"2017-07-25T14:58:59ZFilipa Lacerdafilipa@gitlab.comWIP: Resolve "Make a PoC for job's details page"## What does this MR do?
### Tech details
- [x] Remove mediator
- [x] Create tabs component
- [ ] Create tabs component test
- [x] Transform mediator into a details.vue component
- [x] Update store & service
- [x] Create component for h...## What does this MR do?
### Tech details
- [x] Remove mediator
- [x] Create tabs component
- [ ] Create tabs component test
- [x] Transform mediator into a details.vue component
- [x] Update store & service
- [x] Create component for header details
- [ ] Create jobs table in vue
- [ ] Create failed jobs in vue
- [x] If the same job is clicked twice, we should not load the same data twice
#### Tabs
- [x] handle tab selection
- [x] handle job tab selection
- [x] handle url changes
- [ ] open job tab if url has `?job={id}`
- [x] tab can be closable
- [ ] tab can have a badge
- [ ] tab can link to an hash
#### Parse ansi
- [x] choose a parser
- [x] parse links
### UX
- [x] User clicks on node in pipeline graph and opens a new tab with job
- [ ] Tab title should be: status icon - name - close button
- [x] Clicking a tab should create a sharable link
- [ ] Open sharable link should open the tab
- [ ] User clicks on a job in dropdown in the graph and opens a new tab with job
- [x] User can close job tab
- [x] When job tab is closed, the first tab should became visible
## Screenshots (if relevant)
![Screen_Shot_2017-07-20_at_15.28.20](/uploads/1e2cd71d113e3db1bf239d29bfe825fe/Screen_Shot_2017-07-20_at_15.28.20.png)
![Screen_Shot_2017-07-20_at_15.30.27](/uploads/f785a66fba507e1f6016152dad26218a/Screen_Shot_2017-07-20_at_15.30.27.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #34696Filipa Lacerdafilipa@gitlab.comFilipa Lacerdafilipa@gitlab.com