GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-09-26T13:46:17Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13893WIP: Expose per-project pipeline ID ($CI_PIPELINE_IID)2017-09-26T13:46:17ZShinya MaedaWIP: Expose per-project pipeline ID ($CI_PIPELINE_IID)## What does this MR do?
This MR creates new column `iid` on `ci_pipelines` and expose it as `$CI_PIPELINE_IID`.
This `iid` is per-project basis.
## Are there points in the code the reviewer needs to double check?
Does this migration ...## What does this MR do?
This MR creates new column `iid` on `ci_pipelines` and expose it as `$CI_PIPELINE_IID`.
This `iid` is per-project basis.
## Are there points in the code the reviewer needs to double check?
Does this migration work on production(GitLab.com)?
## Why was this MR needed?
Originally demanded at https://gitlab.com/gitlab-org/gitlab-ce/issues/3691. It got about 50 upvotes.
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close https://gitlab.com/gitlab-org/gitlab-ce/issues/3691
/cc @ayufan @bikebilly @grzesiek @godfat10.2Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12838Use admin_build for erase (Forbid Developer to erase job)2017-09-26T13:46:30ZShinya MaedaUse admin_build for erase (Forbid Developer to erase job)## What does this MR do?
This MR uses `admin_build` for `JobsController#erase`. This is for preventing developers to erase builds.
Old MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11538.
## Are there points in the code...## What does this MR do?
This MR uses `admin_build` for `JobsController#erase`. This is for preventing developers to erase builds.
Old MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11538.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
This is required at #31771
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close #3177110.2Shinya MaedaShinya Maeda