GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-07-11T15:18:39Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9433Add simple lightbox feature to markdown images2017-07-11T15:18:39Zusername-removed-419825Add simple lightbox feature to markdown images## What does this MR do?
- Open full-screen view of image in a lightbox when clicked
## Why was this MR needed?
- Improve the UX of viewing images in MRs and Issues
## Screenshots (if relevant)
## Does this MR meet the acceptance crit...## What does this MR do?
- Open full-screen view of image in a lightbox when clicked
## Why was this MR needed?
- Improve the UX of viewing images in MRs and Issues
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #28387https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12804fix: consistent aligning of project list2017-07-28T02:49:24Zusername-removed-400681sebdeckers83@gmail.comfix: consistent aligning of project list## What does this MR do?
Trying to fix uneven alignment of descriptions containing links and emoji in the project list.
## Are there points in the code the reviewer needs to double check?
I didn't run this. Just used devtools and then...## What does this MR do?
Trying to fix uneven alignment of descriptions containing links and emoji in the project list.
## Are there points in the code the reviewer needs to double check?
I didn't run this. Just used devtools and then made this change in this file where I saw the relevant selector. Not sure if it breaks other places. Hope there's test coverage for this type of thing. Sorry, new to this project.
## Why was this MR needed?
Clean UI
## Screenshots (if relevant)
Before:
![Screen_Shot_2017-07-12_at_11.06.02_AM](/uploads/0c74a822e9d32ce166c9727c275e88d4/Screen_Shot_2017-07-12_at_11.06.02_AM.png)
After:
![Screen_Shot_2017-07-12_at_11.05.52_AM](/uploads/9e7a02907f76556e23439a02b96e2df4/Screen_Shot_2017-07-12_at_11.05.52_AM.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13083WIP: Add group wiki support2017-09-21T11:26:49Zusername-removed-43728WIP: Add group wiki supportThis MR adds wiki page support to groups.
General workflow looks like:
- on group settings page, user can select `Wiki Project`. In this dropdown exist all group projects with enabled wiki.
- on group page user sees `Wiki` tab
- on...This MR adds wiki page support to groups.
General workflow looks like:
- on group settings page, user can select `Wiki Project`. In this dropdown exist all group projects with enabled wiki.
- on group page user sees `Wiki` tab
- on this tab user sees wiki from selected project. All wiki behavior occurs in group context (all links behave as group links)
I'm not sure in dropdown on group settings page (I like dropdowns from MR page)
Tests and docs not implemented/fixed yet.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] Changes for admin area
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #4037Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13760Fixed: sidebar list-style fixed2017-09-07T14:28:40Zusername-removed-1555419Fixed: sidebar list-style fixed## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [x] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?username-removed-1555419username-removed-1555419https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13859Link to project labels page2017-09-10T20:26:49Zusername-removed-911300Link to project labels page## What does this MR do?
Fixes the issue - https://gitlab.com/gitlab-org/gitlab-ce/issues/23472
## Are there points in the code the reviewer needs to double check?
Please check the screenshot to ensure that this satisfies UX criteria
#...## What does this MR do?
Fixes the issue - https://gitlab.com/gitlab-org/gitlab-ce/issues/23472
## Are there points in the code the reviewer needs to double check?
Please check the screenshot to ensure that this satisfies UX criteria
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitlab-ce/issues/23472
## Screenshots (if relevant)
![Screen_Shot_2017-08-28_at_12.11.39_AM](/uploads/c42dd46b2b8541d8fb488a5653d8860d/Screen_Shot_2017-08-28_at_12.11.39_AM.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
23472username-removed-911300username-removed-911300https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13884Resolve "Customize branch name when using create branch in an issue"2017-11-29T12:45:12Zusername-removed-86853blackst0ne.ru@gmail.comResolve "Customize branch name when using create branch in an issue"## What does this MR do?
This MR adds an ability to type a custom branch name in the `Create merge request` dropdown placed in an issue.
## TODO
* [ ] Add backend specs
* [ ] Add frontend specs
## Are there points in the code th...## What does this MR do?
This MR adds an ability to type a custom branch name in the `Create merge request` dropdown placed in an issue.
## TODO
* [ ] Add backend specs
* [ ] Add frontend specs
## Are there points in the code the reviewer needs to double check?
![create_mr_button](/uploads/8f5e06e455a85500973334797c563ede/create_mr_button.gif)
## Why was this MR needed?
It improves UX of branch management.
## Screenshots (if relevant)
To be added.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2114310.1username-removed-86853blackst0ne.ru@gmail.comusername-removed-86853blackst0ne.ru@gmail.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13970Fixed width layout: Messages2017-09-11T12:24:30Zusername-removed-911300Fixed width layout: Messages## What does this MR do?
https://gitlab.com/gitlab-org/gitlab-ce/issues/32868
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitlab-ce/issues/32868
## Scree...## What does this MR do?
https://gitlab.com/gitlab-org/gitlab-ce/issues/32868
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitlab-ce/issues/32868
## Screenshots (if relevant)
![Screen_Shot_2017-08-31_at_10.05.28_PM](/uploads/f1b496571100ecf98a7c5ce26a7b98a7/Screen_Shot_2017-08-31_at_10.05.28_PM.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?username-removed-911300username-removed-911300https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14497Customizable favicon2017-10-02T13:49:24Zusername-removed-81730Customizable favicon## What does this MR do?
Allows changing the default favicon to a custom icon. The CI status favicons are generated from the original image as well.
- [x] Upload custom favicon in appearance settings
- [x] Main favicon is replaced by t...## What does this MR do?
Allows changing the default favicon to a custom icon. The CI status favicons are generated from the original image as well.
- [x] Upload custom favicon in appearance settings
- [x] Main favicon is replaced by the custom one
- [x] All CI status favicons are generated from the uploaded image
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
GitLab already allows to customize the login screen and the header logo. Allowing to customize the favicon as well greatly helps differentiating the different GitLab instances.
The development of this MR is sponsored by @ siemens (/cc @bufferoverflow).
## Screenshots (if relevant)
**Appearance settings**
![image](/uploads/bb40875a810bbf475b91c54292264fd1/image.png)
**CI status icon**
![image](/uploads/16405a1791305e5add5477ea96085271/image.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15661https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14726Fix inconsistent placeholder text in group search fields2017-10-06T09:57:25Zusername-removed-419655Fix inconsistent placeholder text in group search fields## What does this MR do?
Fix inconsistent placeholder text in group search fields
## Why was this MR needed?
Please see #38807
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https...## What does this MR do?
Fix inconsistent placeholder text in group search fields
## Why was this MR needed?
Please see #38807
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38807username-removed-419655username-removed-419655