GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-09-19T23:15:53Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7412Improvements to hover/active/focus states in header items2019-09-19T23:15:53Zusername-removed-816736devesh.khandelwal@outlook.comImprovements to hover/active/focus states in header items## What does this MR do?
Adds some improvements to buttons, dropdowns, inputs, etc. in the header area.
## Are there points in the code the reviewer needs to double check?
I'm not sure.
## Why was this MR needed?
Requested...## What does this MR do?
Adds some improvements to buttons, dropdowns, inputs, etc. in the header area.
## Are there points in the code the reviewer needs to double check?
I'm not sure.
## Why was this MR needed?
Requested in an issue.
## Screenshots (if relevant)
![caret](/uploads/574135282e4b2e81476fdd6dd6c1c05d/caret.gif)![hover](/uploads/15a3b8a2aa89baf20270be97c452e006/hover.gif)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24202
This is not complete yet. I'm new to this, so please let me know what all steps do I need to do (tests, changelog, etc.).8.14https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14249Resolve "Scope users by group inside dropdowns if I'm on group page (Issue, M...2018-12-14T00:03:54Zusername-removed-128633Resolve "Scope users by group inside dropdowns if I'm on group page (Issue, MRs)"## What does this MR do?
This retrieve the current group ID in the user dropdowns on the group's issuable list page so that only the group's members are returned in the filtering dropdowns (author and assignee).
## Are there points...## What does this MR do?
This retrieve the current group ID in the user dropdowns on the group's issuable list page so that only the group's members are returned in the filtering dropdowns (author and assignee).
## Are there points in the code the reviewer needs to double check?
The `data-group-id` is already set on the search filter input (https://gitlab.com/gitlab-org/gitlab-ce/blob/46bdcd64056e8e5ed8d397b0ad5accaa7e5e9d06/app/helpers/search_helper.rb#L150-152), the only missing part was to retrieve it on the JS side.
## Why was this MR needed?
To make the scoping of users consistent between the project's issuable list page and the group's issuable list page, as noted here: https://gitlab.com/gitlab-org/gitlab-ce/issues/20824#note_40119351.
## Screenshots
For the following group members:
![group-members](/uploads/655d602617d3bb059b8877f080398799/group-members.png)
| Before | After |
| ------ | ----- |
| ![before0](/uploads/0917b88edfbe21b83e6620773cc632a9/before0.png) | ![after0](/uploads/d1a39f458689541541814acf8436eb73/after0.png) |
| ![before1](/uploads/78020dce01a2ffd07df10f53b1fb83d3/before1.png) | ![after1](/uploads/924a80e0801ec3452620e1517d1da305/after1.png) |
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2082410.1Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14225Make the labels in the Compare form less confusing2018-12-14T00:03:53Zusername-removed-128633Make the labels in the Compare form less confusing## What does this MR do?
* Improve the descriptive text
* Rename "from" to "Target" and "to" to "Source"
* Swap "Target" and "Source" to have the same order as in MRs
* Reworded "Switch base of comparison" to "Swap versions"
## ...## What does this MR do?
* Improve the descriptive text
* Rename "from" to "Target" and "to" to "Source"
* Swap "Target" and "Source" to have the same order as in MRs
* Reworded "Switch base of comparison" to "Swap versions"
## Are there points in the code the reviewer needs to double check?
I didn't update the params name (i.e. `from` and `to`) as they're used in a lot of different context and they're not shown to the end-user in the compare page.
## Why was this MR needed?
Because the page was confusing.
## Screenshots (if relevant)
| Before | After |
| ------ | ----- |
| ![before0](/uploads/4496935afa572e068dfa9c7e482a5bf0/before0.png) | ![after0](/uploads/bec7283e0f3fd18abbc39916316d2e90/after0.png) |
| ![before1](/uploads/687b4bf64cbf21df8d6ca665b892a00c/before1.png) | ![after1](/uploads/fca9a6048c360b70e9ba7abd81da02d1/after1.png) |
| ![before2](/uploads/600bacb3896467641b0679603d713e5d/before2.png) | ![after2](/uploads/79207d11c545dea24583f7dc747df19e/after2.png) |
| ![before3](/uploads/ee6a165a41a67772e698058099ff2e92/before3.png) | ![after3](/uploads/247a3dc9d530c5cf3c27d9e9c0645e19/after3.png) |
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Review
- [x] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2133110.1Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14111Add missing classes to omniauth remember-me checkbox and add correct font-size2018-12-14T00:03:53Zusername-removed-507451Add missing classes to omniauth remember-me checkbox and add correct font-size## What does this MR do?
This is a fix for the issue reported at https://gitlab.com/gitlab-org/gitlab-ce/issues/37551
## Are there points in the code the reviewer needs to double check?
I made the markup consistent with the top re...## What does this MR do?
This is a fix for the issue reported at https://gitlab.com/gitlab-org/gitlab-ce/issues/37551
## Are there points in the code the reviewer needs to double check?
I made the markup consistent with the top remember me checkbox as they looked like generic classes in form.scss
Can add them as distinct classes if that isn't the case.
## Screenshots (if relevant)
Before:
![before](/uploads/210397b15ce81c428b2c323078452060/before.png)
After:
![gitlab-ui-polish-remember-me](/uploads/b2fc4873c8029f1724edd537a849995b/gitlab-ui-polish-remember-me.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/3755110.1Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14396Resolve "[Meta] Create Uniquely 'GitLab' Icons"2018-12-14T00:03:01ZSarrah Vesselovsvesselov@gitlab.comResolve "[Meta] Create Uniquely 'GitLab' Icons"## What does this MR do?
Update icon style information to reflect the new system.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
The 10 release post details our updated ic...## What does this MR do?
Update icon style information to reflect the new system.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
The 10 release post details our updated icons and points to this area, it needed a quick update to reflect the new information.
## Screenshots (if relevant)
![Screen_Shot_2017-09-20_at_2.59.15_PM](/uploads/52c0caae262fc6f02576e86a66533ebf/Screen_Shot_2017-09-20_at_2.59.15_PM.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #3289410.0username-removed-236961username-removed-236961https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14552Added popover paradigm to ux guide2017-10-05T19:11:23ZDimitrie Hoekstradimitrie@gitlab.comAdded popover paradigm to ux guide## What does this MR do?
Adds pop-over paradigm to UX guide
## Are there points in the code the reviewer needs to double check?
-
## Why was this MR needed?
Paradigms need to be documented
## Screenshots (if relevant)
See ...## What does this MR do?
Adds pop-over paradigm to UX guide
## Are there points in the code the reviewer needs to double check?
-
## Why was this MR needed?
Paradigms need to be documented
## Screenshots (if relevant)
See http://localhost:3000/help/development/ux_guide/components.md
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-design/issues/45
Closes https://gitlab.com/gitlab-org/gitlab-design/issues/36
https://gitlab.com/gitlab-org/gitlab-ce/issues/38609Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14668Fix inconsistent use of sentence case2017-10-05T08:00:18ZJames RamsayFix inconsistent use of sentence case## What does this MR do?
Fixes inconsistent use of sentence case in the file list headings
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Headings should be sentence case (see https://d...## What does this MR do?
Fixes inconsistent use of sentence case in the file list headings
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Headings should be sentence case (see https://docs.gitlab.com/ce/development/ux_guide/copy.html#case)
## Screenshots (if relevant)
![image](/uploads/24dad703281c2ee646b0f514fce1bb70/image.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
n/aDouwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14596Fix edit project service cancel button position2017-10-04T16:47:53Zusername-removed-1631530Fix edit project service cancel button position## What does this MR do?
Fixes the alignment of the cancel button on the project service settings page.
## Are there points in the code the reviewer needs to double check?
I think it's good to go.
## Why was this MR needed?
The ...## What does this MR do?
Fixes the alignment of the cancel button on the project service settings page.
## Are there points in the code the reviewer needs to double check?
I think it's good to go.
## Why was this MR needed?
The cancel button is currently misaligned in the project service settings UI.
## Screenshots
### Broken
![broken](/uploads/13ae25d98fb98ca350040aa055196e8d/broken.png)
![broken-html](/uploads/f9e7772d8d9f4d0efe713b9ffb441b00/broken-html.png)
### Fixed
![fixed](/uploads/2a4ab11496ccec3b1a406b87a56cb4d9/fixed.png)
![fixed-html](/uploads/7e2fb5d68d1058207af57fb0e18adf20/fixed-html.png)
## Does this MR meet the acceptance criteria?
- [X] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [X] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/3555510.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14295Fix the default branches sorting to actually be 'Last updated'2017-10-04T15:21:27Zusername-removed-128633Fix the default branches sorting to actually be 'Last updated'EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2931
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] Tests added ...EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2931
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2689010.1Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14556Added skeleton loading paradigm to UX guide2017-10-03T15:26:57ZDimitrie Hoekstradimitrie@gitlab.comAdded skeleton loading paradigm to UX guide## What does this MR do?
Adds skeleton loading paradigm to ux guide
## Are there points in the code the reviewer needs to double check?
-
## Why was this MR needed?
Paradigms need to be documented
## Screenshots (if relevant)
See htt...## What does this MR do?
Adds skeleton loading paradigm to ux guide
## Are there points in the code the reviewer needs to double check?
-
## Why was this MR needed?
Paradigms need to be documented
## Screenshots (if relevant)
See http://localhost:3000/help/development/ux_guide/components.md
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-design/issues/3510.1Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13097Guidelines for illustrations2017-09-29T04:28:16ZHazel YangGuidelines for illustrationsAdd the illustration guidelines to UX guidelines.Add the illustration guidelines to UX guidelines.username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14456Update color variables2017-09-26T01:13:20Zusername-removed-626804Update color variables## What does this MR do?
Updates light colors, and removes ’25’ and add ‘950’ shades
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [x] Conform b...## What does this MR do?
Updates light colors, and removes ’25’ and add ‘950’ shades
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
## What are the relevant issue numbers?
#3109410.1Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14331Resolve "Improve “New project“ page description explaining what a project is"2017-09-18T15:04:40Zusername-removed-626804Resolve "Improve “New project“ page description explaining what a project is"## What does this MR do?
Improve “New project“ page description
Explain what a project is instead of what a user can do
## Screenshots (if relevant)
| Before | After |
|---|---|
| ![image](/uploads/36354fa9af3d5a09f4be1e0c3a56ab63/im...## What does this MR do?
Improve “New project“ page description
Explain what a project is instead of what a user can do
## Screenshots (if relevant)
| Before | After |
|---|---|
| ![image](/uploads/36354fa9af3d5a09f4be1e0c3a56ab63/image.png) | ![image](/uploads/c008ecd367074b85bd01b285cce90459/image.png) |
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- Review
- [x] Has been reviewed by UX
- [x] Has been reviewed by Frontend
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #37933Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8650Added UX improvements to the project members settings view2017-09-14T01:03:14ZJose Ivan Vargas LopezAdded UX improvements to the project members settings view## What does this MR do?
Truncates the project title on really long titles in the panel header for the project members list
Adds a description to non project owners or masters in the left column
## Are there points in the code the r...## What does this MR do?
Truncates the project title on really long titles in the panel header for the project members list
Adds a description to non project owners or masters in the left column
## Are there points in the code the reviewer needs to double check?
None at the moment
## Why was this MR needed?
To improve the UX of the project members settings view
## Screenshots (if relevant)
### Before
#### Description to non project owners or masters
![members_without_description_for_non_project_owners](/uploads/34b7600279e1ecb0f0a3b257315a65b4/members_without_description_for_non_project_owners.jpeg)
#### Long titles move things around in the panel header
![long_project_titles_move_things_around](/uploads/0678bcf5ffb0d1185558b0778603be2d/long_project_titles_move_things_around.jpeg)
### After
#### Description to non project owners or masters
![members_description_to_non_project_masters](/uploads/3bc6cbc9bd34855b24e590007cb89c0d/members_description_to_non_project_masters.jpeg)
#### Truncated title after a set limit of 18 characters
![Members_ux_observations](/uploads/10ef2b62ebe242a3023014026f92f6a0/Members_ux_observations.jpeg)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #26883
## EE Port
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/17129.2Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10689Centered empty state for issues2017-09-14T01:02:10ZJose Ivan Vargas LopezCentered empty state for issues## What does this MR do?
Centers the issues empty state
## Why was this MR needed?
To fix an ongoing regression
## Screenshots
| Before | After |
| -------- | -------- |
|![Screen_Shot_2017-04-13_at_11.36.13_AM](/uploads/004899ec0b96a...## What does this MR do?
Centers the issues empty state
## Why was this MR needed?
To fix an ongoing regression
## Screenshots
| Before | After |
| -------- | -------- |
|![Screen_Shot_2017-04-13_at_11.36.13_AM](/uploads/004899ec0b96a5f3415ed73077f653df/Screen_Shot_2017-04-13_at_11.36.13_AM.png)| ![Screen_Shot_2017-04-13_at_11.32.37_AM](/uploads/8fec5b043f3f361e73cc98f49d7289f2/Screen_Shot_2017-04-13_at_11.32.37_AM.png)|
## Does this MR meet the acceptance criteria?
- [X] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [X] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
closes #308729.1Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14011Make blob viewer wider for mobile2017-09-09T14:03:26Zusername-removed-100770Make blob viewer wider for mobile## What does this MR do?
Makes the blob viewer for rich contents (e.g. `.md`) wider for mobile.
## Are there points in the code the reviewer needs to double check?
While this MR contains media query keeping the relevant declaration, i...## What does this MR do?
Makes the blob viewer for rich contents (e.g. `.md`) wider for mobile.
## Are there points in the code the reviewer needs to double check?
While this MR contains media query keeping the relevant declaration, is this truly needed? If not, we can remove the declaration.
## Why was this MR needed?
On a mobile device, the blob viewer for rich contents (e.g. `.md`) is too narrow to read. This MR improves UX for that.
Top/Bottom margins are unchanged as is before !12198.
## Screenshots (if relevant)
| before | after |
|:------:|:-----:|
| ![rich-blob-before](/uploads/ddc702798714c6b0097fa3b08cb528c1/rich-blob-before.png) | ![rich-blob-after](/uploads/d9011c1f2c3025498cfbe2993098a963/rich-blob-after.png) |
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [n/a] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [n/a] API support added
- [n/a] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [n/a] Has been reviewed by Frontend
- [n/a] Has been reviewed by Backend
- [n/a] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #3736810.0Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13949Print notes number explained in the graph.2017-09-08T10:54:42Zusername-removed-193742Print notes number explained in the graph.## What does this MR do?
Gives more user-friendly information about notes number for commit in branches graph view.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
## Screenshots (if re...## What does this MR do?
Gives more user-friendly information about notes number for commit in branches graph view.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [x] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #37224.10.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14096Fix stray OR in New Project page2017-09-07T13:39:01Zusername-removed-1113013Fix stray OR in New Project page## What does this MR do?
Removes the stray "OR" divider that appears in the New Project page when all import sources are disabled on the instance.
## Are there points in the code the reviewer needs to double check?
No.
## Why...## What does this MR do?
Removes the stray "OR" divider that appears in the New Project page when all import sources are disabled on the instance.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
Fixes a bug in 9.5.x.
## Screenshots (if relevant)
Before:
![image](/uploads/5fa1d242b098a5ebde1016b41bc9806f/image.png)
After:
![image](/uploads/36b2fd93c96bab91920b9a25659f0314/image.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.0username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7827Added initial todo functionality to collapsed sidebar2017-09-05T14:34:30ZDimitrie Hoekstradimitrie@gitlab.comAdded initial todo functionality to collapsed sidebar## What does this MR do?
Adds todo functionality to the collapsed sidebar in the issue and mr view
## Are there points in the code the reviewer needs to double check?
it still needs:
- [x] check on accessibility aria stuff
- [x] tool...## What does this MR do?
Adds todo functionality to the collapsed sidebar in the issue and mr view
## Are there points in the code the reviewer needs to double check?
it still needs:
- [x] check on accessibility aria stuff
- [x] tooltip
- [x] loading spinner icon should temp replace the icons
- [x] should work/show state across states of sidebar (open/closed)
## Why was this MR needed?
#24805
## Screenshots (if relevant)
![2017-03-24_16.09.02](/uploads/7c7b370e19811d06fb426d639b40d0ec/2017-03-24_16.09.02.gif)
![image](/uploads/0bf37e1fe4eadcaaf074e4773ee72c0f/image.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #248059.1Filipa Lacerdafilipa@gitlab.comFilipa Lacerdafilipa@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13387Enable the new navigation by default2017-09-01T12:00:45ZPhil Hughesme@iamphill.comEnable the new navigation by default## What does this MR do?
Enables the new navigation by default for all users.
This merge request does not remove any reference to `show_new_nav?` & it does not remove the new stylesheets. Rather than holding this up, we should tack...## What does this MR do?
Enables the new navigation by default for all users.
This merge request does not remove any reference to `show_new_nav?` & it does not remove the new stylesheets. Rather than holding this up, we should tackle that in a different merge request as tech debt as soon as this is merged.Tim ZallmannTim Zallmann