GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-10-25T00:07:40Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14528Move all API authentication code to APIGuard2017-10-25T00:07:40ZDouwe MaanMove all API authentication code to APIGuardDepends on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14525.Depends on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14525.10.1Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14527WIP: Simplify ApplicationController ldap_security_check2017-09-27T16:28:41ZDouwe MaanWIP: Simplify ApplicationController ldap_security_check10.1Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14462WIP: Adds requirements that supports anything in sha params2017-10-25T00:06:38Zusername-removed-1616781g.guilhermevieira@gmail.comWIP: Adds requirements that supports anything in sha params## What does this MR do?
Fix the 404 error in API when the branch has a dot in its name as stated in #26561 and in #2709.
## Why was this MR needed?
Since we use Grape gem, every param we define for a given endpoint is restricte...## What does this MR do?
Fix the 404 error in API when the branch has a dot in its name as stated in #26561 and in #2709.
## Why was this MR needed?
Since we use Grape gem, every param we define for a given endpoint is restricted to a default format. This default format does not allow dots in value, so whenever we have a `:sha` param we are going to explicitly allow any kind of text for it to work. This has been already done for some endpoints, so I just replicated the strategy for the other cases.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [x] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [X] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #26561, #2709username-removed-1616781g.guilhermevieira@gmail.comusername-removed-1616781g.guilhermevieira@gmail.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13917Resolve "Pages API"2017-10-24T23:59:38Zusername-removed-745767Resolve "Pages API"## What does this MR do?
Add's CRUD API end points for Pages Domains.
## Are there points in the code the reviewer needs to double check?
Yes! :smile:
- Is it appropriate to expose raw certificate and key? See `pages/domains/...## What does this MR do?
Add's CRUD API end points for Pages Domains.
## Are there points in the code the reviewer needs to double check?
Yes! :smile:
- Is it appropriate to expose raw certificate and key? See `pages/domains/:domain/details`.
- This introduces ability to edit an existing domain that is not possible in the UI. Primary use cases are:
- Update expiring certificate
- Convert existing domain from http to https
- Is API json schema correctly declared?
- Should there be a distinction between a single domain response and a list response?
- Review security policy (probably a separate issue but here for reference)
- The existing Domain Pages UI controllers only utilize `authorize_read_pages` and `authorize_update_pages`.
- Current policy⦠(owner,admin: `remove_pages`), (master: `admin_pages`,`read_pages`,`update_pages`)
- Are the tests handled in a reasonable way?
- Does every role need to be tested?
- Should the endpoints be disabled and return a particular response code if the pages facility is not enabled? See `require_pages_enabled`.
## Why was this MR needed?
Through the API, it is not currently possible to add, update, or remove pages domains with optional certificate on projects. Requested in issue #23000.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2300010.1username-removed-745767username-removed-745767https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13886FIX #36989 : use URI::Generic instead of URI::HTTP2017-09-11T12:54:11Zusername-removed-328296FIX #36989 : use URI::Generic instead of URI::HTTP## What does this MR do?
use URI::Generic instead of URI::HTTP for expose uri in _links in json response of project or issues
## What are the relevant issue numbers?
close #36989
close #37190 ## What does this MR do?
use URI::Generic instead of URI::HTTP for expose uri in _links in json response of project or issues
## What are the relevant issue numbers?
close #36989
close #37190 username-removed-328296username-removed-328296https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13782Add admin search option to API /users2017-08-28T22:34:46ZBrian NeelAdd admin search option to API /usersThis MR adds the ability to search for users based on admin status to the /users API.
I have a feeling there's a reason why the other options (active, blocked) do not allow searches for `false` status, but I couldn't determine it.This MR adds the ability to search for users based on admin status to the /users API.
I have a feeling there's a reason why the other options (active, blocked) do not allow searches for `false` status, but I couldn't determine it.Brian NeelBrian Neelhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13271WIP: Freeze API V32017-08-22T19:13:43ZToon ClaesWIP: Freeze API V3## What does this MR do?
It freezes the API V3 code.
## Are there points in the code the reviewer needs to double check?
Nothing that was changed for V3 already is not reverted.
## Why was this MR needed?
To avoid V4 changes breaks ...## What does this MR do?
It freezes the API V3 code.
## Are there points in the code the reviewer needs to double check?
Nothing that was changed for V3 already is not reverted.
## Why was this MR needed?
To avoid V4 changes breaks something in V3.
## File checklist
- [x] modified lib/api/api.rb
- [x] new file lib/api/v3/access_requests.rb
- [x] new file lib/api/v3/api.rb
- [x] new file lib/api/v3/api_guard.rb
- [x] modified lib/api/v3/boards.rb
- [x] modified lib/api/v3/branches.rb
- [x] modified lib/api/v3/broadcast_messages.rb
- [x] modified lib/api/v3/builds.rb
- [x] new file lib/api/v3/commit_statuses.rb
- [x] modified lib/api/v3/commits.rb
- [x] modified lib/api/v3/deploy_keys.rb
- [x] modified lib/api/v3/deployments.rb
- [x] modified lib/api/v3/entities.rb
- [x] modified lib/api/v3/environments.rb
- [x] new file lib/api/v3/events.rb
- [x] new file lib/api/v3/features.rb
- [x] modified lib/api/v3/files.rb
- [x] new file lib/api/v3/group_milestones.rb
- [x] new file lib/api/v3/group_variables.rb
- [x] modified lib/api/v3/helpers.rb
- [x] new file lib/api/v3/internal.rb
- [x] modified lib/api/v3/issues.rb
- [x] new file lib/api/v3/jobs.rb
- [x] new file lib/api/v3/keys.rb
- [x] modified lib/api/v3/labels.rb
- [x] new file lib/api/v3/lint.rb
- [x] modified lib/api/v3/members.rb
- [x] new file lib/api/v3/milestone_responses.rb
- [x] modified lib/api/v3/milestones.rb
- [x] new file lib/api/v3/namespaces.rb
- [x] modified lib/api/v3/notes.rb
- [x] new file lib/api/v3/notification_settings.rb
- [x] new file lib/api/v3/pagination_params.rb
- [x] new file lib/api/v3/pipeline_schedules.rb
- [x] modified lib/api/v3/pipelines.rb
- [x] modified lib/api/v3/project_hooks.rb
- [x] new file lib/api/v3/project_milestones.rb
- [x] modified lib/api/v3/project_snippets.rb
- [x] modified lib/api/v3/projects.rb
- [x] new file lib/api/v3/protected_branches.rb
- [x] modified lib/api/v3/repositories.rb
- [x] new file lib/api/v3/runner.rb
- [x] modified lib/api/v3/runners.rb
- [x] new file lib/api/v3/scope.rb
- [x] modified lib/api/v3/services.rb
- [x] new file lib/api/v3/session.rb
- [x] modified lib/api/v3/settings.rb
- [x] new file lib/api/v3/sidekiq_metrics.rb
- [x] modified lib/api/v3/snippets.rb
- [x] modified lib/api/v3/subscriptions.rb
- [x] modified lib/api/v3/system_hooks.rb
- [x] modified lib/api/v3/tags.rb
- [x] modified lib/api/v3/time_tracking_endpoints.rb
- [x] modified lib/api/v3/todos.rb
- [x] modified lib/api/v3/triggers.rb
- [x] modified lib/api/v3/users.rb
- [x] modified lib/api/v3/variables.rb
- [x] new file lib/api/v3/version.rb
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #35430.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13189fix gitlab-org/gitlab-ee#21902017-08-01T10:32:07Zusername-removed-226474fix gitlab-org/gitlab-ee#2190## What does this MR do?
fix gitlab-org/gitlab-ee#2190
When you get raw by `http://gitlab.example.com/api/v4/projects/user%2Fproj/repository/files/README.md/raw?ref=master`, got `404 not found`.
## Are there points in the code t...## What does this MR do?
fix gitlab-org/gitlab-ee#2190
When you get raw by `http://gitlab.example.com/api/v4/projects/user%2Fproj/repository/files/README.md/raw?ref=master`, got `404 not found`.
## Are there points in the code the reviewer needs to double check?
no, it's simple. I think.
## Why was this MR needed?
`http://gitlab.example.com/api/v4/projects/user%2Fproj/repository/files/README.md/raw?ref=master` returns 404. Developer cannot get raw file content directly.
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [ ] ~~[Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary~~
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- Review
- [ ] ~~Has been reviewed by UX~~
- [ ] ~~Has been reviewed by Frontend~~
- [ ] Has been reviewed by Backend
- [ ] ~~Has been reviewed by Database~~
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?9.5username-removed-226474username-removed-226474https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12724Resolve "Projects API: filter 'with_issues_enabled=true' returns projects wit...2017-07-18T16:49:44Zusername-removed-742162Resolve "Projects API: filter 'with_issues_enabled=true' returns projects with 'issues_enabled=false'"## What does this MR do?
#34055 Fix the Projects API returning projects when filtering with `issues_enabled=true` if they have the `issues` feature set to private.
## Are there points in the code the reviewer needs to double check?
Th...## What does this MR do?
#34055 Fix the Projects API returning projects when filtering with `issues_enabled=true` if they have the `issues` feature set to private.
## Are there points in the code the reviewer needs to double check?
The same probably also has to be done with `with_merge_requests_enabled`, but I did not include it in this MR. I can change it if needed.
## Why was this MR needed?
#34055.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #34055https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12599WIP: Provide tagger information on Tags API2017-09-12T10:05:09Zusername-removed-1420023WIP: Provide tagger information on Tags API## What does this MR do?
It includes the name and email of the author of an annotated tag and the time of the tagging to the Tag API.
## Are there points in the code the reviewer needs to double check?
Yes. I'm writing them down and I...## What does this MR do?
It includes the name and email of the author of an annotated tag and the time of the tagging to the Tag API.
## Are there points in the code the reviewer needs to double check?
Yes. I'm writing them down and I'll update this section ASAP.
Feedback on this ongoing work is more than welcome. :-)
## Why was this MR needed?
I'll update this section with a short summary. For now, please see issue #33021 for more information.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #33021.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11564WIP: Add support for diff context in MR notes API #311042017-06-13T13:09:24Zusername-removed-503978WIP: Add support for diff context in MR notes API #31104## What does this MR do?
This MR adds diff context to the notes api for diff notes.
## Are there points in the code the reviewer needs to double check?
* Are the api fields named correctly?
* How should I go about testing this?
* Am I...## What does this MR do?
This MR adds diff context to the notes api for diff notes.
## Are there points in the code the reviewer needs to double check?
* Are the api fields named correctly?
* How should I go about testing this?
* Am I extracting `:commit_id` correctly? Its not mentioned in #31104, but seems necessary so that outdated notes can be identified.
## Why was this MR needed?
To address #31104
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #31104https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11435Resolve "Updating Slack Notification not working by API"2017-07-28T22:48:38Zusername-removed-419655Resolve "Updating Slack Notification not working by API"## What does this MR do?
* New parameters for for chat notification services are accepted by the services API
* Some cosmetic updates to Service API documentation
* Add some services missing from the Service API Docs
## Are there poin...## What does this MR do?
* New parameters for for chat notification services are accepted by the services API
* Some cosmetic updates to Service API documentation
* Add some services missing from the Service API Docs
## Are there points in the code the reviewer needs to double check?
Tests. Currently the services tests are very generic. Should further tests be added for these specialised services?
## Why was this MR needed?
It's not currently possible to perform the same level of configuration of Chat Notification services via the API as it is through the web interface
Some services were undocumented here
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #32364
Closes #22306
Relates to https://gitlab.com/gitlab-org/gitlab-ee/issues/11209.3username-removed-419655username-removed-419655https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11228Made SSH Key access API available for non-admin users2017-07-25T21:21:43Zusername-removed-459552Made SSH Key access API available for non-admin users## What does this MR do?
* Make SSH Keys API accessible for all users
* list keys on each users
* get key on each user
* Make logged in user use the general API to modify their own keys
## Are there points in the code the re...## What does this MR do?
* Make SSH Keys API accessible for all users
* list keys on each users
* get key on each user
* Make logged in user use the general API to modify their own keys
## Are there points in the code the reviewer needs to double check?
Well all, and I might need some help π
## Why was this MR needed?
Because #29850.
The main reason is that there's no reasons to restrict the SSH key API, as it's all public keys.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#29850https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10805[#26858] WIP - API for cctray pipeline project2017-06-30T12:12:30Zusername-removed-758669[#26858] WIP - API for cctray pipeline project## What does this MR do?
Adds an API endpoint of
```
https://gitlab.com/api/v4/projects/2/pipelines/cc.xml
```
Returns Project XML according to the cctray standard https://github.com/erikdoe/ccmenu/wiki/Multiple-Project-Summary-Reportin...## What does this MR do?
Adds an API endpoint of
```
https://gitlab.com/api/v4/projects/2/pipelines/cc.xml
```
Returns Project XML according to the cctray standard https://github.com/erikdoe/ccmenu/wiki/Multiple-Project-Summary-Reporting-Standard which works on CCMenu.
Currently only support per project basis and takes the latest pipeline activity.
## Are there points in the code the reviewer needs to double check?
- [ ] Do we want to support multiple projects in a single call?
## Why was this MR needed?
Adding feature for https://gitlab.com/gitlab-org/gitlab-ce/issues/26858
## Screenshots (if relevant)
![Screen_Shot_2017-04-20_at_2.55.11_PM](/uploads/7a5f9c6e494e3698c920352651dc3e6f/Screen_Shot_2017-04-20_at_2.55.11_PM.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/26858
Closes #26858username-removed-758669username-removed-758669https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9842Add endpoints to list projects for a user2017-03-21T16:34:31Zusername-removed-419655Add endpoints to list projects for a user## What does this MR do?
Add endpoints to list projects for a user
This addition to the API provides project lists like the user profile
* Personal projects
* Contributed projects
## Does this MR meet the acceptance criteria?
- [x] ...## What does this MR do?
Add endpoints to list projects for a user
This addition to the API provides project lists like the user profile
* Personal projects
* Contributed projects
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #179319.1username-removed-419655username-removed-419655https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8826Add license attribute to the Projects API endpoint2017-09-28T04:40:31Zusername-removed-386624Add license attribute to the Projects API endpoint## What does this MR do?
This MR exposes the `license` of the given project in the Projects API. [Requested by Andrew Nesbitt](https://twitter.com/teabass/status/824311137424601089), I think this is a pretty obvious addition.
## Does ...## What does this MR do?
This MR exposes the `license` of the given project in the Projects API. [Requested by Andrew Nesbitt](https://twitter.com/teabass/status/824311137424601089), I think this is a pretty obvious addition.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)username-removed-386624username-removed-386624https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8557Switch to 'secret variable' name in variables endpoint API docs2017-01-13T14:23:48Zusername-removed-382401Switch to 'secret variable' name in variables endpoint API docsBoth web UI as well as other docs use 'secret variable' name instead of currently used 'build variable' in the API docs. This MR is to unify this by changing the API docs.Both web UI as well as other docs use 'secret variable' name instead of currently used 'build variable' in the API docs. This MR is to unify this by changing the API docs.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8160Add application create API2017-07-07T18:52:58Zusername-removed-852474Add application create API## What does this MR do?
Adding an API for creating applications
## Are there points in the code the reviewer needs to double check?
This is my first MR, i'm not sure about your good practices.
Also, i'm not native English spea...## What does this MR do?
Adding an API for creating applications
## Are there points in the code the reviewer needs to double check?
This is my first MR, i'm not sure about your good practices.
Also, i'm not native English speaker.
## Why was this MR needed?
It resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/24035
## Screenshots (if relevant)
Not relevant
## Does this MR meet the acceptance criteria?
- [ β] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [β ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ β] API support added
- Tests
- [ β] Added for this feature/bug
- [Γ , not my code?] All builds are passing
- [ β] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ β] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ β] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ β] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #240359.0username-removed-852474username-removed-852474https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7824WIP: Implement API endpoint to get all builds in an environment2017-03-16T14:38:05Zusername-removed-164769WIP: Implement API endpoint to get all builds in an environment## What does this MR do?
It implements a new API endpoint, `GET /projects/:id/environments/:environment_id/builds`, which allows the retrieval of all builds belonging to a certain environment
## Are there points in the code the reviewe...## What does this MR do?
It implements a new API endpoint, `GET /projects/:id/environments/:environment_id/builds`, which allows the retrieval of all builds belonging to a certain environment
## Are there points in the code the reviewer needs to double check?
All of it, essentially, since I have no previous experience w/ Grape and no clue if I did the right thing, especially when checking permissions.
## Why was this MR needed?
The motivation for this MR is described in #25084
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#25084username-removed-164769username-removed-164769https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7207Resolve "Password set emails for Users created by API"2019-09-19T22:46:53Zusername-removed-812482Resolve "Password set emails for Users created by API"## What does this MR do?
* Extracts user creation logic from admin area controller to a service
* Adds API functionality
* Obsoletes !6637
## Why was this MR needed?
* Common feature request (#21848)
* Adds equivalent API for Webapp a...## What does this MR do?
* Extracts user creation logic from admin area controller to a service
* Adds API functionality
* Obsoletes !6637
## Why was this MR needed?
* Common feature request (#21848)
* Adds equivalent API for Webapp action
## Does this MR meet the acceptance criteria?
- [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [X] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [X] API support added
- Tests
- [X] Added for this feature/bug
- [ ] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21848username-removed-812482username-removed-812482