GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2018-11-05T03:09:08Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14762WIP: Resolve "Issue with labels"2018-11-05T03:09:08ZMek StittriWIP: Resolve "Issue with labels"## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #42004James RamsayJames Ramsayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14614Add a GitLab QA test to ensure backups are created2017-10-04T16:10:49ZStan HuAdd a GitLab QA test to ensure backups are createdThis is a very basic test to ensure that the Rake task even creates a backup with `rake gitlab:backup:create`.
Start of gitlab-qa#22This is a very basic test to ensure that the Rake task even creates a backup with `rake gitlab:backup:create`.
Start of gitlab-qa#2210.1https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14409Refactor BackupManager#remove_old2017-10-02T17:41:56ZJames EJRefactor BackupManager#remove_old## What
Refactored BackupManager timestamp/regex handling.
Verified that tests were working correctly in response to https://gitlab.com/gitlab-org/gitlab-ce/issues/32796#note_30582742, and added names to describe the file names tes...## What
Refactored BackupManager timestamp/regex handling.
Verified that tests were working correctly in response to https://gitlab.com/gitlab-org/gitlab-ce/issues/32796#note_30582742, and added names to describe the file names tested
## Are there points in the code the reviewer needs to double check?
Yes, this will need to be rebased after the regex was updated in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14333
## Why
https://gitlab.com/gitlab-org/gitlab-ce/issues/32796#things-to-improve
>>>
- Improve the test suite so we're confident that no files that aren't supposed to be deleted could be deleted by an improper match
- Potentially move from a regex to something more procedural, with multiple guards
>>>
## Related
- https://gitlab.com/gitlab-org/gitlab-ce/issues/32796
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14333James EJJames EJhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13096Fix improperly skipped backups of wikis2017-08-11T10:23:10Zusername-removed-1144264Fix improperly skipped backups of wikis## What does this MR do?
Ensures that non-empty repos are backed up.
## Are there points in the code the reviewer needs to double check?
This will expire the `exists?` cache value for every project and wiki. I don't expect that to be ...## What does this MR do?
Ensures that non-empty repos are backed up.
## Are there points in the code the reviewer needs to double check?
This will expire the `exists?` cache value for every project and wiki. I don't expect that to be a problem, but if it might be, we could limit this to wikis since that's the known issue.
## Why was this MR needed?
In issue https://gitlab.com/gitlab-org/gitlab-ce/issues/28854, some wiki repos are skipped during backup, due to stale cache. I plan to properly expire the cache where necessary in another MR, but this is an immediate fix for a customer pain point, and it makes the backup process more robust, which I believe is worth it, regardless of proper cache expiration.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Fixes #288549.5Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12984Support custom directory in gitlab:backup:create task2017-08-31T04:44:32Zusername-removed-423116Support custom directory in gitlab:backup:create task## What does this MR do?
Adds a `DIRECTORY` environment variable which can be passed to the `gitlab:backup:create` rake task, in order to allow grouping backups into e.g. daily/weekly/monthly folders.
This development is sponsored ...## What does this MR do?
Adds a `DIRECTORY` environment variable which can be passed to the `gitlab:backup:create` rake task, in order to allow grouping backups into e.g. daily/weekly/monthly folders.
This development is sponsored by Siemens (/cc @bufferoverflow)
## Are there points in the code the reviewer needs to double check?
This would also make sense to have as a configuration variable in `gitlab.rb`, but for our use case we don't need it.
I only tested it with S3 and local storage, and assume Fog supports the same approach (path in the key) for other providers.
## Why was this MR needed?
Currently backups are always uploaded to the root folder, which makes it difficult to e.g. set up retention policies on S3.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/1391
https://gitlab.com/gitlab-org/gitlab-ce/issues/232219.5username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11962Fix backup task to continue on corrupt repositories2017-07-07T18:52:54ZJames LopezFix backup task to continue on corrupt repositoriesFixes #31767
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md...Fixes #31767
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)9.2Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11849Add fog-aliyun as backup storage provider2017-06-02T15:11:58Zusername-removed-128633Add fog-aliyun as backup storage provider_Originally opened at !9721 by @yuanfeiz._
- - -
## What does this MR do?
Add fog-aliyun as backup storage provider
## Why was this MR needed?
Aliyun is the main public cloud provider in China with a large user base installing gitla..._Originally opened at !9721 by @yuanfeiz._
- - -
## What does this MR do?
Add fog-aliyun as backup storage provider
## Why was this MR needed?
Aliyun is the main public cloud provider in China with a large user base installing gitlab as their private code repositories. This addition package enable that cohort of users to quickly backup their(interest claim: we are one of them :p ) Gitlab instance. It'd definitely bring benefit to this portion of the users while increase the confidence of choosing Gitlab on Aliyun solution.9.3username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11635Add missing regex to backup manager2017-09-19T17:11:35ZAchilleas PipinellisAdd missing regex to backup manager## What does this MR do?
!10901
introduced a new naming scheme for backups, but the code which
cleans up old backups wasn't updated accordingly. In order to
maintain backward compatibility, we need to account for 3 naming
schemes....## What does this MR do?
!10901
introduced a new naming scheme for backups, but the code which
cleans up old backups wasn't updated accordingly. In order to
maintain backward compatibility, we need to account for 3 naming
schemes.
http://rubular.com/r/dUx1D42p3i
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/326699.2https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10901Add GitLab version to backup file name2017-05-23T08:29:41ZAchilleas PipinellisAdd GitLab version to backup file name## What does this MR do?
Adds GitLab version to backup file name.
- **Previously**: 1493106747_2017_04_25_gitlab_backup.tar
- **Now**: 1493107263_2017_04_25{+_9.1.0+}_gitlab_backup.tar
## Are there points in the code the reviewer need...## What does this MR do?
Adds GitLab version to backup file name.
- **Previously**: 1493106747_2017_04_25_gitlab_backup.tar
- **Now**: 1493107263_2017_04_25{+_9.1.0+}_gitlab_backup.tar
## Are there points in the code the reviewer needs to double check?
- [x] Check if backup/restore works as intended with the new behaviour
- [x] Check if old backup files work as intended
Testing locally:
1. On `master` branch create backup:
```
bundle exec rake gitlab:backup:create
```
1. On `gl-version-backup-file` branch create backup:
```
bundle exec rake gitlab:backup:create
```
1. On `gl-version-backup-file` branch check that both restore filenames work:
Old backup filename:
```
bundle exec rake gitlab:backup:restore BACKUP=1493106747_2017_04_25
```
Make sure it worked.
---
New backup filename:
```
bundle exec rake gitlab:backup:restore 1493107263_2017_04_25_9.1.0-pre
```
Make sure it worked
## Why was this MR needed?
Make it easier to find out what version of GitLab is included in a backup file.
Otherwise you need to hack your way into it https://stackoverflow.com/questions/26035262/how-to-find-version-of-gitlab-backup.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?9.2username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10832Use backup path when taking backups during a restore2017-08-07T18:50:15Zusername-removed-1113013Use backup path when taking backups during a restore## What does this MR do?
Places backups taken during a restore in the configured backup path rather than the parent directory of the files to be backed up.
## Are there points in the code the reviewer needs to double check?
I di...## What does this MR do?
Places backups taken during a restore in the configured backup path rather than the parent directory of the files to be backed up.
## Are there points in the code the reviewer needs to double check?
I did not see a logical home for a test of this code change in backup_rake_spec.rb. If the reviewer feels a test is warranted, I'd appreciate some advice in this area.
## Why was this MR needed?
We have an HA cluster configured with custom shared data locations as specified in https://docs.gitlab.com/ee/administration/high_availability/nfs.html Attempts to restore a backup fail with a Permission Denied error. This is because the restore process attempts to move the existing artifacts (e.g., uploads) into a new timestamped directory that is in the parent directory of the existing artifacts. In our case, this parent directory is owned by root rather than the gitlab user. I imagine many users with custom data locations will get burned here. Rather than requiring and documenting that the parent folder be owned by the gitlab user, it makes more sense to me to put these backups in the already configured backup path.
Failure:
`
Restoring uploads ...
rake aborted!
Errno::EACCES: Permission denied @ rb_file_s_rename - (/gitlab-data/uploads, /gitlab-data/uploads.1492548489)
/opt/gitlab/embedded/service/gitlab-rails/lib/backup/files.rb:46:in 'backup_existing_files_dir'
/opt/gitlab/embedded/service/gitlab-rails/lib/backup/files.rb:37:in 'restore'
/opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/backup.rake:140:in 'block (4 levels) in <top (required)>'
/opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/backup.rake:57:in 'block (3 levels) in <top (required)>'
`
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?Drew BlessingDrew Blessinghttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9721Add fog-aliyun as backup storage provider2017-06-01T14:45:03Zusername-removed-954264Add fog-aliyun as backup storage provider## What does this MR do?
Add fog-aliyun as backup storage provider
## Why was this MR needed?
Aliyun is the main public cloud provider in China with a large user base installing gitlab as their private code repositories. This addition p...## What does this MR do?
Add fog-aliyun as backup storage provider
## Why was this MR needed?
Aliyun is the main public cloud provider in China with a large user base installing gitlab as their private code repositories. This addition package enable that cohort of users to quickly backup their(interest claim: we are one of them :p ) Gitlab instance. It'd definitely bring benefit to this portion of the users while increase the confidence of choosing Gitlab on Aliyun solution.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [-] API support added
- Tests
- [-] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
gitlab-org/gitlab-ce#268029.3username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9715Database SSL support for backup script.2019-09-20T01:41:48Zusername-removed-204741Database SSL support for backup script.## What does this MR do?
It allows the backup script not to fail for creating DB backups in the case a MySQL/PostgreSQL server using SSL connection is used to host the GitLab database.
## Are there points in the code the reviewer nee...## What does this MR do?
It allows the backup script not to fail for creating DB backups in the case a MySQL/PostgreSQL server using SSL connection is used to host the GitLab database.
## Are there points in the code the reviewer needs to double check?
Not realy, tested against a SSL-enabled and non-SSL MySQL server and a PostgreSQL one.
## Why was this MR needed?
To fix https://gitlab.com/gitlab-org/gitlab-ce/issues/1440
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [n/a] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [n/a] API support added
- Tests
- [n/a] Added for this feature/bug
- [x] All builds are passing
- [n/a] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [n/a] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/1440
## Notes
- MySQL options are those available with [currently used mysql2 adapter gem version](https://github.com/brianmario/mysql2/tree/0.3.20).
- PGSQL options are passed as [connection parameters](http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/PostgreSQLAdapter.html) to [libpq](https://www.postgresql.org/docs/current/static/libpq-connect.html).9.2Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9599Add storage class configuration option for Amazon S3 remote backups2017-05-03T13:08:20Zusername-removed-1152810Add storage class configuration option for Amazon S3 remote backups## What does this MR do?
Add storage class configuration option for Amazon S3 remote backups
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
Currently there is no way to explicit...## What does this MR do?
Add storage class configuration option for Amazon S3 remote backups
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
Currently there is no way to explicitly set the class of storage used when uploading backups to Amazon S3. The user must rely on object lifecycle configuration instead of explicitly setting the storage class during upload. This is not ideal because lifecycle configuration has some [inherent constraints](http://docs.aws.amazon.com/AmazonS3/latest/dev/lifecycle-transition-general-considerations.html#lifecycle-general-considerations-transition-sc) which may negatively affect cost / usability of this feature (e.g. To transition from `STANDARD` to `STANDARD_IA` we must first wait a period of 30 days, during which we pay more for a storage class we do not need).
## Screenshots (if relevant)
n/a
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/31009.0username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9031Fixed backup.rake colorize method following Pages -> CE2017-02-07T15:38:51ZJames EJFixed backup.rake colorize method following Pages -> CECherry-picks relevant changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/438 to fix backup.rake
Changes were missing from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8463
Slack: https://gitlab.slack.com/...Cherry-picks relevant changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/438 to fix backup.rake
Changes were missing from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8463
Slack: https://gitlab.slack.com/archives/build/p1486476442001209
>>>
$ sudo gitlab-rake gitlab:backup:create
Dumping database ...
Dumping PostgreSQL database gitlabhq_production ... [DONE]
done
Dumping repositories ...
* test/boom ... [DONE]
* test/boom.wiki ... [SKIPPED]
done
Dumping uploads ...
done
Dumping builds ...
done
Dumping artifacts ...
done
rake aborted!
NoMethodError: undefined method `blue' for "Dumping pages ... ":String
/opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/backup.rake:166:in `block (4 levels) in <top (required)>'
>>>
Was missing from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8463 and similar to https://gitlab.com/gitlab-org/gitlab-ce/issues/277868.17username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7739Stop supporting Google Cloud and Azure as backup strategies2017-01-05T11:02:14Zusername-removed-128633Stop supporting Google Cloud and Azure as backup strategies## What does this MR do?
It removes support for Azure and Google Cloud as backup strategies (via Fog).
Motivation behind this decision can be found in !4928, !6713 but basically they require a lot of gems that are unrelated to the back...## What does this MR do?
It removes support for Azure and Google Cloud as backup strategies (via Fog).
Motivation behind this decision can be found in !4928, !6713 but basically they require a lot of gems that are unrelated to the backup use-case.
## Are there points in the code the reviewer needs to double check?
Am I missing any other location where we'd use these gems?8.15Stan HuStan Huhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7606Add config param to specify subdirectory within S3 bucket where backups shoul...2017-09-06T12:22:16Zusername-removed-851787Add config param to specify subdirectory within S3 bucket where backups should be uploaded## What does this MR do?
Addresses Issue #23221.
Currently, there's no way to upload backups to an S3 bucket anywhere besides the root of the bucket.
This change adds an option to specify the path within the bucket where your backup f...## What does this MR do?
Addresses Issue #23221.
Currently, there's no way to upload backups to an S3 bucket anywhere besides the root of the bucket.
This change adds an option to specify the path within the bucket where your backup files should go.
The option simply makes use of Fog's ability to do what we're trying to do here.
## Are there points in the code the reviewer needs to double check?
N/A
## Why was this MR needed?
Issue #23221
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ x ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ x ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ x ] All builds are passing
- [ x ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ x ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ x ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ x ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#23221https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/718823718/backup rake task human readable2017-02-06T14:24:10Zusername-removed-81244823718/backup rake task human readable## What does this MR do?
Add the human readable format to the backup tar file.
From `1477317140_gitlab_backup.tar` to `1477317140_2016_10_24_gitlab_backup.tar`.
## Are there points in the code the reviewer needs to double check?
## Wh...## What does this MR do?
Add the human readable format to the backup tar file.
From `1477317140_gitlab_backup.tar` to `1477317140_2016_10_24_gitlab_backup.tar`.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
#23718 issue
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
237188.15Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7108Specify which Fog storage drivers are imported by default in backup_restore.md2016-10-25T21:36:44ZAchilleas PipinellisSpecify which Fog storage drivers are imported by default in backup_restore.mdReplaces https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5783Replaces https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/57838.14Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7072Specify which Fog storage drivers are imported by default in backup_restore.md2016-10-25T20:30:28ZAchilleas PipinellisSpecify which Fog storage drivers are imported by default in backup_restore.mdReplaces https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5783Replaces https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/57838.14Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7046Add an example of how to run the backups when using docker to the docs2016-10-24T14:54:12ZDJ MountneyAdd an example of how to run the backups when using docker to the docs## What does this MR do?
Add an example of how to run the backups when using docker to the docs
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry add...## What does this MR do?
Add an example of how to run the backups when using docker to the docs
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/omnibus-gitlab/issues/16168.14Achilleas PipinellisAchilleas Pipinellis