GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-09-20T03:32:06Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8923Fix missing group members from Import/Export2019-09-20T03:32:06ZJames LopezFix missing group members from Import/ExportFixes https://gitlab.com/gitlab-org/gitlab-ce/issues/25124
I/E does not export any group members (only the project members). This MR adds the ability to export them as part of the project members of the project (as long as the user has ...Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/25124
I/E does not export any group members (only the project members). This MR adds the ability to export them as part of the project members of the project (as long as the user has the required permissions to do so).
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)8.17username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12990Raise encoding confidence threshold to 502019-09-20T03:22:02Zusername-removed-423915Raise encoding confidence threshold to 50## What does this MR do?
Raise encoding confidence threshold to 50
## Why was this MR needed?
It is recommended that we set this to 50:
https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746
In this particular is...## What does this MR do?
Raise encoding confidence threshold to 50
## Why was this MR needed?
It is recommended that we set this to 50:
https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746
In this particular issue, the confidence was 42 for Shift JIS,
but in fact that's encoded in UTF-8 just with a single bad
character. In this case, we shouldn't try to treat it as Shift JIS,
but just treat it as UTF-8 and remove invalid bytes.
Treating it like Shift JIS would corrupt the whole data.
Unfortunately, the diff which would cause this could not be
disclosed therefore we can't use it as a test example.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [ ] Added for this feature/bug
## What are the relevant issue numbers?
Closes #350989.5username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12840Recover from renaming project that has container images2019-09-20T03:16:37ZGrzegorz BizonRecover from renaming project that has container images## What does this MR do?
This MR makes it possible to avoid inconsistent repository state / exception being raised when renaming project that has container repositories with tags associates.
## Does this MR meet the acceptance criteria...## What does this MR do?
This MR makes it possible to avoid inconsistent repository state / exception being raised when renaming project that has container repositories with tags associates.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] Tests for this fix
## What are the relevant issue numbers?
Closes gitlab-org/gitlab-ce#230199.4username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12236Partially revert 1e8dbd462019-09-20T02:45:07ZRobert SpeicherPartially revert 1e8dbd469.3Stan HuStan Huhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11398Fix Git-over-HTTP rejections2019-09-20T02:33:50Zusername-removed-1144264Fix Git-over-HTTP rejections## What does this MR do?
It fixes the HTTP status code and rendered error message when rejecting Git access to public projects (it is always 404 when it should sometimes be 401 or a different error message). See https://gitlab.com/gitla...## What does this MR do?
It fixes the HTTP status code and rendered error message when rejecting Git access to public projects (it is always 404 when it should sometimes be 401 or a different error message). See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11259#note_29331791 for when this was discovered.
* Pushes authorization logic out of GitHttpController and into GitAccess
* Surfaces GitAccess error messages directly, instead of always “Access denied”. We already do this in EE
* Do not short-circuit GitAccess usage, e.g. the “Project not found” error
* Makes HTTP status codes more accurate
* Adds more tests to ensure Git-over-HTTP behaves as desired
* Tests Git-over-HTTP error messages as well as status codes
* Fixes some broken tests
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11259#note_29331791
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)9.3Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11222Fix transient job failures relating to "unhandled Promise rejection" in issue...2019-09-20T02:01:58Zusername-removed-636429Fix transient job failures relating to "unhandled Promise rejection" in issue boards## What does this MR do?
Adds proper error handling to failed AJAX requests
## Are there points in the code the reviewer needs to double check?
all tests should pass
## Why was this MR needed?
Changes in !9846 now block AJAX request...## What does this MR do?
Adds proper error handling to failed AJAX requests
## Are there points in the code the reviewer needs to double check?
all tests should pass
## Why was this MR needed?
Changes in !9846 now block AJAX requests generated by javascript after an RSpec test is completed waiting for already-pending requests to finish, it would catch the errors these failing requests where they previously would have been ignored.
## Screenshots (if relevant)
n/a
## Does this MR meet the acceptance criteria?
- ~~[ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary~~
- ~~[ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~[ ] API support added~~
- Tests
- ~~[ ] Added for this feature/bug~~
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #320309.2username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10936Fix ordering of commits in the network graph.2019-09-20T01:58:38Zusername-removed-407765Fix ordering of commits in the network graph.## What does this MR do?
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1
- Prior to this upgrade, the default sort order for commits returned by
`Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the
...## What does this MR do?
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1
- Prior to this upgrade, the default sort order for commits returned by
`Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the
graph relied on.
- While upgrading `rugged`, the MR also changed this default to
`Rugged::SORT_NONE`, which broke commit ordering in the graph.
- This MR adds an option to `Gitlab::Git::Repository#find_commits` to sort
by date, and changes the graph builder `Network::Graph` so it explictly
requests the `:date` sort order
## What are the relevant issue numbers?
Closes #30973
<!--- start task list -->
## Tasks
- [X] Investigation
- [X] Implementation
- [ ] Tests
- [X] Added
- [X] Add more tests for `Network::Graph`
- [X] Compare results of this fix v/s 9.0 and confirm that there are no changes
- [ ] Passing
- [X] Meta
- [X] CHANGELOG entry created
- [X] ~~API support added~~
- [X] Branch has no merge conflicts with `master`
- [X] Squashed related commits together
- [X] ~~Added screenshots~~
- [X] Check for clean merge with EE
- [X] ~~Documentation added/updated~~
- [ ] Review
- [ ] Reviewer
- [ ] Maintainer
- [ ] Wait for merge
<!--- end task list -->9.1Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10768Destroy tooltip in async buttons and dropdowns2019-09-20T01:38:30ZFilipa Lacerdafilipa@gitlab.comDestroy tooltip in async buttons and dropdowns## What does this MR do?
Destroys the tooltip in async buttons and dropdowns
## Screenshots
![tooltips](/uploads/b0821ce900351d2cc114701d3db2f9b1/tooltips.gif)
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds...## What does this MR do?
Destroys the tooltip in async buttons and dropdowns
## Screenshots
![tooltips](/uploads/b0821ce900351d2cc114701d3db2f9b1/tooltips.gif)
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #309859.1Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9519Adds confirmation for cancel button2019-09-20T00:40:59ZFilipa Lacerdafilipa@gitlab.comAdds confirmation for cancel button## What does this MR do?
Adds a confirm dialog when the user clicks the cancel action in the pipelines table.
## Screenshots
![Screen_Shot_2017-02-24_at_18.21.03](/uploads/563dd61caac1e4b97f8833375d104442/Screen_Shot_2017-02-24_at_18.2...## What does this MR do?
Adds a confirm dialog when the user clicks the cancel action in the pipelines table.
## Screenshots
![Screen_Shot_2017-02-24_at_18.21.03](/uploads/563dd61caac1e4b97f8833375d104442/Screen_Shot_2017-02-24_at_18.21.03.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #284199.0username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8088Convert CI YAML variables keys into strings2019-09-20T00:18:10Zusername-removed-423915Convert CI YAML variables keys into stringsSo that this would be more consistent with the other variables,
which all of them are string based.
Closes #25554So that this would be more consistent with the other variables,
which all of them are string based.
Closes #255548.15Grzegorz BizonGrzegorz Bizonhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9017shows go back link only when history is available2019-09-20T00:16:18Zusername-removed-535087shows go back link only when history is available## What does this MR do?
This MR resolves UX of error page on GitLab regarding 'Go Back' Link
## Are there points in the code the reviewer needs to double check?
Should not need
## Why was this MR needed?
UX improvement
## Screenshots (...## What does this MR do?
This MR resolves UX of error page on GitLab regarding 'Go Back' Link
## Are there points in the code the reviewer needs to double check?
Should not need
## Why was this MR needed?
UX improvement
## Screenshots (if relevant)
![2017-02-08_16.41.57](/uploads/4192323be40c2bad12626f6665028bb2/2017-02-08_16.41.57.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
- [x] All builds are passing
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #275809.1Jacob SchatzJacob Schatzhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8960Skip or retain project while deleting the project:2019-09-20T00:14:05Zusername-removed-423915Skip or retain project while deleting the project:Skip or retain project while deleting the project:
* Skip Ci::Build#update_project_statistics whenever there's no
project (i.e. we're deleting the project!)
* Retain the unscoped_project before deleting the build,
so that we could u...Skip or retain project while deleting the project:
* Skip Ci::Build#update_project_statistics whenever there's no
project (i.e. we're deleting the project!)
* Retain the unscoped_project before deleting the build,
so that we could use the data to delete the artifacts.
Note that carrierwave uses `after_commit` for this,
so we need to retain it in the memory.
Closes #150058.17Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7237Don't execute git hooks if you create branch as part of other change2019-09-20T00:10:40ZKamil TrzcińśkiDon't execute git hooks if you create branch as part of other change## What does this MR do?
Currently, our procedure for adding a commit requires us to execute `CreateBranchService` before file creation.
It's OK, but also we do execute `git hooks` (the `PostReceive` sidekiq job) as part of this proc...## What does this MR do?
Currently, our procedure for adding a commit requires us to execute `CreateBranchService` before file creation.
It's OK, but also we do execute `git hooks` (the `PostReceive` sidekiq job) as part of this process.
However, this hook is execute before the file is actually committed, so the ref is updated.
Secondly, we do execute a `git hooks` after committing file and updating ref.
This results in duplicate `PostReceive` jobs, where the first one is completely invalid.
This change makes the branch creation, something that is intermediate step of bigger process (file creation or update, commit cherry pick or revert) to not execute git hooks.
## Why was this MR needed?
Adds a to `CreateBranchService` an option to disable hooks execution.
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/234398.17Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8301Order only for latest_successful_for2019-09-19T23:38:42Zusername-removed-423915Order only for latest_successful_forFix the issue in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8286#note_20461082
TODO:
* [ ] Add a test which could reproduce it
* [ ] Figure out how to order `latest` or maybe rename it otherwise the name `latest` is co...Fix the issue in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8286#note_20461082
TODO:
* [ ] Add a test which could reproduce it
* [ ] Figure out how to order `latest` or maybe rename it otherwise the name `latest` is confusing
/cc @grzesiek @alfredo1 @balasankarc @ayufan 8.15Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7631Resolve "User-generated permalink IDs collide with GitLab interface"2019-09-19T23:12:07Zusername-removed-636429Resolve "User-generated permalink IDs collide with GitLab interface"## What does this MR do?
Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewh...## What does this MR do?
Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewhere in the GitLab interface. This can cause confusion when, for instance, a selector looks for a merge request tab with `id="pipelines"` and there is a header with the same ID earlier in the DOM.
How this works:
* All header IDs generated with GitLab Flavored Markdown are namespaced with `id="user-content_foo"`
* All anchor links which point to these IDs continue to use the non-namespaced hash `<a href="#foo">...</a>`
* When a page is loaded or when the `hashchange` event is triggered, javascript will automatically search for `#user-content_foo` if `#foo` cannot be found, and scroll to that position instead.
## Before
![2016-11-21-13.00.28](/uploads/e3be2cd6a9142dfd6e64db5462a6aa76/2016-11-21-13.00.28.gif)
## After:
![2016-11-21-13.12.45](/uploads/f7ae3f3a30c91325eaa3665591b6a850/2016-11-21-13.12.45.gif)
![2016-11-21-13.03.00](/uploads/3a6a782c081ecaa05b8781548d794909/2016-11-21-13.03.00.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22781
See also prior attempts to address this issue:
#3908, !2023, !2024
8.15username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8426Replace static JavaScript fixtures for u2f2019-09-19T23:00:47Zusername-removed-636429Replace static JavaScript fixtures for u2f## What does this MR do?
Generates HAML fixtures for frontend u2f tests dynamically.
## Are there points in the code the reviewer needs to double check?
All builds should pass.
## Why was this MR needed?
The fixtures used in `u2f/au...## What does this MR do?
Generates HAML fixtures for frontend u2f tests dynamically.
## Are there points in the code the reviewer needs to double check?
All builds should pass.
## Why was this MR needed?
The fixtures used in `u2f/authenticate_spec.js` and `u2f/register_spec.js` are generated directly from a partial template and include inline `<script>` tags which can cause issues in certain test runners. These currently pass within Teaspoon, but only because of a quirk in the timing of the call to `fixture.load`. This MR changes the way the fixture is rendered, and scrubs out all inline script tags from the generated html.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Related to #247538.16https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7588Fix broken commit metadata loading for large repository trees2019-09-19T22:58:17Zusername-removed-636429Fix broken commit metadata loading for large repository trees## What does this MR do?
Fixes a regression introduced in !7208 in which a call to `ajaxGet()` would fail when loading metadata for large repository trees.
This call produced no errors in the console because it is contained in a so...## What does this MR do?
Fixes a regression introduced in !7208 in which a call to `ajaxGet()` would fail when loading metadata for large repository trees.
This call produced no errors in the console because it is contained in a sort of `eval` block in jQuery. This is an ugly, easily broken method for loading data asynchronously whose problems were exemplified by this issue. I'm opening a separate issue (#24660) to alter this implementation.
## Why was this MR needed?
The failing AJAX call was causing metadata to stop loading, and the `timeago` functionality to stop running due to script failure.
## Screenshots (if relevant)
![Screen_Shot_2016-11-18_at_2.03.13_PM_copy](/uploads/ab0c11d5c405c01d8e45818b3ca96f23/Screen_Shot_2016-11-18_at_2.03.13_PM_copy.png)
## Does this MR meet the acceptance criteria?
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
## What are the relevant issue numbers?
Closes #246528.14username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7139Fix couple of GitHub importing bugs2019-09-19T22:41:34Zusername-removed-506061Fix couple of GitHub importing bugs## What does this MR do?
Fix a bug in GH comment importing and label applying for imported MRs.
## Are there points in the code the reviewer needs to double check?
N/A
## Why was this MR needed?
## Screenshots (if relevant)
...## What does this MR do?
Fix a bug in GH comment importing and label applying for imported MRs.
## Are there points in the code the reviewer needs to double check?
N/A
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
- [ ] ~~Added for this feature/bug~~
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?8.13username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/5814Backups fail occasionally with "tar: ./objects: file changed as we read it" e...2019-09-19T22:04:44Zusername-removed-117638Backups fail occasionally with "tar: ./objects: file changed as we read it" error- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support a...- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
Closes #56138.14Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13751Fix a potential timeout in `Gitlab::Logger.read_latest`2019-08-01T02:59:54ZRobert SpeicherFix a potential timeout in `Gitlab::Logger.read_latest`If this method was called for a file that didn't exist, we attempted to
first `build` it. But if the file wasn't writeable, such as a symlink
pointing to an unmounted filesystem, the method would just hang and
eventually timeout.
Furthe...If this method was called for a file that didn't exist, we attempted to
first `build` it. But if the file wasn't writeable, such as a symlink
pointing to an unmounted filesystem, the method would just hang and
eventually timeout.
Further, this was entirely pointless since we were creating a file and
then shelling out to `tail`, eventually returning an empty Array. Now we
just skip building it and return the empty Array straight away.
## Refactor `Admin::LogsController#show`
We should be defining the list of loggers in the controller, not the
view.10.0Douwe MaanDouwe Maan