GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-09-14T01:01:26Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12486Change the languages chart from chart.js to d3.js2017-09-14T01:01:26ZJose Ivan Vargas LopezChange the languages chart from chart.js to d3.js## What does this MR do?
Refactors the languages chart from the Repository -> Charts, from using Chart.js to d3.js
This is part of an effort to consolidate our graphics libraries from Raphael.js, Chart.js, etc. to d3.js as to reduce ...## What does this MR do?
Refactors the languages chart from the Repository -> Charts, from using Chart.js to d3.js
This is part of an effort to consolidate our graphics libraries from Raphael.js, Chart.js, etc. to d3.js as to reduce our assets footprint
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
I.O.U.
## TODO's
- [ ] Create the relevant issue
- [ ] Create a reusable tooltip compatible with d3
- [ ] Perhaps update the backend to avoid the use of inline javascript
- [ ] Update and/or create tests https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6311Fix "Average 0 commits per day" by preventing integer division.2017-04-05T11:56:09Zusername-removed-716864Fix "Average 0 commits per day" by preventing integer division.With a commit count smaller than the number of days a repository is in existence the current version shows
"Average **0** commits per day" on `<user_name>/<repository_name>/graphs/master/commits`.
This should be changed back to i.e "...With a commit count smaller than the number of days a repository is in existence the current version shows
"Average **0** commits per day" on `<user_name>/<repository_name>/graphs/master/commits`.
This should be changed back to i.e "Average **0.35** commits per day" to be meaningful and even correct.