GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-09-19T22:59:29Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6984Suppress update events on pipeline if already they got scheduled2019-09-19T22:59:29ZKamil TrzcińśkiSuppress update events on pipeline if already they got scheduled## What does this MR do?
Reduces the pressure on Sidekiq by queueing much less pipeline updates.
## Why was this MR needed?
Currently we do queue updates on pipeline when we are processing a pipeline, this is very redundant as we don't ...## What does this MR do?
Reduces the pressure on Sidekiq by queueing much less pipeline updates.
## Why was this MR needed?
Currently we do queue updates on pipeline when we are processing a pipeline, this is very redundant as we don't really need to do this, because we do update pipeline status at the end of process.
The same applies to when we retry a build, we do queue updates on pipeline generated for all builds on next stages. This is completely redundant too.
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
None yet.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11801WIP: Add guidelines for performance testing at scale2018-12-13T21:35:02ZNick ThomasWIP: Add guidelines for performance testing at scale## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #31144Nick ThomasNick Thomashttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14052WIP: Make sure we don't always fetch_ref for merge request diffs2017-10-06T17:49:12Zusername-removed-423915WIP: Make sure we don't always fetch_ref for merge request diffs## What does this MR do?
Make sure we don't always fetch_ref for merge request diffs
## Are there points in the code the reviewer needs to double check?
I am unsure where we should put this test, and the current test segfault on...## What does this MR do?
Make sure we don't always fetch_ref for merge request diffs
## Are there points in the code the reviewer needs to double check?
I am unsure where we should put this test, and the current test segfault on my computer...
## Why was this MR needed?
To speed up diffs creation.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
Closes #3629210.1username-removed-423915username-removed-423915https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14678Show stale instead of merged if the branch is old2017-10-06T13:57:38Zusername-removed-423915Show stale instead of merged if the branch is old## What does this MR do?
Show stale instead of merged if the branch is old
We consider the branch is old when the updated date was
3 months older than the default branch updated date.
## Are there points in the code the reviewe...## What does this MR do?
Show stale instead of merged if the branch is old
We consider the branch is old when the updated date was
3 months older than the default branch updated date.
## Are there points in the code the reviewer needs to double check?
Are people relying on that label?
Maybe we want to use another color for `stale`?
## Why was this MR needed?
By doing so, it would greatly improve the performance
in this page, because it's pretty costly to find if it's
merged or not when the branch is far behind.
We assume that when it's old, it's probably far behind.
The idea was brought up in:
https://gitlab.com/gitlab-org/gitlab-ce/issues/37429#note_42284280
## Screenshots (if relevant)
![Screen_Shot_2017-10-04_at_20.02.34](/uploads/eabb08b1535c5c02b5347bc07c3cef4a/Screen_Shot_2017-10-04_at_20.02.34.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
We're trying to improve `BranchesController#index`, https://gitlab.com/gitlab-org/gitlab-ce/issues/3742910.1username-removed-423915username-removed-423915https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14440Resolve "CDN support for PIWIK analytics platform"2017-09-27T20:50:48ZTim ZallmannResolve "CDN support for PIWIK analytics platform"## What does this MR do?
It makes our Piwik configuration compatible with deploying the piwik.js to a CDN.
There is now the new optional Configuration parameter `piwik_js_cdn_url`, which is only needed if you want to serve the Ja...## What does this MR do?
It makes our Piwik configuration compatible with deploying the piwik.js to a CDN.
There is now the new optional Configuration parameter `piwik_js_cdn_url`, which is only needed if you want to serve the Javascript file from a different location. Based on the following description : https://forum.piwik.org/t/loading-piwik-from-cdn/11565/4
## Are there points in the code the reviewer needs to double check?
Is anything else needed when adding a new configuration?
## Why was this MR needed?
So gitlab.com can even be faster
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #3816810.1Tim ZallmannTim Zallmannhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13857lossless image optimization2017-09-19T18:28:02Zusername-removed-1118608lossless image optimization## What does this MR do?
optimize images
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
https://developers.google.com/speed/pagespeed/insights/?url=https%3...## What does this MR do?
optimize images
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fgitlab.com%2Fusers%2Fsign_in&tab=desktop
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.1username-removed-1118608username-removed-1118608https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13794WIP: Enable caching of schema.rb2017-08-28T10:39:57Zyorickpeterse-stagingWIP: Enable caching of schema.rb## What does this MR do?
This enables the caching of schema information as described in http://iempire.ru/2016/12/13/schema-cache/. This means Rails doesn't have to check the schema when booting up. This in turn means we don't have to...## What does this MR do?
This enables the caching of schema information as described in http://iempire.ru/2016/12/13/schema-cache/. This means Rails doesn't have to check the schema when booting up. This in turn means we don't have to run expensive queries such as:
```sql
SELECT a.attname, format_type(a.atttypid, a.atttypmod), pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod FROM pg_attribute a LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum WHERE a.attrelid = '"milestones"'::regclass AND a.attnum > 0 AND NOT a.attisdropped ORDER BY a.attnum;
```
Such a query can easily take 200 milliseconds on GitLab.com.
Further I observed a reduction of boot timings locally of around 3 seconds, but this may differ per environment.
This was brought to our attention by @stanhu in the `#database` channel so he really deserves the credit for this.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Review
- [ ] Has been reviewed by Backend
- [x] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)9.5yorickpeterse-stagingyorickpeterse-staginghttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13738Use pagination without COUNT for issues/MRs2017-08-24T11:45:49Zyorickpeterse-stagingUse pagination without COUNT for issues/MRs## What does this MR do?
This changes the pagination system of MR and issue index pages so they don't use COUNT(*) queries, at the cost of not displaying page numbers.
This saves around 30 milliseconds per page on GitLab.com. Since the ...## What does this MR do?
This changes the pagination system of MR and issue index pages so they don't use COUNT(*) queries, at the cost of not displaying page numbers.
This saves around 30 milliseconds per page on GitLab.com. Since the page numbers aren't that useful this is an easy performance win.
## Screenshots (if relevant)
![Screenshot_from_2017-08-22_14-13-53](/uploads/08bdfa9bdad9ade2c8180955b81fe2a7/Screenshot_from_2017-08-22_14-13-53.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [x] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
* https://gitlab.com/gitlab-org/gitlab-ce/issues/27376
* https://gitlab.com/gitlab-org/gitlab-ce/issues/3607710.0yorickpeterse-stagingyorickpeterse-staginghttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13742Disable page numbers for all project dashboards2017-08-24T11:45:41Zyorickpeterse-stagingDisable page numbers for all project dashboards## What does this MR do?
This disables page numbers for `Dashboard::ProjectsController#index` and `Dashboard::ProjectsController#starred`. This ensures these pages use the same pagination system as `Explore::ProjectsController` and th...## What does this MR do?
This disables page numbers for `Dashboard::ProjectsController#index` and `Dashboard::ProjectsController#starred`. This ensures these pages use the same pagination system as `Explore::ProjectsController` and that these pages don't spend time running expensive COUNT queries.
## Screenshots
Before:
![before](/uploads/3b07d86be9f6f0ddfc699ad047fbbf9f/before.png)
After:
First page:
![after1](/uploads/8e44ddaec5a50f817c81f7a36198ef37/after1.png)
Second page:
![after2](/uploads/a6d2ed3d02fead5b89558cb15e1630bf/after2.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Backend
- [x] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/27376
cc @sarrahvesselov10.0yorickpeterse-stagingyorickpeterse-staginghttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13345Don't SELECT * just to check if a project exists2017-08-09T12:43:10Zyorickpeterse-stagingDon't SELECT * just to check if a project exists## What does this MR do?
This adds a small optimisation to `ProjectUrlConstrainer` so we don't perform a `SELECT *` when we only care about whether or not a row is returned.
## Does this MR meet the acceptance criteria?
- [x] [Changel...## What does this MR do?
This adds a small optimisation to `ProjectUrlConstrainer` so we don't perform a `SELECT *` when we only care about whether or not a row is returned.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Review
- [ ] Has been reviewed by Backend
- [x] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)9.5yorickpeterse-stagingyorickpeterse-staginghttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/2829Don't use union query, it's very slow in MySQL.2017-08-08T03:49:19Zusername-removed-198553huacnlee@gmail.comDon't use union query, it's very slow in MySQL.The new changes is from 1 complex SQL to N simple SQL.
In our complex data environment, the Users#show page response time reduce from 5s to 500ms.
![屏幕快照_2016-02-16_18.19.06](/uploads/e968f49ed70f26f36166476e42668444/屏幕快照_2016-02-1...The new changes is from 1 complex SQL to N simple SQL.
In our complex data environment, the Users#show page response time reduce from 5s to 500ms.
![屏幕快照_2016-02-16_18.19.06](/uploads/e968f49ed70f26f36166476e42668444/屏幕快照_2016-02-16_18.19.06.png)
![屏幕快照_2016-02-16_18.10.34](/uploads/3bf5b0f00605e142f9bfd8f8a609745e/屏幕快照_2016-02-16_18.10.34.png)
![屏幕快照_2016-02-16_18.13.02](/uploads/a9b7381e2df1016d6d0fb8fa134a2ef6/屏幕快照_2016-02-16_18.13.02.png)
![屏幕快照_2016-02-16_18.16.31](/uploads/e3c5072758b6531c63292aa21a9b7c20/屏幕快照_2016-02-16_18.16.31.png)
https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10327WIP: Resolve "Projects::PipelinesController#index.json is slow due to SQL"2017-07-26T12:54:02Zusername-removed-423915WIP: Resolve "Projects::PipelinesController#index.json is slow due to SQL"## What does this MR do?
Eliminating all the N+1 queries when using `PipelineSerializer`
## Are there points in the code the reviewer needs to double check?
Hopefully the behaviour would stay the same.
## Why was this MR need...## What does this MR do?
Eliminating all the N+1 queries when using `PipelineSerializer`
## Are there points in the code the reviewer needs to double check?
Hopefully the behaviour would stay the same.
## Why was this MR needed?
Speed up `Projects::PipelinesController#index.json` so that we could use this to update pipeline table in realtime (i.e. requesting this so much more frequently)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [ ] Added for this feature/bug
## What are the relevant issue numbers?
Closes #32766Backlogusername-removed-423915username-removed-423915https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12657Bump GITLAB_SHELL_VERSION to take advantage of faster loading of scripts2017-07-05T15:27:49ZStan HuBump GITLAB_SHELL_VERSION to take advantage of faster loading of scriptsTo take advantage of https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/141To take advantage of https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/1419.4https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10110Improve resiliency of build picking2017-07-04T14:16:21ZKamil TrzcińśkiImprove resiliency of build picking## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?9.3https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12097Address Performance Issues for Large Diff MRs2017-06-28T18:23:03Zusername-removed-408230Address Performance Issues for Large Diff MRs### Known causes of lag at scale
- Injecting add diff note into the DOM (Fixed: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12103)
- transform/transition styles of add-diff-note (Fixed: https://gitlab.com/gitlab-org/gitlab...### Known causes of lag at scale
- Injecting add diff note into the DOM (Fixed: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12103)
- transform/transition styles of add-diff-note (Fixed: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12103)
- setSidebarHeight on scroll
- Fixed position elements
- Tooltips being injected into the DOM
- Autosize JS on text input
- initTimeagoTimeout running every second
- large lag on initial diff load
Closes #304049.4https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11641Migrate old traces and artifacts2017-06-27T10:05:41ZKamil TrzcińśkiMigrate old traces and artifacts## What does this MR do?
It does migrate artifacts to the single unique path and stores that information in the database.
Migrates the data to remove the need of having hotfix: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2...## What does this MR do?
It does migrate artifacts to the single unique path and stores that information in the database.
Migrates the data to remove the need of having hotfix: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2224.
It makes it possible to remove artifacts and traces with:
```bash
rm -rf artifacts/year_month/project_id/
rm -rf builds/year_month/project_id/
```
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/320369.3Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11598WIP: Background migrations PoC2017-06-27T08:16:57ZGrzegorz BizonWIP: Background migrations PoC## What does this MR do?
This is a PoC for background migrations with per-resource migrations support.
**This MR is a Proof of Concept, is not a production-ready code.**
## What are the relevant issue numbers?
See #32146## What does this MR do?
This is a PoC for background migrations with per-resource migrations support.
**This MR is a Proof of Concept, is not a production-ready code.**
## What are the relevant issue numbers?
See #32146https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12428Skip loading pipelines when loading async MR diffs2017-06-26T17:03:43Zusername-removed-443319Skip loading pipelines when loading async MR diffsI noticed this when looking at http://profiler.gitlap.com/20170620/6f56f201-0625-4893-b599-7bbe219a5542.html.gz - I'm pretty sure we don't need the pipelines on this action? And loading them can be really expensive.
If we do, please tel...I noticed this when looking at http://profiler.gitlap.com/20170620/6f56f201-0625-4893-b599-7bbe219a5542.html.gz - I'm pretty sure we don't need the pipelines on this action? And loading them can be really expensive.
If we do, please tell me, or maybe the pipelines will tell us.
If we don't, maybe we should include this in a 9.3 patch?9.4Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12014Fix GitHub importer performance on branch existence check2017-06-21T00:43:50ZJames LopezFix GitHub importer performance on branch existence checkFixes https://gitlab.com/gitlab-org/gitlab-ce/issues/33259Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/332599.4username-removed-283999douglas@gitlab.comusername-removed-283999douglas@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8486WIP: Add IPython notebook preview2017-06-20T16:39:12Zusername-removed-884169WIP: Add IPython notebook preview## What does this MR do?
Adds support for previewing IPython notebooks using [notebookjs](https://github.com/jsvine/notebookjs) library. IPython notebook is detected using extension `.ipynb`. If such file is opened in repository the not...## What does this MR do?
Adds support for previewing IPython notebooks using [notebookjs](https://github.com/jsvine/notebookjs) library. IPython notebook is detected using extension `.ipynb`. If such file is opened in repository the notebook preview is rendered instead of plain JSON. You can switch back and forth between the rendered preview and the source.
## Why was this MR needed?
To address #2508
## Screenshots (if relevant)
*Valid notebook preview*
![valid-notebook](/uploads/a1bc0c3bc4e4d39f8d6e033869e5d0ba/valid-notebook.gif)
*Invalid notebook*
![invalid-notebook](/uploads/b08b4d19e913dccf9f7177c40916e9c7/invalid-notebook.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2508username-removed-884169username-removed-884169