GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-10-25T00:07:30Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14742Cleanup data-page attribute after each Karma test2017-10-25T00:07:30Zusername-removed-892863contact@ericeastwood.comCleanup data-page attribute after each Karma test## What does this MR do?
- Cleanup `data-page` attribute after each Karma test to avoid leaking into the next test
## Are there points in the code the reviewer needs to double check?
- Are we okay with moving to consistent `.attr('d...## What does this MR do?
- Cleanup `data-page` attribute after each Karma test to avoid leaking into the next test
## Are there points in the code the reviewer needs to double check?
- Are we okay with moving to consistent `.attr('data-page', ...` for easier Ctrl+F?
## Why was this MR needed?
See https://gitlab.com/gitlab-org/gitlab-ce/issues/38871
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38871https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14690Move cycle analytics banner into a vue file2017-10-24T23:58:00ZFilipa Lacerdafilipa@gitlab.comMove cycle analytics banner into a vue file## What does this MR do?
- Moves last cycle analytics bannerinto a vue files
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](...## What does this MR do?
- Moves last cycle analytics bannerinto a vue files
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3437110.2Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14653Replaces `tag: true` into `:tag` in the specs2017-10-24T23:58:08Zusername-removed-331646intrip@gmail.comReplaces `tag: true` into `:tag` in the specs## What does this MR do?
- Replaces all the explicit include metadata syntax in the specs `tag:true` into the implicit one `:tag`.
- Added a cop to prevent future errors and handle autocorrection.
## Are there points in the code t...## What does this MR do?
- Replaces all the explicit include metadata syntax in the specs `tag:true` into the implicit one `:tag`.
- Added a cop to prevent future errors and handle autocorrection.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #3755210.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14611WIP: Add rubocop-thread_safety checks2017-10-07T06:04:32ZStan HuWIP: Add rubocop-thread_safety checksThis is important not only to prevent Sidekiq issues, but also to prepare support for a multithreaded app server.
First step to addressing #3592This is important not only to prevent Sidekiq issues, but also to prepare support for a multithreaded app server.
First step to addressing #3592https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13486Remove IIFE from various JS files2017-08-11T04:41:22Zusername-removed-636429Remove IIFE from various JS filesA port of ~"Community Contribution" !12640 from @asumaran meant to work towards resolving gitlab-org/gitlab-ce#29219
This needs to be rebased and fixed up before it can be merged, but I don't want to let this work go to waste.A port of ~"Community Contribution" !12640 from @asumaran meant to work towards resolving gitlab-org/gitlab-ce#29219
This needs to be rebased and fixed up before it can be merged, but I don't want to let this work go to waste.username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12172WIP: Fail tests for non-mocked Ajax requests2018-12-12T07:31:30ZWinnie HellmannWIP: Fail tests for non-mocked Ajax requests## What does this MR do?
Fail tests if Ajax requests are not mocked.
## What are the relevant issue numbers?
fixes #33715## What does this MR do?
Fail tests if Ajax requests are not mocked.
## What are the relevant issue numbers?
fixes #33715Winnie HellmannWinnie Hellmannhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10435Enable Bullet in CI to detect N+1 queries2017-07-24T18:57:35ZRobert SpeicherEnable Bullet in CI to detect N+1 queriesCloses https://gitlab.com/gitlab-org/gitlab-ce/issues/30129Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/3012910.0Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9754Move KaTeX javascript bundle to webpack config2017-03-07T08:57:19Zusername-removed-636429Move KaTeX javascript bundle to webpack config## What does this MR do?
Moves `katex.js` compilation from Sprockets to webpack.
## Are there points in the code the reviewer needs to double check?
KaTeX within GitLab-flavored markdown should still render correctly.
## Why was this...## What does this MR do?
Moves `katex.js` compilation from Sprockets to webpack.
## Are there points in the code the reviewer needs to double check?
KaTeX within GitLab-flavored markdown should still render correctly.
## Why was this MR needed?
Attempting to move all javascript compilation away from Sprockets so that several Ruby gems can be removed.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#27486https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8835use url helpers to construct URLs for push_message2017-03-20T04:35:52Zusername-removed-912260use url helpers to construct URLs for push_message## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#27149username-removed-912260username-removed-912260