GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-05-06T23:01:31Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14759Resolve "Allow admin to restrict min SSH key length and technology"2019-05-06T23:01:31ZVictor WuResolve "Allow admin to restrict min SSH key length and technology"## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](htt...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #17849
James RamsayJames Ramsayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14684Display "Groups with access" to <project> for all project members2017-10-06T19:59:38Zusername-removed-1394376Display "Groups with access" to <project> for all project members## What does this MR do?
Gives all project members the visibility to see which groups have access to the specific project.
## Are there points in the code the reviewer needs to double check?
N/A
## Why was this MR needed?
...## What does this MR do?
Gives all project members the visibility to see which groups have access to the specific project.
## Are there points in the code the reviewer needs to double check?
N/A
## Why was this MR needed?
As a non-admin on a project, I am unable to see what groups have access to the project. This makes it incredibly confusing when changes are made by what looks like non project members. And it is also confusing when I can't even see what access I have on a specific project.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#38770username-removed-419655username-removed-419655https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13852Using correct column for sorting users by Recent Sign-in2017-09-08T11:07:32Zusername-removed-804460Using correct column for sorting users by Recent Sign-in## What does this MR do?
Uses `current_sign_in_at` instead of `last_sign_in_at` for sorting users by "Recent Sign-in". According to https://github.com/plataformatec/devise/blob/master/lib/devise/models/trackable.rb, `last_sign_in_at` po...## What does this MR do?
Uses `current_sign_in_at` instead of `last_sign_in_at` for sorting users by "Recent Sign-in". According to https://github.com/plataformatec/devise/blob/master/lib/devise/models/trackable.rb, `last_sign_in_at` points to the previous time the user logged in. The correct column to use here is `current_sign_in_at` as this gets updated every time a user logs in and is not set to `nil` when the user logs out.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed
To sort the users by "Recent Sign-in" correctly
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2646810.1username-removed-804460username-removed-804460https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12033update count badge when deleting a member on a group2017-08-29T05:53:29Zusername-removed-42381update count badge when deleting a member on a group## What does this MR do?
Decrease the member count on the header panel when deleting a member on a group.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relev...## What does this MR do?
Decrease the member count on the header panel when deleting a member on a group.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![preview-badge-member](/uploads/97f42f88a9fbc7b2d8b6d95b909777cc/preview-badge-member.gif)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#31720username-removed-42381username-removed-42381