GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2018-12-14T00:03:01Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14390Use gitlab-workhorse 3.1.02018-12-14T00:03:01ZJacob Vosmaer (GitLab)Use gitlab-workhorse 3.1.0## What does this MR do?
Update the required version of gitlab-workhorse to 3.1.0.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
To ship recent changes in gitlab-workhorse in 10.1.
##...## What does this MR do?
Update the required version of gitlab-workhorse to 3.1.0.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
To ship recent changes in gitlab-workhorse in 10.1.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11575Notify workhorse about etag changes2017-07-25T17:32:01ZKamil TrzcińśkiNotify workhorse about etag changes## What does this MR do?
Makes E-tag caching to notify about resource changes.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the accep...## What does this MR do?
Makes E-tag caching to notify about resource changes.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10357Make location of gitlab_workhorse_secret configurable2017-04-24T11:03:00Zusername-removed-522587Make location of gitlab_workhorse_secret configurable## What does this MR do?
Replaces hard-coded location of `workhorse_secret_file` with a configurable option, in the same way as it’s already done for `gitlab_shell_secret`. The default value remains the same as before.
## Are there poi...## What does this MR do?
Replaces hard-coded location of `workhorse_secret_file` with a configurable option, in the same way as it’s already done for `gitlab_shell_secret`. The default value remains the same as before.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
’Cause hard-coding location of configuration files is _very_ bad practice, as well as storing such files in the root of application. It makes reasonable deployments (with separated program and configuration/state) harder.
## Screenshots (if relevant)
No.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?9.2username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8440Gitaly feature flag2017-01-24T18:21:33Zusername-removed-506061Gitaly feature flag## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
- [ ] ~~Added for this feature/bug~~
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitaly/issues/448.16Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8197Use gitlab-workhorse 1.2.12016-12-21T12:48:59ZJacob Vosmaer (GitLab)Use gitlab-workhorse 1.2.1More prometheus metrics, other small fixes.More prometheus metrics, other small fixes.8.15username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7991Use workhorse 1.1.1 in 8-14-stable2016-12-08T14:08:50ZJacob Vosmaer (GitLab)Use workhorse 1.1.1 in 8-14-stableUse gitlab-workhorse 1.1.1. Changes CI API rate limiting behavior.Use gitlab-workhorse 1.1.1. Changes CI API rate limiting behavior.username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7990Use gitlab-workhorse 1.1.12016-12-12T14:42:21ZJacob Vosmaer (GitLab)Use gitlab-workhorse 1.1.1Change CI API rate limiting behavior.
Will make a separate MR for 8-14-stable because that version lacks the workhorse install rake task.Change CI API rate limiting behavior.
Will make a separate MR for 8-14-stable because that version lacks the workhorse install rake task.8.15username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7879Don't allow to specify a repo or version when installing Workhorse2016-12-02T05:01:54Zusername-removed-128633Don't allow to specify a repo or version when installing WorkhorseAs pointed out by @rspeicher in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6574#note_19266284, the `GITLAB_WORKHORSE_VERSION` is not necessary, the task should always use the required GitLab Workhorse version.
With the same ...As pointed out by @rspeicher in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6574#note_19266284, the `GITLAB_WORKHORSE_VERSION` is not necessary, the task should always use the required GitLab Workhorse version.
With the same logic, I've removed the option to specify a different repository (with the `GITLAB_WORKHORSE_REPO` env variable), again, the task should use the canonical one. The task is not meant to be used for development/debugging purpose.
I've also updated the "patch version upgrade" doc since I did forget to update it in !6574. :)
/cc @jacobvosmaer-gitlab8.15Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7332Use the Gitlab Workhorse HTTP header in the admin dashboard2016-11-07T17:50:59Zusername-removed-128633Use the Gitlab Workhorse HTTP header in the admin dashboard_Originally opened at !6115 by @Stretch96._
- - -
Fixes issue #21664 where the GitLab Workhorse version displayed within the Admin Area was not correct for installations from source._Originally opened at !6115 by @Stretch96._
- - -
Fixes issue #21664 where the GitLab Workhorse version displayed within the Admin Area was not correct for installations from source.8.14username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7289Update GitLab Workhorse to v1.0.02016-11-04T20:25:23ZNick ThomasUpdate GitLab Workhorse to v1.0.0## What does this MR do?
Update GitLab Workhorse to v1.0.0, improving error handling
## Are there points in the code the reviewer needs to double check?
This is an update to v1.0.0 - which does not signify any breaking changes, but is...## What does this MR do?
Update GitLab Workhorse to v1.0.0, improving error handling
## Are there points in the code the reviewer needs to double check?
This is an update to v1.0.0 - which does not signify any breaking changes, but is merely in accordance with http://semver.org/#how-do-i-know-when-to-release-100
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?8.14username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6891Use gitlab-workhorse 0.8.52016-10-14T16:22:30ZNick ThomasUse gitlab-workhorse 0.8.5## What does this MR do?
Bump gitlab-workhorse to 0.8.5
## Why was this MR needed?
Fixes to the diff and patch endpoints. See https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/68#note_16919390
/cc @jacobvosmaer-gitlab## What does this MR do?
Bump gitlab-workhorse to 0.8.5
## Why was this MR needed?
Fixes to the diff and patch endpoints. See https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/68#note_16919390
/cc @jacobvosmaer-gitlab8.13username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6790Add gitlab-workhorse to rake gitlab:check2017-03-16T14:09:31Zusername-removed-770129Add gitlab-workhorse to rake gitlab:check## What does this MR do?
It adds a check for the gitlab-workhorse version in the rake task "rake gitlab:check"
## Are there points in the code the reviewer needs to double check?
I am assuming the needed version for gitlab-workhorse is ...## What does this MR do?
It adds a check for the gitlab-workhorse version in the rake task "rake gitlab:check"
## Are there points in the code the reviewer needs to double check?
I am assuming the needed version for gitlab-workhorse is 0.8.4.
## Why was this MR needed?
dding a check for gitlab-shell version would be helpful to debian packaging (as all other dependencies are checked using Gemfile this get missed).
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6712Use gitlab-workhorse 0.8.42016-10-13T15:38:48ZJacob Vosmaer (GitLab)Use gitlab-workhorse 0.8.4Fixes Go 1.5 compatibility broken in 0.8.3.Fixes Go 1.5 compatibility broken in 0.8.3.8.13username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6574New `gitlab:workhorse:install` rake task2017-03-23T12:02:46Zusername-removed-128633New `gitlab:workhorse:install` rake task## What does this MR do?
This adds a new `gitlab:workhorse:install` Rake task similar to the `gitlab:shell:install` task.
## Are there points in the code the reviewer needs to double check?
- Do we need the check for `gmake`? I'...## What does this MR do?
This adds a new `gitlab:workhorse:install` Rake task similar to the `gitlab:shell:install` task.
## Are there points in the code the reviewer needs to double check?
- Do we need the check for `gmake`? I've added it since the documentation mentioned that "If you are not using Linux you may have to run `gmake` instead of `make` below"...
- The specs are little complex, but at least it is testing the task so I think it's useful! I'm open to suggestion on how to improve them, though.
- Do I need to update any other files regarding the new `gitlab_workhorse.path` option?
## Why was this MR needed?
Because with this we can remove the "Ensure the gitlab-workhorse version in Install gitlab-workhorse matches the required version." step from https://gitlab.com/gitlab-org/release-tools/blob/master/doc/release-candidates.md#creating-rc1! MR is ready: gitlab-org/release-tools!57
Closes #227198.15Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6115Use Gitlab Workhorse http header to determine version2016-11-07T14:54:19Zusername-removed-536426Use Gitlab Workhorse http header to determine versionFixes issue #21664 where the GitLab Workhorse version displayed within the Admin Area was not correct for installations from source.Fixes issue #21664 where the GitLab Workhorse version displayed within the Admin Area was not correct for installations from source.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/5867Replace Rack::Multipart with gitlab-workhorse based system2016-12-28T17:22:02ZJacob Vosmaer (GitLab)Replace Rack::Multipart with gitlab-workhorse based systemLet gitlab-workhorse save Mime multipart uploads to tempfiles. This
effectively replaces Rack::Multipart.
Rack::Multipart tends to leave behind files in /tmp and uses Unicorn
processes to copy files around. This new implementation u...Let gitlab-workhorse save Mime multipart uploads to tempfiles. This
effectively replaces Rack::Multipart.
Rack::Multipart tends to leave behind files in /tmp and uses Unicorn
processes to copy files around. This new implementation uses
gitlab-workhorse for the copying work and cleanup, and only leaves it
to gitlab-ce to move the uploaded file to its final storage directory.
8.15username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/5367Workhorse now sends raw commit diffs and patches2017-01-26T10:20:42ZZeger-Jan van de Wegzegerjan@gitlab.comWorkhorse now sends raw commit diffs and patchesFixes #18466
## Does this MR meet the acceptance criteria?
- [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [X] Added for this feature/bug
- [X] All builds are passing
-...Fixes #18466
## Does this MR meet the acceptance criteria?
- [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [X] Added for this feature/bug
- [X] All builds are passing
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)Zeger-Jan van de Wegzegerjan@gitlab.comZeger-Jan van de Wegzegerjan@gitlab.com