GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-10-24T23:58:08Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14653Replaces `tag: true` into `:tag` in the specs2017-10-24T23:58:08Zusername-removed-331646intrip@gmail.comReplaces `tag: true` into `:tag` in the specs## What does this MR do?
- Replaces all the explicit include metadata syntax in the specs `tag:true` into the implicit one `:tag`.
- Added a cop to prevent future errors and handle autocorrection.
## Are there points in the code t...## What does this MR do?
- Replaces all the explicit include metadata syntax in the specs `tag:true` into the implicit one `:tag`.
- Added a cop to prevent future errors and handle autocorrection.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #3755210.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14337Use gitlab-styles which provides shared RuboCop config and cops2017-09-19T16:27:21Zusername-removed-128633Use gitlab-styles which provides shared RuboCop config and cops## What does this MR do?
This uses https://gitlab.com/gitlab-org/gitlab-styles which includes a shared RuboCop config and custom cops that can be reused by multiple projects.
Will allow to solve #37711.
## Are there points in the code...## What does this MR do?
This uses https://gitlab.com/gitlab-org/gitlab-styles which includes a shared RuboCop config and custom cops that can be reused by multiple projects.
Will allow to solve #37711.
## Are there points in the code the reviewer needs to double check?
We can still define custom cops as before, and regularly migrate them to the gem if this is more practical (or for testing/debugging purpose).
## Why was this MR needed?
So that we can avoid duplicating our RuboCop config and custop cops.
## Does this MR meet the acceptance criteria?
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- Review
- [ ] Has been reviewed by Backend
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14232Decrease Cyclomatic Complexity threshold to 122019-09-20T01:43:24Zusername-removed-864731maks.rydkin@gmail.comDecrease Cyclomatic Complexity threshold to 12## What does this MR do?
- refactor `app/services/merge_requests/update_service.rb:24:5`
- decrease Cyclomatic Complexity threshold to 12
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
...## What does this MR do?
- refactor `app/services/merge_requests/update_service.rb:24:5`
- decrease Cyclomatic Complexity threshold to 12
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
It's fifth step for #31362
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#31362
/cc @rymai @markglenfletcher @grzesiek @blackst0ne @rspeicher
Possible labels: ~"Community Contribution" ~backstage ~Edge ~"static analysis"username-removed-864731maks.rydkin@gmail.comusername-removed-864731maks.rydkin@gmail.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14231Decrease Perceived Complexity threshold to 142019-09-20T01:43:07Zusername-removed-864731maks.rydkin@gmail.comDecrease Perceived Complexity threshold to 14## What does this MR do?
- refactor `app/helpers/projects_helper.rb:27:3`
- decrease Perceived Complexity threshold to 14
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
It's third step ...## What does this MR do?
- refactor `app/helpers/projects_helper.rb:27:3`
- decrease Perceived Complexity threshold to 14
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
It's third step for #31358
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#31358
/cc @rymai @markglenfletcher @grzesiek @blackst0ne @rspeicher
Possible labels: ~"Community Contribution" ~backstage ~Edge ~"static analysis"username-removed-864731maks.rydkin@gmail.comusername-removed-864731maks.rydkin@gmail.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13969Decrease ABC threshold to 55.242019-09-20T00:24:37Zusername-removed-864731maks.rydkin@gmail.comDecrease ABC threshold to 55.24## What does this MR do?
- Refactor `lib/github/import.rb:167:5` with extracting method
- Decrease ABC threshold to 55.24
## Are there points in the code the reviewer needs to double check?
- :warning: We can decrease threshold...## What does this MR do?
- Refactor `lib/github/import.rb:167:5` with extracting method
- Decrease ABC threshold to 55.24
## Are there points in the code the reviewer needs to double check?
- :warning: We can decrease threshold to 55.24 only after merging !13778 (or another one, decreasing ABC for `app/controllers/autocomplete_controller.rb:6:3`) :warning:
## Why was this MR needed?
It's fourth step for #28202
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#28202
/cc @rymai @markglenfletcher @grzesiek @rspeicher @blackst0ne
Possible labels: ~"Community Contribution" ~backstage ~Edge ~"static analysis"username-removed-864731maks.rydkin@gmail.comusername-removed-864731maks.rydkin@gmail.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13610WIP: Enable GitlabSecurity/JsonSerialization cop2017-09-06T18:27:15ZRobert SpeicherWIP: Enable GitlabSecurity/JsonSerialization copPicking up where https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10217 left off.
NOTE: Doesn't actually add the cop until https://gitlab.com/gitlab-org/rubocop-gitlab-security/merge_requests/6 is merged and the version is bumped.Picking up where https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10217 left off.
NOTE: Doesn't actually add the cop until https://gitlab.com/gitlab-org/rubocop-gitlab-security/merge_requests/6 is merged and the version is bumped.Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12800Add cop to make sure we don't use ivar in a module2017-12-18T21:30:23Zusername-removed-423915Add cop to make sure we don't use ivar in a moduleTo see the rationale behind this, please check: https://gitlab.com/gitlab-org/gitlab-ce/blob/no-ivar-in-modules/doc/development/module_with_instance_variables.md
## What does this MR do?
Add a cop to make sure we don't use instance...To see the rationale behind this, please check: https://gitlab.com/gitlab-org/gitlab-ce/blob/no-ivar-in-modules/doc/development/module_with_instance_variables.md
## What does this MR do?
Add a cop to make sure we don't use instance variables in a module.
## Are there points in the code the reviewer needs to double check?
Hopefully some moving around doesn't break anything. We'll disable this cop for some legacy modules because it's very hard to decouple them at the moment.
## Why was this MR needed?
Using instance variables in a module is a bad smell, because it's very hard to track where they're coming from, and they're also very order sensitive.
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] Added for this feature/bug
## What are the relevant issue numbers?10.2username-removed-423915username-removed-423915