GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-10-24T23:58:00Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14738Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace2017-10-24T23:58:00ZFilipa Lacerdafilipa@gitlab.comRemove AjaxLoadingSpinner and CreateLabelDropdown from global namespace## What does this MR do?
Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace
## Does this MR meet the acceptance criteria?
- Review
- [x] Has been reviewed by Frontend
- [x] Conform by the [merge request performan...## What does this MR do?
Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace
## Does this MR meet the acceptance criteria?
- Review
- [x] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3886010.2username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14737WIP: Try to discard data we don't need immediately when importing2017-10-06T18:55:25Zusername-removed-423915WIP: Try to discard data we don't need immediately when importing## What does this MR do?
Try to discard data we don't need immediately when importing
## Are there points in the code the reviewer needs to double check?
I'll try to check if this could reduce memory footprint
## Why was this MR need...## What does this MR do?
Try to discard data we don't need immediately when importing
## Are there points in the code the reviewer needs to double check?
I'll try to check if this could reduce memory footprint
## Why was this MR needed?
To try use less memory
## Does this MR meet the acceptance criteria?
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
Closes #3887310.2username-removed-423915username-removed-423915https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14735Removes CommitsList from global namespace2017-10-24T23:58:06ZFilipa Lacerdafilipa@gitlab.comRemoves CommitsList from global namespace## What does this MR do?
Removes CommitsList from global namespace
Fixes some eslint problems
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance g...## What does this MR do?
Removes CommitsList from global namespace
Fixes some eslint problems
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3886910.2Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14690Move cycle analytics banner into a vue file2017-10-24T23:58:00ZFilipa Lacerdafilipa@gitlab.comMove cycle analytics banner into a vue file## What does this MR do?
- Moves last cycle analytics bannerinto a vue files
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](...## What does this MR do?
- Moves last cycle analytics bannerinto a vue files
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3437110.2Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13935WIP: Import/Export development documentation and admin rake task2017-10-06T13:13:44ZJames LopezWIP: Import/Export development documentation and admin rake taskFixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36055
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/32058
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentati...Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36055
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/32058
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.2James LopezJames Lopezhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13893WIP: Expose per-project pipeline ID ($CI_PIPELINE_IID)2017-09-26T13:46:17ZShinya MaedaWIP: Expose per-project pipeline ID ($CI_PIPELINE_IID)## What does this MR do?
This MR creates new column `iid` on `ci_pipelines` and expose it as `$CI_PIPELINE_IID`.
This `iid` is per-project basis.
## Are there points in the code the reviewer needs to double check?
Does this migration ...## What does this MR do?
This MR creates new column `iid` on `ci_pipelines` and expose it as `$CI_PIPELINE_IID`.
This `iid` is per-project basis.
## Are there points in the code the reviewer needs to double check?
Does this migration work on production(GitLab.com)?
## Why was this MR needed?
Originally demanded at https://gitlab.com/gitlab-org/gitlab-ce/issues/3691. It got about 50 upvotes.
## Screenshots (if relevant)
N/A
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close https://gitlab.com/gitlab-org/gitlab-ce/issues/3691
/cc @ayufan @bikebilly @grzesiek @godfat10.2Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12838Use admin_build for erase (Forbid Developer to erase job)2017-09-26T13:46:30ZShinya MaedaUse admin_build for erase (Forbid Developer to erase job)## What does this MR do?
This MR uses `admin_build` for `JobsController#erase`. This is for preventing developers to erase builds.
Old MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11538.
## Are there points in the code...## What does this MR do?
This MR uses `admin_build` for `JobsController#erase`. This is for preventing developers to erase builds.
Old MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11538.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
This is required at #31771
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Close #3177110.2Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/12800Add cop to make sure we don't use ivar in a module2017-12-18T21:30:23Zusername-removed-423915Add cop to make sure we don't use ivar in a moduleTo see the rationale behind this, please check: https://gitlab.com/gitlab-org/gitlab-ce/blob/no-ivar-in-modules/doc/development/module_with_instance_variables.md
## What does this MR do?
Add a cop to make sure we don't use instance...To see the rationale behind this, please check: https://gitlab.com/gitlab-org/gitlab-ce/blob/no-ivar-in-modules/doc/development/module_with_instance_variables.md
## What does this MR do?
Add a cop to make sure we don't use instance variables in a module.
## Are there points in the code the reviewer needs to double check?
Hopefully some moving around doesn't break anything. We'll disable this cop for some legacy modules because it's very hard to decouple them at the moment.
## Why was this MR needed?
Using instance variables in a module is a bad smell, because it's very hard to track where they're coming from, and they're also very order sensitive.
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] Added for this feature/bug
## What are the relevant issue numbers?10.2username-removed-423915username-removed-423915https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9646WIP: Split Ci:Runner to 2 STI models2017-10-08T17:54:53Zusername-removed-81730WIP: Split Ci:Runner to 2 STI models## What does this MR do?
Split the `Ci::Runner` model into 2 STI models `Ci::InstanceRunner` and `Ci::ProjectRunner`, while removing the boolean flag attribute `is_shared`.
- Shared runners are now instance runners
- Specific runn...## What does this MR do?
Split the `Ci::Runner` model into 2 STI models `Ci::InstanceRunner` and `Ci::ProjectRunner`, while removing the boolean flag attribute `is_shared`.
- Shared runners are now instance runners
- Specific runners are now project runners
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
This is groundwork for the implementation of group shared runners https://gitlab.com/gitlab-org/gitlab-ce/issues/10244.
According to the discussion in https://gitlab.com/gitlab-org/gitlab-ce/issues/10244#note_24927551 this solution was the requested way to implement the runners.
The development of this MR is sponsored by @siemens (/cc @bufferoverflow).
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/1024410.2username-removed-81730username-removed-81730