GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-09-20T03:04:26Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6842Guests can read builds if those are public2019-09-20T03:04:26ZZeger-Jan van de Wegzegerjan@gitlab.comGuests can read builds if those are publicGuests were not able to read builds/pipelines but we claimed in [the docs](https://gitlab.com/help/user/permissions.md) this was possible.
However, the build details will remain hidden for guestsGuests were not able to read builds/pipelines but we claimed in [the docs](https://gitlab.com/help/user/permissions.md) this was possible.
However, the build details will remain hidden for guests8.15username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8088Convert CI YAML variables keys into strings2019-09-20T00:18:10Zusername-removed-423915Convert CI YAML variables keys into stringsSo that this would be more consistent with the other variables,
which all of them are string based.
Closes #25554So that this would be more consistent with the other variables,
which all of them are string based.
Closes #255548.15Grzegorz BizonGrzegorz Bizonhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8234Rename projects with reserved path names2019-09-19T23:43:27Zusername-removed-444Rename projects with reserved path names## What does this MR do?
It renames projects with reserved names by adding digit to the end (starting with 0)
## Are there points in the code the reviewer needs to double check?
migration
## Why was this MR needed?
To prevent 404 on...## What does this MR do?
It renames projects with reserved names by adding digit to the end (starting with 0)
## Are there points in the code the reviewer needs to double check?
migration
## Why was this MR needed?
To prevent 404 on projects that were created before validation & reserved names introduced.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/25917, https://gitlab.com/gitlab-org/gitlab-ce/issues/258938.15username-removed-444username-removed-444https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8301Order only for latest_successful_for2019-09-19T23:38:42Zusername-removed-423915Order only for latest_successful_forFix the issue in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8286#note_20461082
TODO:
* [ ] Add a test which could reproduce it
* [ ] Figure out how to order `latest` or maybe rename it otherwise the name `latest` is co...Fix the issue in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8286#note_20461082
TODO:
* [ ] Add a test which could reproduce it
* [ ] Figure out how to order `latest` or maybe rename it otherwise the name `latest` is confusing
/cc @grzesiek @alfredo1 @balasankarc @ayufan 8.15Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8097Resolve "Direct link from pipeline list to builds"2019-09-19T23:27:47ZFilipa Lacerdafilipa@gitlab.comResolve "Direct link from pipeline list to builds"## What does this MR do?
- Adds a dropdown with builds in the mini pipeline graph in the pipelines table
- Unnest a lot of CSS related with pipelines in order to make it reusable
## Screenshots
![Screen_Shot_2016-12-15_at_14.45.41](/upl...## What does this MR do?
- Adds a dropdown with builds in the mini pipeline graph in the pipelines table
- Unnest a lot of CSS related with pipelines in order to make it reusable
## Screenshots
![Screen_Shot_2016-12-15_at_14.45.41](/uploads/ca1c61842a422a34383e029d668034b7/Screen_Shot_2016-12-15_at_14.45.41.png)
![Screen_Shot_2016-12-15_at_14.45.49](/uploads/952e3277143639ce4ad111103034faeb/Screen_Shot_2016-12-15_at_14.45.49.png)
![Screen_Shot_2016-12-15_at_14.46.02](/uploads/f7369a124b1c3c0db4194de2cb637ef0/Screen_Shot_2016-12-15_at_14.46.02.png)
![graph_animation](/uploads/9bae036cb5acff499f992a4722943d72/graph_animation.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #25071
Closes #19703 8.15Grzegorz BizonGrzegorz Bizonhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7690Add online terminal support for Kubernetes2019-09-19T23:23:00ZNick ThomasAdd online terminal support for Kubernetes## What does this MR do?
Gives terminal access to kubernetes-deployed environments via the deployment service
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Part of idea to production
...## What does this MR do?
Gives terminal access to kubernetes-deployed environments via the deployment service
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Part of idea to production
## Screenshots (if relevant)
### `/root/reviewing/environments`
![Screen_Shot_2016-12-15_at_19.10.40](/uploads/bd2c54c07b6c85dec3328a20cd185b64/Screen_Shot_2016-12-15_at_19.10.40.png)
### `/root/reviewing/environments/10013`
![Screen_Shot_2016-12-19_at_12.52.39](/uploads/db4e4e06cda88437e8727433d65898b9/Screen_Shot_2016-12-19_at_12.52.39.png)
### `/root/reviewing/enviroments/10013/terminal`
![Screen_Shot_2016-12-15_at_02.35.52](/uploads/1bb77b7e2de2c657ae3bda62dc4f0970/Screen_Shot_2016-12-15_at_02.35.52.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [X] Added for this feature/bug
- [x] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
* Closes #22864 #22958
* Alternative to, and somewhat based on, !6770
* Depends on https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/838.15Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7180Create an issue for all unresolved discussions in an MR2019-09-19T23:22:01ZBob Van Landuyt :neckbeard:Create an issue for all unresolved discussions in an MR## What does this MR do?
This MR builds a new issue for unresolved discussions in an MR.
When creating the issue, all the discussions are resolved in the originating MR.
The discussions get a new system note mentioning the newly created...## What does this MR do?
This MR builds a new issue for unresolved discussions in an MR.
When creating the issue, all the discussions are resolved in the originating MR.
The discussions get a new system note mentioning the newly created issue.
The following still needs to be done:
- [x] ~~Add a checkbox to the Issue form to resolve all discussions in the originating MR~~
- [x] Resolve all discussions in the MR
- [x] Add a system note for each resolved discussion
## Are there points in the code the reviewer needs to double check?
~~Am I iterating over the correct [discussions](https://gitlab.com/reprazent/gitlab-ce/blob/23589-open-issue-for-mr/app/models/merge_request.rb#L471)
or should I only mention the [diff_discussions](https://gitlab.com/reprazent/gitlab-ce/blob/23589-open-issue-for-mr/app/models/merge_request.rb#L478)~~
~~What information should the built issue contain?~~
## Why was this MR needed?
This would allow the reviewer of an MR to quickly resolve all discussions in an MR to be able to merge it after !7125 is implemented.
## Screenshots (if relevant)
This currently just includes a simple link when applicable with the merge request status:
![Screen_Shot_2016-11-19_at_17.39.09](/uploads/399d557336bc59968ed4bb77ee0171d6/Screen_Shot_2016-11-19_at_17.39.09.png)
But this is still being discussed in #23589
When clicking this link a new issue is prepared with references to the unresolved discussions:
![Screen_Shot_2016-11-19_at_17.41.30](/uploads/034df88e8242a09a27cb7aa32461f38d/Screen_Shot_2016-11-19_at_17.41.30.png)
At the bottom of this page we have a mention that this will resolve all discussions in the merge request.
![Screen_Shot_2016-11-19_at_18.05.16](/uploads/ef6c07f760864328573d845a5bf58e0f/Screen_Shot_2016-11-19_at_18.05.16.png)
But this should be a bigger warning as mentioned in https://gitlab.com/gitlab-org/gitlab-ce/issues/23589#note_17481832
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
The discussion was started in #23589
~~This is based on !7125 (which was started in !6385), so I'll rebase those first commits out when it gets merged.~~
@DouweM @smcgivern8.15Bob Van Landuyt :neckbeard:Bob Van Landuyt :neckbeard:https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7631Resolve "User-generated permalink IDs collide with GitLab interface"2019-09-19T23:12:07Zusername-removed-636429Resolve "User-generated permalink IDs collide with GitLab interface"## What does this MR do?
Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewh...## What does this MR do?
Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewhere in the GitLab interface. This can cause confusion when, for instance, a selector looks for a merge request tab with `id="pipelines"` and there is a header with the same ID earlier in the DOM.
How this works:
* All header IDs generated with GitLab Flavored Markdown are namespaced with `id="user-content_foo"`
* All anchor links which point to these IDs continue to use the non-namespaced hash `<a href="#foo">...</a>`
* When a page is loaded or when the `hashchange` event is triggered, javascript will automatically search for `#user-content_foo` if `#foo` cannot be found, and scroll to that position instead.
## Before
![2016-11-21-13.00.28](/uploads/e3be2cd6a9142dfd6e64db5462a6aa76/2016-11-21-13.00.28.gif)
## After:
![2016-11-21-13.12.45](/uploads/f7ae3f3a30c91325eaa3665591b6a850/2016-11-21-13.12.45.gif)
![2016-11-21-13.03.00](/uploads/3a6a782c081ecaa05b8781548d794909/2016-11-21-13.03.00.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22781
See also prior attempts to address this issue:
#3908, !2023, !2024
8.15username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7784Add StackProf to the Gemfile, along with a utility to get a profile for a spec2019-09-19T23:05:47ZNick ThomasAdd StackProf to the Gemfile, along with a utility to get a profile for a spec## What does this MR do?
Adds stackprof to the development / test environment, along with a script to do an rspec run under stackprof
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
The ...## What does this MR do?
Adds stackprof to the development / test environment, along with a script to do an rspec run under stackprof
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
The test suite needs speeding up significantly. This is one tool for investigating it.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [X] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Related to #230348.15Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7779Speed up Project security access specs2019-09-19T23:05:47ZRobert SpeicherSpeed up Project security access specsPrior, every single test was creating four `ProjectMember` objects, each
of which created one `User` record, even though each test only used
_one_ of those Users, if any.
Now each test only creates the single user record it needs, i...Prior, every single test was creating four `ProjectMember` objects, each
of which created one `User` record, even though each test only used
_one_ of those Users, if any.
Now each test only creates the single user record it needs, if it needs
one. This shaves minutes off of each spec file changed here.
Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/248998.15username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7686Replace static fixture for zen_mode_spec2019-09-19T23:00:47Zusername-removed-14714Replace static fixture for zen_mode_spec## What does this MR do?
Replace `zen_mode.html.haml` for `zen_mode_spec.js` by already existing dynamically generated fixture.
## What are the relevant issue numbers?
#24753## What does this MR do?
Replace `zen_mode.html.haml` for `zen_mode_spec.js` by already existing dynamically generated fixture.
## What are the relevant issue numbers?
#247538.15https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7687Replace static fixture for right_sidebar_spec2019-09-19T23:00:47Zusername-removed-14714Replace static fixture for right_sidebar_spec## What does this MR do?
Replace `right_sidebar.html.haml` for `right_sidebar_spec.js` by already existing dynamically generated fixture.
## What are the relevant issue numbers?
#24753## What does this MR do?
Replace `right_sidebar.html.haml` for `right_sidebar_spec.js` by already existing dynamically generated fixture.
## What are the relevant issue numbers?
#247538.15username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7685Replace static fixture for shortcuts_issuable_spec2019-09-19T23:00:46Zusername-removed-14714Replace static fixture for shortcuts_issuable_spec## What does this MR do?
Replace `issuable.html.haml` for `shortcuts_issuable_spec.js` by already existing dynamically generated fixture.
## What are the relevant issue numbers?
#24753## What does this MR do?
Replace `issuable.html.haml` for `shortcuts_issuable_spec.js` by already existing dynamically generated fixture.
## What are the relevant issue numbers?
#247538.15https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7683Replace static fixture for notes_spec2019-09-19T23:00:46Zusername-removed-14714Replace static fixture for notes_spec## What does this MR do?
Replace `comments.html.haml` and `issue_note.html.haml` used in `notes_spec.js` by dynamically created fixture.
## What are the relevant issue numbers?
#24753## What does this MR do?
Replace `comments.html.haml` and `issue_note.html.haml` used in `notes_spec.js` by dynamically created fixture.
## What are the relevant issue numbers?
#247538.15https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7589Create dynamic fixture for build_spec2019-09-19T23:00:46Zusername-removed-14714Create dynamic fixture for build_spec## What does this MR do?
Replace `spec/javascripts/fixtures/build.html.haml` by a dynamically created fixture (using `rake teaspoon:fixtures`).
## Why was this MR needed?
The existing fixture was not representing the real page. ...## What does this MR do?
Replace `spec/javascripts/fixtures/build.html.haml` by a dynamically created fixture (using `rake teaspoon:fixtures`).
## Why was this MR needed?
The existing fixture was not representing the real page.
## What are the relevant issue numbers?
#24614 would have been avoided
following !60598.15Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7661Replace static fixture for awards_handler_spec2019-09-19T23:00:45Zusername-removed-14714Replace static fixture for awards_handler_spec## What does this MR do?
Use the already existing dynamic fixture `issues/open-issue.html` (!6059) in `awards_handler_spec.js` instead of the static fixture `awards_handler.html.haml`.
## What are the relevant issue numbers?
#24753## What does this MR do?
Use the already existing dynamic fixture `issues/open-issue.html` (!6059) in `awards_handler_spec.js` instead of the static fixture `awards_handler.html.haml`.
## What are the relevant issue numbers?
#247538.15https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7318Clean up common_utils.js2019-09-19T23:00:45Zusername-removed-14714Clean up common_utils.js## What does this MR do?
- Remove unused functions from `common_utils.js`.
- Move functions which are used from only one file to that file.
## Why was this MR needed?
Because some utils weren't that common (anymore).## What does this MR do?
- Remove unused functions from `common_utils.js`.
- Move functions which are used from only one file to that file.
## Why was this MR needed?
Because some utils weren't that common (anymore).8.15https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7644Replace static fixture for abuse_reports_spec2019-09-19T23:00:45Zusername-removed-14714Replace static fixture for abuse_reports_spec## What does this MR do?
Replace static HAML fixture for `abuse_reports_spec` by dynamically created one.
## What are the relevant issue numbers?
#24753## What does this MR do?
Replace static HAML fixture for `abuse_reports_spec` by dynamically created one.
## What are the relevant issue numbers?
#247538.15Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7852Refactor branch chooser in issuable form2019-09-19T22:36:48Zusername-removed-128633Refactor branch chooser in issuable formContinuation of #23864.
Sister of gitlab-org/gitlab-ee!930.Continuation of #23864.
Sister of gitlab-org/gitlab-ee!930.8.15Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7758Refactor issuable description and metadata form sections2019-09-19T22:36:48Zusername-removed-128633Refactor issuable description and metadata form sectionsContinuation of https://gitlab.com/gitlab-org/gitlab-ce/issues/23864.
Brother of gitlab-org/gitlab-ee!916.
Continuation of https://gitlab.com/gitlab-org/gitlab-ce/issues/23864.
Brother of gitlab-org/gitlab-ee!916.
8.15Robert SpeicherRobert Speicher