GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-09-20T02:46:33Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10403Eager load to avoid N+1 queries when there are labels from multiple projects ...2019-09-20T02:46:33ZStan HuEager load to avoid N+1 queries when there are labels from multiple projects in a milestoneFound by Bullet in !10263 in https://gitlab.com/gitlab-org/gitlab-ce/builds/13490762
This one is subtle: even though we have a `QueryRecorder` checking for N+1 queries, what we don't test is labels in multiple projects of a milestone.Found by Bullet in !10263 in https://gitlab.com/gitlab-org/gitlab-ce/builds/13490762
This one is subtle: even though we have a `QueryRecorder` checking for N+1 queries, what we don't test is labels in multiple projects of a milestone.9.1Stan HuStan Huhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10072WIP: remove underscore - use lodash and babel plugin2017-09-05T14:34:28Zusername-removed-642931git@selfup.meWIP: remove underscore - use lodash and babel plugin## What does this MR do?
It removes the non tree-shakeable underscore and uses lodash instead (which is also faster :smile:)
## Are there points in the code the reviewer needs to double check?
All of the things
## Why was thi...## What does this MR do?
It removes the non tree-shakeable underscore and uses lodash instead (which is also faster :smile:)
## Are there points in the code the reviewer needs to double check?
All of the things
## Why was this MR needed?
Because sanity and performance
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#231109.1https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10027Fix margin issue between buttons on pipeline page2017-03-24T13:12:26Zusername-removed-663219Fix margin issue between buttons on pipeline page## What does this MR do?
Fix a margin between two buttons, as requested in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9391#note_24068315
## Are there points in the code the reviewer needs to double check?
There was a...## What does this MR do?
Fix a margin between two buttons, as requested in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9391#note_24068315
## Are there points in the code the reviewer needs to double check?
There was an extra whitespace character between the buttons that didn't appear in other places. Really hard to track it down. Finally I followed an example from `app/views/projects/commit/_commit_box.html.haml` and put the text for the `Retry` button in a `do` loop in the Haml file, and that got rid of the space. Weird...
## Screenshots (if relevant)
Before:
![2017-03-16_2046](/uploads/df3d6a7de9089ce7e05e65ad10c291de/2017-03-16_2046.png)
After:
![2017-03-16_2044](/uploads/10b7ac7b11f09ecf1a9884cfaec6f2c4/2017-03-16_2044.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)9.1username-removed-663219username-removed-663219https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9842Add endpoints to list projects for a user2017-03-21T16:34:31Zusername-removed-419655Add endpoints to list projects for a user## What does this MR do?
Add endpoints to list projects for a user
This addition to the API provides project lists like the user profile
* Personal projects
* Contributed projects
## Does this MR meet the acceptance criteria?
- [x] ...## What does this MR do?
Add endpoints to list projects for a user
This addition to the API provides project lists like the user profile
* Personal projects
* Contributed projects
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #179319.1username-removed-419655username-removed-419655