GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-03-17T11:40:07Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8754WIP: Flex board columns2017-03-17T11:40:07Zusername-removed-101821WIP: Flex board columns## What does this MR do?
Making issues board columns flexable
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
More user friendly view.
## Screenshots (if relevant)
## Does this MR me...## What does this MR do?
Making issues board columns flexable
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
More user friendly view.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?9.0username-removed-101821username-removed-101821https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8698WIP: Confidential notes/comments2017-09-18T10:04:49Zusername-removed-526579WIP: Confidential notes/comments## What does this MR do?
Confidential notes
## Are there points in the code the reviewer needs to double check?
This is just small draft...and a long way from finished MR. Just a way to show that I'm interested in working on this fe...## What does this MR do?
Confidential notes
## Are there points in the code the reviewer needs to double check?
This is just small draft...and a long way from finished MR. Just a way to show that I'm interested in working on this feature proposal :)
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#27034https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8687Force update the target branch after the target project changed in MR2017-09-02T08:25:56Zusername-removed-100770Force update the target branch after the target project changed in MR## What does this MR do?
Force update the target branch after the target project changed when creating a new Merge Request.
## Are there points in the code the reviewer needs to double check?
Compare class in JS may need refacto...## What does this MR do?
Force update the target branch after the target project changed when creating a new Merge Request.
## Are there points in the code the reviewer needs to double check?
Compare class in JS may need refactoring.
## Why was this MR needed?
Unchanging he target branch even after the target project changed when creating a new Merge Request is convenient for projects that has different default branches than `master`.
## Screenshots (if relevant)
![target-branch-selection-in-mr-from-forked-project-gitlab](/uploads/21c97be6ee465898aaaf7c360d8e87ef/target-branch-selection-in-mr-from-forked-project-gitlab.mp4)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [n/a] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [n/a] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #27020https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8684WIP: Democratic emojis2017-06-13T20:03:20Zusername-removed-494217WIP: Democratic emojis## What does this MR do?
Adds the ability to create a list of democratic emoji vote options for an issue. This looks to be a proposed solution for items 1 and 2 on issue #24277
## Are there points in the code the reviewer needs to d...## What does this MR do?
Adds the ability to create a list of democratic emoji vote options for an issue. This looks to be a proposed solution for items 1 and 2 on issue #24277
## Are there points in the code the reviewer needs to double check?
There are two commits one for each deliverable task on the issue. I realise these will need squashed but I have provided details of what was done in each commit message.
## Why was this MR needed?
I am looking for feedback on my current approach and any suggestions on how I could improve my solution. This MR should be reviewed by @DouweM
## Screenshots (if relevant)
![Screenshot_2017-01-27_14.54.02](/uploads/76eb087105a80b6087eda16a950b98a8/Screenshot_2017-01-27_14.54.02.png)
## Does this MR meet the acceptance criteria?
Not yet as this is simply a work in progress merge request. I have tried to be honest about the time spent working on this issue which is why there has not been a huge amount of progress for example testing and style fixups.
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#24277https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8647WIP: Add a Milestone progress bar on Issue2017-06-19T12:25:25Zusername-removed-100770WIP: Add a Milestone progress bar on Issue## What does this MR do?
Add a Milestone progress bar on Issue page.
## Are there points in the code the reviewer needs to double check?
- In a compact view of the side bar, we may need to fix css more.
## Why was this MR n...## What does this MR do?
Add a Milestone progress bar on Issue page.
## Are there points in the code the reviewer needs to double check?
- In a compact view of the side bar, we may need to fix css more.
## Why was this MR needed?
This MR allows users to notify the progress of the milestone for the issue.
## Screenshots (if relevant)
~~See #26862~~
Updated:
### Normal view
![milestone-progress-bar-on-issue-normal_v2](/uploads/c82a3a32ef7d31dcd99c280451124399/milestone-progress-bar-on-issue-normal_v2.png)
### Compact view
![milestone-progress-bar-on-issue-compact_v2](/uploads/549b7d144cd30ef57ea1149ca5e1e1c6/milestone-progress-bar-on-issue-compact_v2.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [n/a] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [n/a] API support added
- Tests
- [n/a] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #26862username-removed-100770username-removed-100770https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8557Switch to 'secret variable' name in variables endpoint API docs2017-01-13T14:23:48Zusername-removed-382401Switch to 'secret variable' name in variables endpoint API docsBoth web UI as well as other docs use 'secret variable' name instead of currently used 'build variable' in the API docs. This MR is to unify this by changing the API docs.Both web UI as well as other docs use 'secret variable' name instead of currently used 'build variable' in the API docs. This MR is to unify this by changing the API docs.https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8533markdown.md edits2017-04-27T17:54:29Zusername-removed-881360markdown.md edits## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs....## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8495Display all user activity on contribution calendar regardless of permission s...2017-10-06T03:36:39Zusername-removed-91641Display all user activity on contribution calendar regardless of permission scope.## Display all user contribution counts from both private and public as activity.
- Be aware that I'm not a **Ruby** dev (Golang/PHP), I have followed existing code examples but please help me ensure standards are met.
- Confirm perfo...## Display all user contribution counts from both private and public as activity.
- Be aware that I'm not a **Ruby** dev (Golang/PHP), I have followed existing code examples but please help me ensure standards are met.
- Confirm performance impact on returning all records a user has contributed to. Memory consumption should increase, but execution should be less due to straight select without filtering.
## Why was this MR needed?
VCS profiles are used more and more as reference points and resumes for both contributors and recruiters. The current behaviour of Gitlab is to suppress contributions made to private projects from the public domain via the contributions calendar, eg [https://gitlab.com/kylehqcom](https://gitlab.com/kylehqcom). But that doesn't give a ***true*** sense of a users activity. In this context, ***"activity"*** should be based on any contributions to a project, private or public.
Of course this **does not** mean that details of private projects should be returned to the public. The code included in this MR simply returns contribution counts as user activity for both private and public projects. Only public project commit details are displayed as normal, but all count values are returned. This behaviour is respected on specific date selecting also.
#### Existing non authenticated view
![master-no-auth](/uploads/fe5ecf84f05ff861c02bede2614acf5e/master-no-auth.png)
#### New non authenticated view
Note the ***No public contributions found*** addition.
![new-no-auth](/uploads/8d629bbc57083a32affd0c2d65e024fd/new-no-auth.png)
#### New authenticated view
Note the **so-private** commit entry which is returned in the auth'd view and is the source to the contribution count of the non auth'd view.
![new-auth](/uploads/7253727cfb6d7404d730f0bf380c330b/new-auth.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Please refer to [https://gitlab.com/gitlab-org/gitlab-ce/issues/14078](https://gitlab.com/gitlab-org/gitlab-ce/issues/14078) for comments and +1's to this feature request.
Thanks, Kylehttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8494WIP: Group MR numbers on issue show page by project and namespace2018-06-21T01:27:58Zusername-removed-235897WIP: Group MR numbers on issue show page by project and namespace## What does this MR do?
Groups MRs on the issue show page into those for the current project, those for projects in the namespace, and projects outside of the namespace. This makes the ordering consistent with the work done on #7110.
...## What does this MR do?
Groups MRs on the issue show page into those for the current project, those for projects in the namespace, and projects outside of the namespace. This makes the ordering consistent with the work done on #7110.
## Are there points in the code the reviewer needs to double check?
None that I can think of. Maybe if anything, a visual separator between different projects?
## Why was this MR needed?
Consistency with other ordering.
## Screenshots (if relevant)
Old:
![Screen_Shot_2017-01-08_at_4.56.14_PM](/uploads/a0ac6f78ce9ee300aefa4cbef4b57529/Screen_Shot_2017-01-08_at_4.56.14_PM.png)
New:
![Screen_Shot_2017-01-08_at_4.52.12_PM](/uploads/58f90aaff123576a4671f32bb01f5647/Screen_Shot_2017-01-08_at_4.52.12_PM.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- N/A [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- N/A API support added
- Tests
- N/A Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #26466https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8490WIP: Add single-click filters for all, active, stale and protected branches2017-09-12T10:38:50Zusername-removed-9199WIP: Add single-click filters for all, active, stale and protected branches## What does this MR do?
It adds single-click state filters (all, active, stale, protected) for the branches page.
## Are there points in the code the reviewer needs to double check?
Please check for style.
I haven't included pro...## What does this MR do?
It adds single-click state filters (all, active, stale, protected) for the branches page.
## Are there points in the code the reviewer needs to double check?
Please check for style.
I haven't included protected branches in 'all' branches. I think it will be necessary, but wanted to double check first, hence WIP.
## Why was this MR needed?
It addresses #17293
## Screenshots (if relevant)
![Screen_Shot_2017-01-08_at_14.00.36](/uploads/1dbdfb6f2fb2e7fcd59080fcce8499b8/Screen_Shot_2017-01-08_at_14.00.36.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #1729310.3https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8487Add wiki templates2017-06-07T19:11:23Zusername-removed-790846Add wiki templates## What does this MR do?
It adds Wiki Templates as proposed in https://gitlab.com/gitlab-org/gitlab-ce/issues/25182 by making WikiPage a little similar to an Issuable (MergeRequest and Issue) and reusing the Issuable's templating logic ...## What does this MR do?
It adds Wiki Templates as proposed in https://gitlab.com/gitlab-org/gitlab-ce/issues/25182 by making WikiPage a little similar to an Issuable (MergeRequest and Issue) and reusing the Issuable's templating logic existing code. As @smcgivern commented out https://gitlab.com/gitlab-org/gitlab-ce/issues/25182#note_20543250 the templates goes into the wiki's repo inside `.gitlab/wiki_templates` folder.
## Are there points in the code the reviewer needs to double check?
Some thoughts that crossed my mind while I was coding:
* Extracting another module (probably called Templatable) from Issuable maybe better semantically due WikiPage not being an Issuable
* Extracting copy_wiki_repo and copy_repo similarities into a better method.
* I'm pretty sure format isn't the best label for template and markdown.
## Why was this MR needed?
Because it's a step to enhance built-in wiki functionality.
## Screenshots
### Before
![Screen_Shot_2017-01-07_at_7.46.47_PM](/uploads/12a328dce93333570f578fbc9bbe8b26/Screen_Shot_2017-01-07_at_7.46.47_PM.png)
### After
#### Edit
#### New without template files
![new_no_template](/uploads/6f973f7a702bab30b6db68eab9496987/new_no_template.png)
#### New with template and small
![Screen_Shot_2017-01-14_at_9.24.47_PM](/uploads/770bd19d520096cf2547d4b290ea4d48/Screen_Shot_2017-01-14_at_9.24.47_PM.png)
#### New with template and medium
![Screen_Shot_2017-01-14_at_9.24.32_PM](/uploads/1583a5623a84ad6504d31de628a384c1/Screen_Shot_2017-01-14_at_9.24.32_PM.png)
#### New with template and large
![Screen_Shot_2017-01-14_at_9.24.17_PM](/uploads/42d26b4418dab3ec80abd2a437876fd5/Screen_Shot_2017-01-14_at_9.24.17_PM.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master`
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/25182https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8473adding Next todo button to menu2017-03-16T15:08:15Zusername-removed-928216adding Next todo button to menu## What does this MR do?
it adds Next todo to dashboard
## Are there points in the code the reviewer needs to double check?
performance of query
## Why was this MR needed?
Fixes #26292
## Screenshots (if relevant)
## Does ...## What does this MR do?
it adds Next todo to dashboard
## Are there points in the code the reviewer needs to double check?
performance of query
## Why was this MR needed?
Fixes #26292
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)username-removed-928216username-removed-928216https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8394Resolve link hover+focus consistency issues2017-09-08T11:17:37ZLuke "Jared" BennettResolve link hover+focus consistency issues## What does this MR do?
Adds a mixin for the hover+focus state of links, which sets the color and underline.
Applies this mixin on all the links we need it on.
## Are there points in the code the reviewer needs to double check?...## What does this MR do?
Adds a mixin for the hover+focus state of links, which sets the color and underline.
Applies this mixin on all the links we need it on.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
This affects 90% of pages so this can only be reviewed by checking out. We have plenty of time to review this, conflicts shouldn't be too hard to keep up with so please take your time. :)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24129
Closes #24125
Closes #24130https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8388Remember unsaved wiki changes using autosave.js2017-01-24T19:06:46Zusername-removed-52628Remember unsaved wiki changes using autosave.js## What does this MR do?
Save unsaved edits in a wiki page in browser's local storage using autosave.js.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitla...## What does this MR do?
Save unsaved edits in a wiki page in browser's local storage using autosave.js.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitlab-ce/issues/24738
## Screenshots (if relevant)
![TestEditingWiki](/uploads/0d1c5b1828f17f9e9258d4fc2bf8ceb4/TestEditingWiki.gif)
![TestCreatingWiki](/uploads/5c417bb95d74b4329338d2490a246781/TestCreatingWiki.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#24738username-removed-52628username-removed-52628https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8366Added info about Admin user ability to push to protected brances.2016-12-29T14:19:38Zusername-removed-581582Added info about Admin user ability to push to protected brances.This info is missing from the docs. A Gitlab admin is allowed to push to protected branches.
ZD info: https://gitlab.zendesk.com/agent/tickets/54796This info is missing from the docs. A Gitlab admin is allowed to push to protected branches.
ZD info: https://gitlab.zendesk.com/agent/tickets/54796https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8352Support reopening tracker issues from the merge request or commit message2017-03-16T15:05:37Zusername-removed-815351Support reopening tracker issues from the merge request or commit message## What does this MR do?
Support reopening issues by specifying `Reopen`/`Reopening`/`Reopens` <issue(s)> in a similar manner to the
currently supported `Closes`/`Fixing` <issue(s)> format, from the merge request of the commit message.
...## What does this MR do?
Support reopening issues by specifying `Reopen`/`Reopening`/`Reopens` <issue(s)> in a similar manner to the
currently supported `Closes`/`Fixing` <issue(s)> format, from the merge request of the commit message.
## Are there points in the code the reviewer needs to double check?
The regex (`ISSUE_REOPEN_REGEX`) in `lib/gitlab/reopening_issue_extractor.rb`.
## Why was this MR needed?
A feature request (https://gitlab.com/gitlab-org/gitlab-ce/issues/26072)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #26072username-removed-815351username-removed-815351https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8312added missing asciidoc&rdoc support to the wiki editor2017-03-14T14:56:07Zusername-removed-863210jnoortheen@gmail.comadded missing asciidoc&rdoc support to the wiki editor## What does this MR do?
With !8036 fixes issues addressed in #24041 & #24042 .
## Are there points in the code the reviewer needs to double check?
I tried to maintain the code changes without much affecting the existing behavi...## What does this MR do?
With !8036 fixes issues addressed in #24041 & #24042 .
## Are there points in the code the reviewer needs to double check?
I tried to maintain the code changes without much affecting the existing behavior and code base. JS Style needs to be confirmed. New file mode needs to be checked.
## Why was this MR needed?
Issue/bug resolution
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24041, #24042https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8303WIP: Added description asset2017-09-08T11:17:38ZLuke "Jared" BennettWIP: Added description asset## What does this MR do?
Adds opensearch description asset and an autodiscovery link to register gitlab search as a search engine for [opensearch-supported browsers](http://www.opensearch.org/Community/OpenSearch_search_clients)
##...## What does this MR do?
Adds opensearch description asset and an autodiscovery link to register gitlab search as a search engine for [opensearch-supported browsers](http://www.opensearch.org/Community/OpenSearch_search_clients)
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-12-24_at_13.59.51](/uploads/37e15aa8f012f2e20d8c8b9dd2881e8e/Screen_Shot_2016-12-24_at_13.59.51.png)![Screen_Shot_2016-12-24_at_14.00.57](/uploads/7b14c211c545914047daa6030cd8ac07/Screen_Shot_2016-12-24_at_14.00.57.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8178allow rake web_hook:add to accept more params2017-05-30T12:14:30Zusername-removed-268196allow rake web_hook:add to accept more params## What does this MR do?
This fixes #25818## What does this MR do?
This fixes #25818username-removed-268196username-removed-268196https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8170Bitbucket Oauth instructions for GitHost2017-07-28T15:56:15ZDe WetBitbucket Oauth instructions for GitHostGitHost.io users do not have access to their configuration files, so when they follow the instructions, they need to know that they can do it in the GitHost admin panel.GitHost.io users do not have access to their configuration files, so when they follow the instructions, they need to know that they can do it in the GitHost admin panel.Drew BlessingDrew Blessing