GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-07-07T18:52:58Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8160Add application create API2017-07-07T18:52:58Zusername-removed-852474Add application create API## What does this MR do?
Adding an API for creating applications
## Are there points in the code the reviewer needs to double check?
This is my first MR, i'm not sure about your good practices.
Also, i'm not native English spea...## What does this MR do?
Adding an API for creating applications
## Are there points in the code the reviewer needs to double check?
This is my first MR, i'm not sure about your good practices.
Also, i'm not native English speaker.
## Why was this MR needed?
It resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/24035
## Screenshots (if relevant)
Not relevant
## Does this MR meet the acceptance criteria?
- [ ✓] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [✓ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ✓] API support added
- Tests
- [ ✓] Added for this feature/bug
- [× , not my code?] All builds are passing
- [ ✓] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ✓] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ✓] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ✓] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #240359.0username-removed-852474username-removed-852474https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8120Add dropdown to make an email Primary/Notification/Public on the Emails tab i...2017-07-17T14:36:08Zusername-removed-862804Add dropdown to make an email Primary/Notification/Public on the Emails tab in User Profile## Add a dropdown to make an email the Primary/Notification/Public Email for a User. Ask for confirmation if email not already confirmed.
## Before
![Screen_Shot_2016-12-03_at_02.11.33](/uploads/83bc6c90b100c3c8beda90ce4a4fa7e3/Scre...## Add a dropdown to make an email the Primary/Notification/Public Email for a User. Ask for confirmation if email not already confirmed.
## Before
![Screen_Shot_2016-12-03_at_02.11.33](/uploads/83bc6c90b100c3c8beda90ce4a4fa7e3/Screen_Shot_2016-12-03_at_02.11.33.png)
## After
![newEmailOptions](/uploads/d508a334329687a3689da855a8eff409/newEmailOptions.png)
## Issue #24910username-removed-862804username-removed-862804https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8114Resolve "Editing the title of a MR creates a new link to jira"2017-08-23T09:47:26Zusername-removed-889331Resolve "Editing the title of a MR creates a new link to jira"## What does this MR do?
It fixes the problem with duplicate links on Jira when editing the title of a MR and it also updates the link's title and comment.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://d...## What does this MR do?
It fixes the problem with duplicate links on Jira when editing the title of a MR and it also updates the link's title and comment.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #25373
/cc @smcgivernusername-removed-889331username-removed-889331https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8036fix: added preview support for asciidoc and rdoc formats2017-03-14T15:01:13Zusername-removed-863210jnoortheen@gmail.comfix: added preview support for asciidoc and rdoc formats## What does this MR do?
adds preview & relative links support for asciidoc/rdoc formats
## Are there points in the code the reviewer needs to double check?
nope.
## Why was this MR needed?
issue/bug resolution
## Screenshots...## What does this MR do?
adds preview & relative links support for asciidoc/rdoc formats
## Are there points in the code the reviewer needs to double check?
nope.
## Why was this MR needed?
issue/bug resolution
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#1193 , #24041 , #24042
Closes #1193username-removed-863210jnoortheen@gmail.comusername-removed-863210jnoortheen@gmail.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7965Create a parent class to group Todos2017-08-18T08:48:15Zusername-removed-843590Create a parent class to group Todos## What does this MR do?
This MR is the first step on implementing #24978, which will group todos on todo events, to help fix the problem where you don't get a new todo if you have an active one for the same event.
The first part I imp...## What does this MR do?
This MR is the first step on implementing #24978, which will group todos on todo events, to help fix the problem where you don't get a new todo if you have an active one for the same event.
The first part I implemented was the data, as having valid data to work with helps a lot when creating the other parts.
## Are there points in the code the reviewer needs to double check?
This MR is still under development, so there's still lots of work to do.
As of now, the following is implemented:
* A new model called TodoEvent
* A migration to both create the new `todo_events` and populate the `todo_event_id` field on `todos`. This migration was handwritten to optimize both run (wall) time and reduce the number of locks, so the code is more complex than what's necessary.
There are still no tests, they are going to be added ASAP, and things might break on the migration, so more attention is necessary.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24978https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7941WIP: prevent users from removing their last authentication method2017-07-25T23:22:09Zusername-removed-226882WIP: prevent users from removing their last authentication method## What does this MR do?
Ensure users always have at least one way to log in
## Are there points in the code the reviewer needs to double check?
I have no idea where/how to test this
## Why was this MR needed?
## Screenshots (if rel...## What does this MR do?
Ensure users always have at least one way to log in
## Are there points in the code the reviewer needs to double check?
I have no idea where/how to test this
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3332username-removed-226882username-removed-226882https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7886Correct the pipeline trigger time2017-05-08T16:01:28ZCindy Pallares 🦉Correct the pipeline trigger time## What does this MR do?
Correctly show the time the pipeline was triggered.
## Why was this MR needed?
Currently when a pipeline is triggered the time stamp shows the time of the last commit, not when the pipeline was actually triggere...## What does this MR do?
Correctly show the time the pipeline was triggered.
## Why was this MR needed?
Currently when a pipeline is triggered the time stamp shows the time of the last commit, not when the pipeline was actually triggered.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#25240https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7824WIP: Implement API endpoint to get all builds in an environment2017-03-16T14:38:05Zusername-removed-164769WIP: Implement API endpoint to get all builds in an environment## What does this MR do?
It implements a new API endpoint, `GET /projects/:id/environments/:environment_id/builds`, which allows the retrieval of all builds belonging to a certain environment
## Are there points in the code the reviewe...## What does this MR do?
It implements a new API endpoint, `GET /projects/:id/environments/:environment_id/builds`, which allows the retrieval of all builds belonging to a certain environment
## Are there points in the code the reviewer needs to double check?
All of it, essentially, since I have no previous experience w/ Grape and no clue if I did the right thing, especially when checking permissions.
## Why was this MR needed?
The motivation for this MR is described in #25084
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#25084username-removed-164769username-removed-164769https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7684WIP: Display contributor badge for users with merged merge requests2017-03-16T14:37:12Zusername-removed-157146gitlab@espadav8.co.ukWIP: Display contributor badge for users with merged merge requests## What does this MR do?
## Are there points in the code the reviewer needs to double check?
Displays a `Contributor` badge for users that have merged merge requests in the target project.
## Screenshots (if relevant)
![Scree...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
Displays a `Contributor` badge for users that have merged merge requests in the target project.
## Screenshots (if relevant)
![Screenshot_from_2016-11-23_09-06-59](/uploads/d084aa23f4316a634f958fa27e1ee911/Screenshot_from_2016-11-23_09-06-59.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24838https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7610Send email when pushing more commits to the merge request2017-09-26T10:45:11Zusername-removed-803846Send email when pushing more commits to the merge request## Related documents
* https://docs.gitlab.com/ee/workflow/notifications.html
* https://docs.gitlab.com/ce/api/notification_settings.html
## Are there points in the code the reviewer needs to double check?
## Why was this MR ...## Related documents
* https://docs.gitlab.com/ee/workflow/notifications.html
* https://docs.gitlab.com/ce/api/notification_settings.html
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #2346010.1username-removed-803846username-removed-803846https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7540Resolve "Create release notes from closed milestone"2017-03-17T11:06:31Zusername-removed-804721Resolve "Create release notes from closed milestone"* Add a button "New Release Tag" to milestones/show if the milestone status is closed and no release tag has been created.
![Screen_Shot_2016-11-26_at_1.13.23_PM](/uploads/8f3d636aa0e7044f5034e4d4df412360/Screen_Shot_2016-11-26_at_1.13....* Add a button "New Release Tag" to milestones/show if the milestone status is closed and no release tag has been created.
![Screen_Shot_2016-11-26_at_1.13.23_PM](/uploads/8f3d636aa0e7044f5034e4d4df412360/Screen_Shot_2016-11-26_at_1.13.23_PM.png)
![Screen_Shot_2016-11-26_at_1.13.38_PM](/uploads/f6c714ddfcc79ffe5fcf2d67c222cc21/Screen_Shot_2016-11-26_at_1.13.38_PM.png)
* Add a link to milestones/show description with the release tag (if exists)
![Screen_Shot_2016-11-26_at_1.14.22_PM](/uploads/8216ba32f1ad087797682c6bd88fba4a/Screen_Shot_2016-11-26_at_1.14.22_PM.png)
* The tag's description includes the open and closed issues for that milestone.
![Screen_Shot_2016-11-26_at_1.13.55_PM](/uploads/0380d342bf6d154221259c0b7b0333dc/Screen_Shot_2016-11-26_at_1.13.55_PM.png)
Left todo:
* Add integration specs.
* When I click to create a new tag but give up and click cancel, it should return to `milestone#show` instead of `tags#index`.
* Replace the inline fields with a Tag model. This wasn't done because would demand a big refactor on other parts of the system, for example in `CreateTagService`, and I'd never make a big change like this without creating specs (which the time constraints wouldn't allow me to).
* Even better release notes description formatting.
* The extras (Like grouping by labels).
Closes #24260https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7461Adds horizontal scrolling to network-graph2017-08-31T12:32:57Zusername-removed-293650Adds horizontal scrolling to network-graph## What does this MR do?
Adds horizontal scrolling to network graph
## Are there points in the code the reviewer needs to double check?
- Check if adding horizontal scroll will render the graph on page load as required or push it t...## What does this MR do?
Adds horizontal scrolling to network graph
## Are there points in the code the reviewer needs to double check?
- Check if adding horizontal scroll will render the graph on page load as required or push it to top left corner
## Why was this MR needed?
- To solve https://gitlab.com/gitlab-org/gitlab-ce/issues/24485 by adding horizontal scrolling
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24485https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7440Wiki empty state2017-09-08T11:17:39ZLuke "Jared" BennettWiki empty state## What does this MR do?
Adds the wiki page empty state.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-12_at_18.12.46](/uploads/8ca7...## What does this MR do?
Adds the wiki page empty state.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-12_at_18.12.46](/uploads/8ca73dda6c4cf101cc38333597fd43d2/Screen_Shot_2016-11-12_at_18.12.46.png)
![Screen_Shot_2016-11-12_at_18.12.35](/uploads/474a16a214a905c535ba6d4b6369b4ae/Screen_Shot_2016-11-12_at_18.12.35.png)
![Screen_Shot_2016-11-12_at_18.13.40](/uploads/b7ea8061c320e969629812eadc36d29f/Screen_Shot_2016-11-12_at_18.13.40.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #20855https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7371WIP: DRY up groups empty state2017-09-08T11:17:40ZLuke "Jared" BennettWIP: DRY up groups empty state## What does this MR do?
With recent changes to the empty states, this DRYs up the previously implemented groups empty state
## Are there points in the code the reviewer needs to double check?
:warning: NOTE: This MR branches fr...## What does this MR do?
With recent changes to the empty states, this DRYs up the previously implemented groups empty state
## Are there points in the code the reviewer needs to double check?
:warning: NOTE: This MR branches from !7312 so the target branch is currently set to `20847-getting-started-better-empty-state-for-snippets-view`. !7312 should be merged before this and then the target branch for this MR should be changed to master.
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-10_at_13.06.16](/uploads/2fd304b3411dcdcab57f1ff653e366dc/Screen_Shot_2016-11-10_at_13.06.16.png)
![Screen_Shot_2016-11-09_at_12.12.38](/uploads/f8d150b5fda38514d2bd37447d13253d/Screen_Shot_2016-11-09_at_12.12.38.png)
![Screen_Shot_2016-11-09_at_12.12.50](/uploads/eb8c1abfed04810636c69b8bb350d477/Screen_Shot_2016-11-09_at_12.12.50.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?9.2https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7346Milestones empty state2019-09-19T23:02:44ZLuke "Jared" BennettMilestones empty state## What does this MR do?
Adds milestone empty state to project, group and dashboard.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-0...## What does this MR do?
Adds milestone empty state to project, group and dashboard.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-07_at_22.27.37](/uploads/f2067ef33ea85424169dd256d91d9df5/Screen_Shot_2016-11-07_at_22.27.37.png)
![Screen_Shot_2016-11-07_at_22.27.02](/uploads/291743cd06e89c13e56e88e6c5849841/Screen_Shot_2016-11-07_at_22.27.02.png)
![Screen_Shot_2016-11-07_at_22.31.39](/uploads/30f4474d94b2e5acab0e53684eb9d208/Screen_Shot_2016-11-07_at_22.31.39.png)
![Screen_Shot_2016-11-07_at_22.32.10](/uploads/e675872aa7b18dae143a893b5ff9be52/Screen_Shot_2016-11-07_at_22.32.10.png)
![Screen_Shot_2016-11-07_at_22.54.05](/uploads/fbaf96c034e8f4371774d0e24d61ed65/Screen_Shot_2016-11-07_at_22.54.05.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #20853
Closes #20838https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7344Added activities empty state2017-09-08T11:17:43ZLuke "Jared" BennettAdded activities empty state## What does this MR do?
Adds activity empty state to groups, projects, user profile and dashboard.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen...## What does this MR do?
Adds activity empty state to groups, projects, user profile and dashboard.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-10_at_12.32.44](/uploads/051068f7be858922d85f0dd0ea327eb9/Screen_Shot_2016-11-10_at_12.32.44.png)![Screen_Shot_2016-11-10_at_12.54.14](/uploads/19cd933ff9d4c17e334477d8a8e2a823/Screen_Shot_2016-11-10_at_12.54.14.png)![Screen_Shot_2016-11-10_at_12.31.42](/uploads/0e70c3c7b44988ba8abd26aa0866134e/Screen_Shot_2016-11-10_at_12.31.42.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #20848
Closes #20835https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7337WIP: Resolves "Allow expanding context lines on MR Discussion tab"2017-02-28T14:56:04Zusername-removed-30516WIP: Resolves "Allow expanding context lines on MR Discussion tab"## What does this MR do?
- [x] Part A: expand diff above nested discussion
- [x] Part B: display some context lines below nested discussion and expand diff below (hopefully)
## Are there points in the code the reviewer needs to double ...## What does this MR do?
- [x] Part A: expand diff above nested discussion
- [x] Part B: display some context lines below nested discussion and expand diff below (hopefully)
## Are there points in the code the reviewer needs to double check?
Handling of `plain` via `data-*` and `UploadForm`.
cc @DouweM @smcgivern
## Why was this MR needed?
Assymetric functionality between `Discussion` and `Changes` tabs.
## Screenshots (if relevant)
Before: ![before](/uploads/321701121a3b9cd37a4e8e4131d73f10/before.png)
After (ellipsis): ![after_collapsed](/uploads/fea5f92c85a5c48fea1351785db61afa/after_collapsed.png)
After (expanded): ![after_expanded](/uploads/29460a1aaec250bcc8b63c06265b0eb9/after_expanded.png)
After (middle): ![after_middle](/uploads/d0644e9d28789149d1a8e64990c77612/after_middle.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24138https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7335Update New group view2017-09-08T11:17:44ZLuke "Jared" BennettUpdate New group view## What does this MR do?
Updates the `New Group` page to the design specified in #20827.
EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1575
## Are there points in the code the reviewer needs to double check?
...## What does this MR do?
Updates the `New Group` page to the design specified in #20827.
EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1575
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Part of `Getting Started` meta.
## Screenshots (if relevant)
![Screen_Shot_2016-11-07_at_17.13.00](/uploads/a07716bf4ca726dbedd9d50f8a9c640a/Screen_Shot_2016-11-07_at_17.13.00.png)
![Screen_Shot_2016-11-07_at_17.13.17](/uploads/27f7af275060a7fcd933749b03a93848/Screen_Shot_2016-11-07_at_17.13.17.png)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #20827https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7325WIP: Add table view for CSV files2017-10-01T17:42:50ZRobert SpeicherWIP: Add table view for CSV filesPicked up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3422Picked up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3422Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/7312Snippets empty state2018-10-09T15:34:52ZLuke "Jared" BennettSnippets empty state## What does this MR do?
Adds empty state to project, user and dashboard snippets.
EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1614
## Are there points in the code the reviewer needs to double check?
## ...## What does this MR do?
Adds empty state to project, user and dashboard snippets.
EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1614
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![Screen_Shot_2016-11-10_at_05.26.24](/uploads/c18c6ff90ac95f95fb9a526c28cbbdee/Screen_Shot_2016-11-10_at_05.26.24.png)![Screen_Shot_2016-11-10_at_05.26.54](/uploads/d207b8a9c2c8acca80e1e7a75327d29e/Screen_Shot_2016-11-10_at_05.26.54.png)![Screen_Shot_2016-11-10_at_05.27.37](/uploads/6d9740248e2ed4ae79b374fe29ea783b/Screen_Shot_2016-11-10_at_05.27.37.png)![Screen_Shot_2016-11-10_at_05.26.44](/uploads/c3665efb196da3527ced333aae3ca07b/Screen_Shot_2016-11-10_at_05.26.44.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #20847