GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2017-10-24T23:58:09Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14728Fixed default group sort option2017-10-24T23:58:09ZPhil Hughesme@iamphill.comFixed default group sort option## What does this MR do?
Fixes default group sorting option. Previously it was blank which caused the sort button to have no label.
## What are the relevant issue numbers?
Closes #38808## What does this MR do?
Fixes default group sorting option. Previously it was blank which caused the sort button to have no label.
## What are the relevant issue numbers?
Closes #3880810.1https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14729Fetch the merged branches at once2017-11-03T05:09:44Zusername-removed-423915Fetch the merged branches at once## What does this MR do?
Fetch the merged branches at once, instead of checking it one by one in the view. We don't cache this yet because this would already much improve the performance.
## Are there points in the code the reviewe...## What does this MR do?
Fetch the merged branches at once, instead of checking it one by one in the view. We don't cache this yet because this would already much improve the performance.
## Are there points in the code the reviewer needs to double check?
Previously we could be checking with ~Gitaly, but with this change we would be using `git` command line. Could this kill the filesystem?
## Why was this MR needed?
A naive test against a particularly large repository:
``` ruby
begin
now = Time.now
branches.map{ |b| repository.merged_to_root_ref?(b.name) }
Time.now - now
end # 8.265830782
```
Around 10 times faster:
``` ruby
begin
now = Time.now
repository.merged_branches(branches.map(&:name))
Time.now - now
end # 0.807405397
```
This should make the branches page usable.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
This is a follow up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14678#note_4254801910.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14731WIP: Rewrite the GitHub importer to perform work in parallel and greatly impr...2017-11-13T05:36:31Zyorickpeterse-stagingWIP: Rewrite the GitHub importer to perform work in parallel and greatly improve performance## What does this MR do?
This MR rewrites the GitHub importer from scratch so it's _much_ faster and performs work in parallel. This MR is still a WIP, I'll update the body properly once we get closer to a final state.
## TODO
*...## What does this MR do?
This MR rewrites the GitHub importer from scratch so it's _much_ faster and performs work in parallel. This MR is still a WIP, I'll update the body properly once we get closer to a final state.
## TODO
* [ ] Use a separate class for importing issue comments
* [ ] Import issue comments using a worker (1 job per comment)
* [ ] Issue and comment workers should reschedule themselves in the future if we hit a rate limit, the reschedule time will simply be the reset time of the rate limit (so if our rate limit resets in 10 seconds that means we schedule jobs for 10 seconds in the future)
* [ ] Make the parallel importing schedule a job to check for progress, instead of blocking the thread in a `sleep` call
* [ ] Make sure any stuck importer jobs don't mess with a running GitHub import
* [ ] Import releases
* [ ] Test all the things
* [ ] Add tests for `User.by_any_email`
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)10.1yorickpeterse-stagingyorickpeterse-staginghttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14732Make New-sidebar scrolling behavior like issue sidebar2017-10-06T22:43:03Zusername-removed-1661688Make New-sidebar scrolling behavior like issue sidebar## What does this MR do?
It improves the scrolling to behave like the issue sidebar. See merge request below.
It essentially does the same changes as the merge request below.
## What are the relevant issue numbers?
https://gitlab.c...## What does this MR do?
It improves the scrolling to behave like the issue sidebar. See merge request below.
It essentially does the same changes as the merge request below.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10831
## Why was this MR needed?
Scrolling not nice in iOS
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
@annabeldunstone
@iamphill
~UX ~frontend https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14733Improve pgloader documentation2018-06-04T21:32:43ZStan HuImprove pgloader documentationFixes a typo and revises a few sentences for grammar.
Also add more troubleshooting and sample output.
/cc: @rdavila, @godfat, @lbotFixes a typo and revises a few sentences for grammar.
Also add more troubleshooting and sample output.
/cc: @rdavila, @godfat, @lbot10.1Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14735Removes CommitsList from global namespace2017-10-24T23:58:06ZFilipa Lacerdafilipa@gitlab.comRemoves CommitsList from global namespace## What does this MR do?
Removes CommitsList from global namespace
Fixes some eslint problems
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance g...## What does this MR do?
Removes CommitsList from global namespace
Fixes some eslint problems
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3886910.2Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14737WIP: Try to discard data we don't need immediately when importing2017-10-06T18:55:25Zusername-removed-423915WIP: Try to discard data we don't need immediately when importing## What does this MR do?
Try to discard data we don't need immediately when importing
## Are there points in the code the reviewer needs to double check?
I'll try to check if this could reduce memory footprint
## Why was this MR need...## What does this MR do?
Try to discard data we don't need immediately when importing
## Are there points in the code the reviewer needs to double check?
I'll try to check if this could reduce memory footprint
## Why was this MR needed?
To try use less memory
## Does this MR meet the acceptance criteria?
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
## What are the relevant issue numbers?
Closes #3887310.2username-removed-423915username-removed-423915https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14738Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace2017-10-24T23:58:00ZFilipa Lacerdafilipa@gitlab.comRemove AjaxLoadingSpinner and CreateLabelDropdown from global namespace## What does this MR do?
Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace
## Does this MR meet the acceptance criteria?
- Review
- [x] Has been reviewed by Frontend
- [x] Conform by the [merge request performan...## What does this MR do?
Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace
## Does this MR meet the acceptance criteria?
- Review
- [x] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#3886010.2username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14740Include GitLab full name with username in Slack messages2017-10-24T23:58:00ZStan HuInclude GitLab full name with username in Slack messagesWe used to include the first and last name of the user, but !6624 modified this to include only the username. Let's compromise and add both in the form of `First Last (username)`.
Closes #38865We used to include the first and last name of the user, but !6624 modified this to include only the username. Let's compromise and add both in the form of `First Last (username)`.
Closes #3886510.1Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14742Cleanup data-page attribute after each Karma test2017-10-25T00:07:30Zusername-removed-892863contact@ericeastwood.comCleanup data-page attribute after each Karma test## What does this MR do?
- Cleanup `data-page` attribute after each Karma test to avoid leaking into the next test
## Are there points in the code the reviewer needs to double check?
- Are we okay with moving to consistent `.attr('d...## What does this MR do?
- Cleanup `data-page` attribute after each Karma test to avoid leaking into the next test
## Are there points in the code the reviewer needs to double check?
- Are we okay with moving to consistent `.attr('data-page', ...` for easier Ctrl+F?
## Why was this MR needed?
See https://gitlab.com/gitlab-org/gitlab-ce/issues/38871
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38871https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14743WIP: Add image discussion docs2017-10-25T00:07:33Zusername-removed-408677WIP: Add image discussion docs## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](htt...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38879https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14744WIP: Remove Build code from global namespace2018-11-20T13:04:59ZFilipa Lacerdafilipa@gitlab.comWIP: Remove Build code from global namespace## What does this MR do?
Remove Build code from global namespace
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.co...## What does this MR do?
Remove Build code from global namespace
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Frontend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
#38869Filipa Lacerdafilipa@gitlab.comFilipa Lacerdafilipa@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14747Conflict resolution refactor2017-10-25T00:06:29Zusername-removed-367626Conflict resolution refactor## What does this MR do?
Refactor conflict resolution to contain git ops within Gitlab::Git.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
This prepares the codebase for a Gitaly ...## What does this MR do?
Refactor conflict resolution to contain git ops within Gitlab::Git.
## Are there points in the code the reviewer needs to double check?
No.
## Why was this MR needed?
This prepares the codebase for a Gitaly migration.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitaly/issues/553Jacob Vosmaer (GitLab)Jacob Vosmaer (GitLab)https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14748[Rails 5] Fix db:migrate:reset-mysql and db:migrate:reset-mysql2017-10-25T00:20:16Zusername-removed-86853blackst0ne.ru@gmail.com[Rails 5] Fix db:migrate:reset-mysql and db:migrate:reset-mysql## What does this MR do?
Fixes errors in the `db:migrate:reset-mysql` and `db:migrate:reset-mysql` steps of !12841
1. Fix `db/migrate/20170913131410_environments_project_id_not_null.rb`.
2. Fix `db/migrate/20170707183807_add_group...## What does this MR do?
Fixes errors in the `db:migrate:reset-mysql` and `db:migrate:reset-mysql` steps of !12841
1. Fix `db/migrate/20170913131410_environments_project_id_not_null.rb`.
2. Fix `db/migrate/20170707183807_add_group_id_to_milestones.rb`
3. Fix ActiveRecord deprecation warnings about AR versions.Valery SizovValery Sizovhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14751Issue JWT token with registry:catalog:* scope when requested by GitLab admin2017-10-25T00:07:54Zusername-removed-1672255Issue JWT token with registry:catalog:* scope when requested by GitLab admin## What does this MR do?
Modifies `ContainerRegistryAuthenticationService` to issue a JWT token with registry:catalog:* scope when requested by GitLab admin.
## Are there points in the code the reviewer needs to double check?
Since th...## What does this MR do?
Modifies `ContainerRegistryAuthenticationService` to issue a JWT token with registry:catalog:* scope when requested by GitLab admin.
## Are there points in the code the reviewer needs to double check?
Since this MR touches security aspect of GitLab a detailed review of the change and tests would be appreciated.
## Why was this MR needed?
Currently, GitLab never issues token with registry:catalog:* scope. This scope is needed for browsing the catalog of docker registry. Since docker registry supports only one auth provider at the time, there is no other workaround to browse through registry catalog when using GitLab as auth provider.
Since disclosing all repositories in the registry could be considered a security leak, this scope can be issued only to GitLab admins. (As suggested by @ayufan)
## Screenshots (if relevant)
*(Not relevant)*
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [x] API support added
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #26763
Closes #18392https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14752Don't create fork networks for root projects that are deleted2018-08-02T08:11:29ZBob Van Landuyt :neckbeard:Don't create fork networks for root projects that are deleted
Closes #38905
Closes #38905https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14753WIP: Use Gitaly's RepositoryService.HasLocalBranches RPC2018-12-19T12:27:11Zusername-removed-367626WIP: Use Gitaly's RepositoryService.HasLocalBranches RPC## What does this MR do?
Use Gitaly's RepositoryService.HasLocalBranches RPC
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitaly/issues/630
## Does ...## What does this MR do?
Use Gitaly's RepositoryService.HasLocalBranches RPC
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitaly/issues/630
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitaly/issues/63010.1James RamsayJames Ramsayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14754Resolve "hello world"2018-10-09T21:31:56ZVictor WuResolve "hello world"## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](htt...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38911https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14755Resolve "hello3"2018-10-09T21:31:47ZVictor WuResolve "hello3"## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](htt...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38913https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14756Resolve "Yet another issue"2018-10-09T21:31:39ZVictor WuResolve "Yet another issue"## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](htt...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #38915