GitLab FOSS merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests2019-09-20T02:35:07Zhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11845Allow pulling container images using personal access tokens2019-09-20T02:35:07ZZeger-Jan van de Wegzegerjan@gitlab.comAllow pulling container images using personal access tokens## Are there points in the code the reviewer needs to double check?
This touches both authentication and authorization, so please double check the security side of it all.
## Does this MR meet the acceptance criteria?
- [x] [Changelog...## Are there points in the code the reviewer needs to double check?
This touches both authentication and authorization, so please double check the security side of it all.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [X] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Check if this needs additional changes to support
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
## What are the relevant issue numbers?
Fixes gitlab-org/gitlab-ce#192199.3Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11398Fix Git-over-HTTP rejections2019-09-20T02:33:50Zusername-removed-1144264Fix Git-over-HTTP rejections## What does this MR do?
It fixes the HTTP status code and rendered error message when rejecting Git access to public projects (it is always 404 when it should sometimes be 401 or a different error message). See https://gitlab.com/gitla...## What does this MR do?
It fixes the HTTP status code and rendered error message when rejecting Git access to public projects (it is always 404 when it should sometimes be 401 or a different error message). See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11259#note_29331791 for when this was discovered.
* Pushes authorization logic out of GitHttpController and into GitAccess
* Surfaces GitAccess error messages directly, instead of always “Access denied”. We already do this in EE
* Do not short-circuit GitAccess usage, e.g. the “Project not found” error
* Makes HTTP status codes more accurate
* Adds more tests to ensure Git-over-HTTP behaves as desired
* Tests Git-over-HTTP error messages as well as status codes
* Fixes some broken tests
## Why was this MR needed?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11259#note_29331791
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)9.3Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11841Maintain notes avatar at smaller breakpoint2019-09-20T02:32:18Zusername-removed-892863contact@ericeastwood.comMaintain notes avatar at smaller breakpoint## What does this MR do?
- Maintain notes avatar at smaller breakpoint
. | Screenshot
--- | ---
Before| ![](http://imgur.com/J2upMgJ.gif)
After| ![](http://imgur.com/15Aq5L9.gif)
## Are there points in the code the reviewer needs to ...## What does this MR do?
- Maintain notes avatar at smaller breakpoint
. | Screenshot
--- | ---
Before| ![](http://imgur.com/J2upMgJ.gif)
After| ![](http://imgur.com/15Aq5L9.gif)
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
- Notes info is lost early on when we have enough space to still show things
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #329859.3Annabel GrayAnnabel Grayhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11682Introduce source to pipeline entity2019-09-20T02:30:32ZKamil TrzcińśkiIntroduce source to pipeline entity## What does this MR do?
Add a source to Pipeline to easier see for what reason pipeline was created.
## What are the relevant issue numbers?
Related to #16556## What does this MR do?
Add a source to Pipeline to easier see for what reason pipeline was created.
## What are the relevant issue numbers?
Related to #165569.3Grzegorz BizonGrzegorz Bizonhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10018Allow to create new branch and empty WIP merge request from issue page2019-09-20T02:27:17Zusername-removed-408881Allow to create new branch and empty WIP merge request from issue page## What does this MR do?
Replaces the "New Branch" button on the issue page with a dropdown with options to create a merge request or just a branch for the issue.
## Are there points in the code the reviewer needs to double check?
...## What does this MR do?
Replaces the "New Branch" button on the issue page with a dropdown with options to create a merge request or just a branch for the issue.
## Are there points in the code the reviewer needs to double check?
See if I used the best naming for class, variables, etc.
## Why was this MR needed?
To implement !28558
## Screenshots
**Before**
![Screen_Shot_2017-04-26_at_11.55.13_PM](/uploads/c7108d2c991a9b2d35122602b985dfb6/Screen_Shot_2017-04-26_at_11.55.13_PM.png)
**After**
![Screen_Shot_2017-04-26_at_11.55.32_PM](/uploads/3ef2112362406ea77a6c4bc6175456e6/Screen_Shot_2017-04-26_at_11.55.32_PM.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Implements #285589.2https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/738Support editing target branch of merge request2019-09-20T02:25:19ZStan HuSupport editing target branch of merge request### What does this MR do?
This MR makes it possible to edit the target branch of a merge request and adds a system note when this happens.
### Why was this MR needed?
Because lots of people requested this feature. :)
### Scre...### What does this MR do?
This MR makes it possible to edit the target branch of a merge request and adds a system note when this happens.
### Why was this MR needed?
Because lots of people requested this feature. :)
### Screenshots
**Edit MR page**
![image](https://gitlab.com/gitlab-org/gitlab-ce/uploads/9b3d405bf7b5f945e35bae3534c2b67b/image.png)
**New MR page**
![image](https://gitlab.com/gitlab-org/gitlab-ce/uploads/3657a2a9efad6d10e8470637d1166bdb/image.png)
**System note**
![image](https://gitlab.com/gitlab-org/gitlab-ce/uploads/cc8066f3d3bdf09c0cce27193210567d/image.png)
### What are the relevant issue numbers?
* Closes https://github.com/gitlabhq/gitlabhq/issues/7105
* See: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/130!
https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11651Initial implementation for real time job view2019-09-20T02:25:16ZZeger-Jan van de Wegzegerjan@gitlab.comInitial implementation for real time job view- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
I think its best to merge this first, and than do the frontend ...- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
I think its best to merge this first, and than do the frontend and not try and squeeze it into 1 merge request.
/cc @filipa @ayufan9.3Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8597Copying a rendered issue/comment will paste into GFM textareas as actual GFM2019-09-20T02:15:11ZDouwe MaanCopying a rendered issue/comment will paste into GFM textareas as actual GFM![copyable](/uploads/b352db93abf143a300a994fb1203e538/copyable.gif)
![copyable2](/uploads/5d3bd3781a50778481a048f86cf6b516/copyable2.gif)
Tested in Chrome, Safari and Firefox. Works when copy-pasting and when using the `r` shortcut...![copyable](/uploads/b352db93abf143a300a994fb1203e538/copyable.gif)
![copyable2](/uploads/5d3bd3781a50778481a048f86cf6b516/copyable2.gif)
Tested in Chrome, Safari and Firefox. Works when copy-pasting and when using the `r` shortcut to reply to selected text.
@rspeicher Can you review the Ruby?
@jschatz1 Can you review the JS?
/cc @smcgivern8.17username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11374Add users endpoint to frontend API class2019-09-20T02:13:04ZWinnie HellmannAdd users endpoint to frontend API class## What does this MR do?
Add method to access `/api/v4/users` endpoint from frontend.
## Why was this MR needed?
Frontend needs a way to access user display name and avatar for a given user name.
## What are the relevant issu...## What does this MR do?
Add method to access `/api/v4/users` endpoint from frontend.
## Why was this MR needed?
Frontend needs a way to access user display name and avatar for a given user name.
## What are the relevant issue numbers?
#304689.3username-removed-408677username-removed-408677https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11206Handle Promise rejections in RecentSearchesService spec2019-09-20T02:10:19ZWinnie HellmannHandle Promise rejections in RecentSearchesService spec## Why was this MR needed?
Because this is in the Karma output:
```
ERROR: 'Unhandled promise rejection', Error{name: 'RecentSearchesServiceError', message: 'Recent Searches Service is unavailable'}
```## Why was this MR needed?
Because this is in the Karma output:
```
ERROR: 'Unhandled promise rejection', Error{name: 'RecentSearchesServiceError', message: 'Recent Searches Service is unavailable'}
```username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/13021Detect and keep track of flaky specs2019-09-20T02:08:36Zusername-removed-128633Detect and keep track of flaky specsEE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2626
## What does this MR do?
This detects flaky specs by checking if a spec that passes had passed after more than 1 attempt.
This doesn't take in account a spec that fail...EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2626
## What does this MR do?
This detects flaky specs by checking if a spec that passes had passed after more than 1 attempt.
This doesn't take in account a spec that fails in a first job, and the pass in a job retry, as this would need a more complex logic.
Each RSpec job generates a report (similarly to what Knapsack does) and then all the reports are merged into a single one and uploaded to an S3 bucket (similarly to what Knapsack does). New flaky specs (if any) are also printed at the end of each job.
I've build upon what we already had:
- `rspec-retry`
- `scripts/sync-reports`
- https://github.com/foraker/rspec_profiling/blob/master/lib/rspec_profiling/ as in inspiration for `spec/support/rspec_flaky`
Following is an example of the report generated:
```json
{
"d1371e00c3b1abe1a4c1e5cc64c076d0": {
"example_id": "./spec/models/repository_spec.rb[1:77:1:1]",
"file": "./spec/models/repository_spec.rb",
"line": 1806,
"file_mtime_when_first_flaky": "2017-07-24 08:18:47 +0000",
"description": "Repository#commit_count_for_ref with a non-existing repository returns 0",
"first_flaky_at": "2017-07-24 12:12:31 +0000",
"last_flaky_at": "2017-07-24 12:12:31 +0000",
"last_attempts_count": 2,
"flaky_reports": 1,
"last_flaky_job": "https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/42"
},
"ad6ab3504d10ca04aebd8a51970a7879": {
"example_id": "./spec/features/boards/modal_filter_spec.rb[1:4:1]",
"file": "./spec/features/boards/modal_filter_spec.rb",
"line": 84,
"file_mtime_when_first_flaky": "2017-07-24 08:18:47 +0000",
"description": "Issue Boards add issue modal filtering author filters by selected user",
"first_flaky_at": "2017-07-24 12:13:56 +0000",
"last_flaky_at": "2017-07-24 12:13:56 +0000",
"last_attempts_count": 2,
"flaky_reports": 1,
"last_flaky_job": "https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/42"
},
"5c9f7f8936916cd975561649432cd18d": {
"example_id": "./spec/features/variables_spec.rb[1:6]",
"file": "./spec/features/variables_spec.rb",
"line": 83,
"file_mtime_when_first_flaky": "2017-07-24 08:18:47 +0000",
"description": "Project variables deletes variable",
"first_flaky_at": "2017-07-24 12:16:12 +0000",
"last_flaky_at": "2017-07-24 12:16:12 +0000",
"last_attempts_count": 2,
"flaky_reports": 1,
"last_flaky_job": "https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/42"
}
}
```
## Are there points in the code the reviewer needs to double check?
For now, we only keep track of the flaky specs, we don't:
- remove not longer flaky specs (probably based on last occurence)
- remove flaky specs that have been modified (based on the file mtime and/or example description/ID)
- fail a pipeline if a commit introduces a new flaky spec: for now the job is allowed to fail as we'll need to build a comprehensive list of flaky specs before not allowing this job to fail
These can be next steps (to be done in other MRs).
## Why was this MR needed?
Because flaky specs are a productivity killer so we should detect, retry, and ignore them when appropriate.
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
## What are the relevant issue numbers?
Related to #32308.10.0username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11222Fix transient job failures relating to "unhandled Promise rejection" in issue...2019-09-20T02:01:58Zusername-removed-636429Fix transient job failures relating to "unhandled Promise rejection" in issue boards## What does this MR do?
Adds proper error handling to failed AJAX requests
## Are there points in the code the reviewer needs to double check?
all tests should pass
## Why was this MR needed?
Changes in !9846 now block AJAX request...## What does this MR do?
Adds proper error handling to failed AJAX requests
## Are there points in the code the reviewer needs to double check?
all tests should pass
## Why was this MR needed?
Changes in !9846 now block AJAX requests generated by javascript after an RSpec test is completed waiting for already-pending requests to finish, it would catch the errors these failing requests where they previously would have been ignored.
## Screenshots (if relevant)
n/a
## Does this MR meet the acceptance criteria?
- ~~[ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary~~
- ~~[ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~[ ] API support added~~
- Tests
- ~~[ ] Added for this feature/bug~~
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #320309.2username-removed-636429username-removed-636429https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11177Prevent vue.esm.js from being bundled into the primary JS bundle2019-09-20T02:00:48Zusername-removed-636429Prevent vue.esm.js from being bundled into the primary JS bundle## What does this MR do?
exports sidebar/event_hub functions onto `window.emitSidebarEvent` to bypass including the entire Vue library in places where it shouldn't be included.
## Are there points in the code the reviewer needs to doub...## What does this MR do?
exports sidebar/event_hub functions onto `window.emitSidebarEvent` to bypass including the entire Vue library in places where it shouldn't be included.
## Are there points in the code the reviewer needs to double check?
the users_select.js dropdown should continue to work as it did before (test coverage should validate this)
## Why was this MR needed?
when vue.esm.js gets included in unexpected places it ends up needlessly inflating our bundle sizes and adding "Vue is running in development mode" garbage to our rspec logs.
## Screenshots (if relevant)
n/a
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
closes #319669.2username-removed-408677username-removed-408677https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/11115Retried in database2019-09-20T02:00:31ZKamil TrzcińśkiRetried in database## What does this MR do?
This stores latest in the database. We update in transaction information about whether the build is latest. We don't need an index on that column, as we aim for 99% builds to be latest (retry is usually an excep...## What does this MR do?
This stores latest in the database. We update in transaction information about whether the build is latest. We don't need an index on that column, as we aim for 99% builds to be latest (retry is usually an exception).
This greatly simplifies and fastens a lot of SQL queries and job-stage-related views.
Supersedes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10721 as we also need to run MySQL tests.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #257379.2Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10936Fix ordering of commits in the network graph.2019-09-20T01:58:38Zusername-removed-407765Fix ordering of commits in the network graph.## What does this MR do?
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1
- Prior to this upgrade, the default sort order for commits returned by
`Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the
...## What does this MR do?
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1
- Prior to this upgrade, the default sort order for commits returned by
`Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the
graph relied on.
- While upgrading `rugged`, the MR also changed this default to
`Rugged::SORT_NONE`, which broke commit ordering in the graph.
- This MR adds an option to `Gitlab::Git::Repository#find_commits` to sort
by date, and changes the graph builder `Network::Graph` so it explictly
requests the `:date` sort order
## What are the relevant issue numbers?
Closes #30973
<!--- start task list -->
## Tasks
- [X] Investigation
- [X] Implementation
- [ ] Tests
- [X] Added
- [X] Add more tests for `Network::Graph`
- [X] Compare results of this fix v/s 9.0 and confirm that there are no changes
- [ ] Passing
- [X] Meta
- [X] CHANGELOG entry created
- [X] ~~API support added~~
- [X] Branch has no merge conflicts with `master`
- [X] Squashed related commits together
- [X] ~~Added screenshots~~
- [X] Check for clean merge with EE
- [X] ~~Documentation added/updated~~
- [ ] Review
- [ ] Reviewer
- [ ] Maintainer
- [ ] Wait for merge
<!--- end task list -->9.1Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10777Real time pipeline show action2019-09-20T01:57:59ZZeger-Jan van de Wegzegerjan@gitlab.comReal time pipeline show actionCloses gitlab-org/gitlab-ce#25226Closes gitlab-org/gitlab-ce#252269.2Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10760Add instant comments support2019-09-20T01:55:35ZkushalpandyaAdd instant comments support### Related EE Merge Request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1823
## What does this MR do?
Adds support for instantly creating, editing and removing comments from Issues and MRs.
## Why was this MR needed?...### Related EE Merge Request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1823
## What does this MR do?
Adds support for instantly creating, editing and removing comments from Issues and MRs.
## Why was this MR needed?
Currently comments are updated only after network response is received, having comments posted instantly while network communication is happening in the background gives user a perception of better performance.
## Screenshots
#### Create Comment
![Create](/uploads/bb70a0a2f7542141d3adc1ca6f814734/Create.gif)
#### Update Comment
![Update](/uploads/052ac7cfcb5033c06dbc19bd9c3a3e9a/Update.gif)
#### Create Discussion
![Create_Discussion](/uploads/9a04892969af7e30909785cfdc8a5318/Create_Discussion.gif)
#### Update Discussion Comment
![Update_Discussion](/uploads/f0ed7fd80853cde591d8914850e97710/Update_Discussion.gif)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- ~~[ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~[ ] API support added~~
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #276149.2Filipa Lacerdafilipa@gitlab.comFilipa Lacerdafilipa@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10754Reorg CE Docs landing page2019-09-20T01:45:28Zusername-removed-236961Reorg CE Docs landing pageSee the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html
## What does this MR do?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/31069
Reorg CE Docs landing page in more logical t...See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html
## What does this MR do?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/31069
Reorg CE Docs landing page in more logical topics.
### Screenshot
- [1st version](/uploads/7e2959bf338a172c40110688c9cd9044/ce-landing-page-0.png)
- [2nd version](/uploads/128b87474aecbeece860fd0b775ce514/ce-landing-page-1.png)
Current version:
![ce-docs-2](/uploads/edb792e5ab10b4b486df2814f98156e2/ce-docs-2.png)
### Thinking this through
In the future, I can picture the headings with FontAwesome icons by their side. Also, we can make the headings [accordions](http://getbootstrap.com/javascript/#collapse-example-accordion) if we want.
Btw, by organizing docs this way it will be clearer to identify what's missing and what needs update.
----
@SeanPackham can you please take a look to check if you want me to go in this direction? Thanks ;) cc/ @axil9.2Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10695Refactoring rake task to import GitHub repositories2019-09-20T01:45:10Zusername-removed-283999douglas@gitlab.comRefactoring rake task to import GitHub repositories## What does this MR do?
- Add client for the GitHub API
- Fix memory leak on GitHub importer
- Fix error when listing pull requests/issues comments for large repositories
- Refactor current rake task to use the new client
## Ne...## What does this MR do?
- Add client for the GitHub API
- Fix memory leak on GitHub importer
- Fix error when listing pull requests/issues comments for large repositories
- Refactor current rake task to use the new client
## Next steps - %"9.2"
- Refactor the GitHub importer to use the new GitHub client
- Remove the `octokit` gem
- Remove old code
## Are there points in the code the reviewer needs to double check?
The `Github::Import` class.
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)9.1username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/10319Merge request widget redesign2019-09-20T01:44:26Zusername-removed-502136Merge request widget redesignEE BRANCH: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1711
Closes #25424, #27950 EE BRANCH: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1711
Closes #25424, #27950 9.2username-removed-502136username-removed-502136