Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
What does this MR do?
- Add Fork/Cancel confirmation to "Replace"/"Delete" buttons (see
blob:show
,blame:show
)
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Previously when needing to fork, clicking on "Replace"/"Delete" would fork immediately. This is inconsistent with what we decided to move to with the "Edit" button that has a verification Fork/Cancel button combo , https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10233
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #30637 (closed)
Merge request reports
Activity
added 1 commit
- dbd1ae37 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
- Resolved by username-removed-892863
- Resolved by username-removed-892863
- Resolved by username-removed-892863
assigned to @MadLittleMods
added 61 commits
-
dbd1ae37...069c54a7 - 59 commits from branch
master
- 40ce3819 - Fix edit button on blame page without repo perms
- ae455195 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
-
dbd1ae37...069c54a7 - 59 commits from branch
added 1 commit
- 4865c442 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
assigned to @DouweM
added 30 commits
-
4865c442...a62ae94d - 29 commits from branch
master
- bc58db60 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
-
4865c442...a62ae94d - 29 commits from branch
added 30 commits
-
4865c442...a62ae94d - 29 commits from branch
master
- bc58db60 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
-
4865c442...a62ae94d - 29 commits from branch
@MadLittleMods Code looks good, just one last discussion to resolve!
assigned to @MadLittleMods
- Resolved by username-removed-892863
added 1 commit
- d571093b - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
assigned to @filipa
- Resolved by username-removed-892863
- Resolved by Filipa Lacerda
Thank you @MadLittleMods. Left just 3 small comments :)
Edited by Filipa Lacerdaassigned to @MadLittleMods
- Resolved by username-removed-892863
added 1 commit
- 1e00c347 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
added 1 commit
- d94885a4 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
assigned to @filipa
- Resolved by username-removed-892863
- Resolved by username-removed-892863
@MadLittleMods I am a little confused. Why did we transform this into a class? Won't a function be enough?
I honestly think a function is all we need
😊 - Resolved by Filipa Lacerda
@fatihacet can you please help me review this? Thanks :)
assigned to @fatihacet
@fatihacet Friendly ping for review
- Resolved by username-removed-892863
- Resolved by username-removed-892863
- Resolved by username-removed-892863
added 441 commits
-
d94885a4...60a6389a - 440 commits from branch
master
- 73982bea - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
-
d94885a4...60a6389a - 440 commits from branch
added 1 commit
- 70a4e469 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
- Resolved by username-removed-892863
- Resolved by username-removed-892863
- Resolved by username-removed-892863
- Resolved by username-removed-892863
@MadLittleMods added some minor comments.
assigned to @MadLittleMods
added 1 commit
- 3e55bb7c - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
assigned to @filipa
added 1 commit
- 36387ce1 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons
- Resolved by username-removed-892863