Skip to content
Snippets Groups Projects

Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

What does this MR do?

  • Add Fork/Cancel confirmation to "Replace"/"Delete" buttons (see blob:show, blame:show)

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Previously when needing to fork, clicking on "Replace"/"Delete" would fork immediately. This is inconsistent with what we decided to move to with the "Edit" button that has a verification Fork/Cancel button combo , https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10233

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #30637 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 61 commits

    • dbd1ae37...069c54a7 - 59 commits from branch master
    • 40ce3819 - Fix edit button on blame page without repo perms
    • ae455195 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • added 1 commit

    • 4865c442 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • added 30 commits

    Compare with previous version

  • added 30 commits

    Compare with previous version

  • @MadLittleMods Code looks good, just one last discussion to resolve!

  • username-removed-892863 marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • added 1 commit

    • d571093b - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • username-removed-892863 resolved all discussions

    resolved all discussions

  • Thank you @MadLittleMods. Left just 3 small comments :)

    Edited by Filipa Lacerda
  • added 1 commit

    • 1e00c347 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • added 1 commit

    • d94885a4 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • Filipa Lacerda
  • @MadLittleMods I am a little confused. Why did we transform this into a class? Won't a function be enough?

    I honestly think a function is all we need 😊

  • Filipa Lacerda
  • @fatihacet can you please help me review this? Thanks :)

  • @fatihacet Friendly ping for review

  • added 441 commits

    Compare with previous version

  • added 1 commit

    • 70a4e469 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • @MadLittleMods added some minor comments.

  • added 1 commit

    • 3e55bb7c - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • added 1 commit

    • 0bebd8ee - 1 commit from branch master

    Compare with previous version

  • added 1 commit

    • 36387ce1 - Add Fork/Cancel confirmation to "Replace"/"Delete" buttons

    Compare with previous version

  • Filipa Lacerda
  • Please register or sign in to reply
    Loading