WIP: Clear "Labels" dropdown search filter after selection
What does this MR do?
This merge request clears the "Labels" dropdown search filter after a selection is made.
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
The current label selection workflow is impeded by having to clear the search filter after a desired label is selected.
Screenshots (if relevant)
Before
After
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #24774 (moved)
Merge request reports
Activity
@ajtorres9 Thanks for contributing to GitLab
. Please mention me (@
) when it's no longer a work in progress.added ~164274 ~874211 frontend labels
Hi @adamniedzielski, I'm not sure if you can help me, but I'm having an issue deciding where to implement an RSpec test for the newly implemented feature.
After searching through the spec files I landed on this one, would this be an appropriate place? Thanks for any help you can provide.@ajtorres9 I'm sorry for a delayed response, and sure I can help you!
As this is a change only in JavaScript it would be awesome to test it on the unit level if possible. Can you take a look at
spec/javascripts/labels_issue_sidebar_spec.js
? It already has some tests that exerciseLabelsSelect
so please check if you can also tests things that you changed.