Skip to content
Snippets Groups Projects

Replace builds_enabled with jobs_enabled in projects API v4

Merged Replace builds_enabled with jobs_enabled in projects API v4
winniehell/gitlab-ce:fix-jobs-enabled-parameter into master
2 unresolved threads
Merged username-removed-14714 requested to merge winniehell/gitlab-ce:fix-jobs-enabled-parameter into master
2 unresolved threads

What does this MR do?

Rename the API v4 parameter for projects from builds_enabled to jobs_enabled.

Why was this MR needed?

Builds were renamed to jobs in %9.0.

What are the relevant issue numbers?

fixes #31012 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-14714 added 1 commit

    added 1 commit

    Compare with previous version

  • username-removed-14714 added 1 commit

    added 1 commit

    Compare with previous version

  • username-removed-14714 resolved all discussions

    resolved all discussions

  • username-removed-14714
    username-removed-14714 @winniehell ·
    Author Contributor

    @zj Thank you for your help! :thumbsup: The fix should be ready now. Could you review please?

  • username-removed-14714 assigned to @zj

    assigned to @zj

  • username-removed-14714 unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg assigned to @winniehell

    assigned to @winniehell

  • username-removed-14714 added 1 commit

    added 1 commit

    Compare with previous version

  • username-removed-14714 added 1 commit

    added 1 commit

    Compare with previous version

  • username-removed-14714 marked as a Work In Progress

    marked as a Work In Progress

  • Zeger-Jan van de Weg approved this merge request

    approved this merge request

  • Zeger-Jan van de Weg unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Zeger-Jan van de Weg resolved all discussions

    resolved all discussions

  • Zeger-Jan van de Weg
    Zeger-Jan van de Weg @zj ·
    Developer

    /cc @godfat

  • Zeger-Jan van de Weg added Next Patch Release ~149423 labels

    added Next Patch Release ~149423 labels

  • Zeger-Jan van de Weg changed milestone to %9.0

    changed milestone to %9.0

  • Zeger-Jan van de Weg assigned to @smcgivern

    assigned to @smcgivern

  • Zeger-Jan van de Weg
  • username-removed-423915
    username-removed-423915 @godfat ·
    Maintainer

    @zj I think this also needs to go in 9.1, is it right? And sorry for the confusion, but I don't think this is urgent and should be blocking releasing, so I'll unlabel Next Patch Release for now.

  • username-removed-423915 removed Next Patch Release label

    removed Next Patch Release label

  • username-removed-443319 resolved all discussions

    resolved all discussions

  • username-removed-443319
    username-removed-443319 @smcgivern ·
    Contributor

    Marking as 9.1. @jameslopez and @twk3 can confirm if we're doing any more 9.0 patches or if the last non-security patch has already been tagged.

  • username-removed-443319 changed milestone to %9.1

    changed milestone to %9.1

  • username-removed-443319 merged

    merged

  • username-removed-443319 mentioned in commit 1b929586

    mentioned in commit 1b929586

  • username-removed-423915
    username-removed-423915 @godfat started a thread on the diff
    • lib/api/projects.rb
    205 206 # CE
    206 207 at_least_one_of_ce =
    207 208 [
    208 :builds_enabled,
    209 :jobs_enabled,
  • James Lopez
    James Lopez @jameslopez ·
    Maintainer

    Just posting the same as I discussed on Slack - We probably won't do more 9.0 patch releases unless there's a security release or something very critical. As the current active release would be 9.1 on the 22nd...

    Edited by James Lopez
  • username-removed-423915
    username-removed-423915 @godfat started a thread on the diff
    • spec/requests/api/projects_spec.rb
    1078 1082
    1079 1083 it 'returns 400 when nothing sent' do
    1080 1084 project_param = {}
    1085
    1081 1086 put api("/projects/#{project.id}", user), project_param
    1087
    1082 1088 expect(response).to have_http_status(400)
    1083 1089 expect(json_response['error']).to match('at least one parameter must be provided')
    1084 1090 end
  • Zeger-Jan van de Weg
    Zeger-Jan van de Weg @zj ·
    Developer

    @godfat This is a bug since 9.0 So I wanted to signal that this should also be picked in 9.0

  • username-removed-423915
    username-removed-423915 @godfat ·
    Maintainer

    Picked into 9-1-stable, will go into 9.1.0-rc6

    @zj I am not sure if we would have 9.0.7, but I'll change the milestone anyway. @jameslopez or @twk3 would decide if we would have it.

  • username-removed-423915 changed milestone to %9.0

    changed milestone to %9.0

  • username-removed-423915
    username-removed-423915 @godfat ·
    Maintainer

    Oh, I saw the comment: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10786#note_27876829

    Not sure if in this case are we removing Pick into Stable ?

  • username-removed-443319 mentioned in commit 6b76909c

    mentioned in commit 6b76909c

  • username-removed-423915
    username-removed-423915 @godfat ·
    Maintainer

    As discussed on Slack, we're not picking this into %9.0 because this is not critical, and we probably won't have another 9.0 release. Setting back to %9.1 in case of confusion that when this patch was in.

    Ref: https://gitlab.slack.com/archives/C0XM5UU6B/p1492768025865084?thread_ts=1492765873.392487&cid=C0XM5UU6B

  • username-removed-423915 changed milestone to %9.1

    changed milestone to %9.1

  • username-removed-14714 mentioned in commit nolith/gitlab-ce@de2c2d9c

    mentioned in commit nolith/gitlab-ce@de2c2d9c

    • Please register or sign in to reply