Skip to content

Refactor Admin::GroupsController#members_update method and add some specs

username-removed-444 requested to merge dz-refactor-admin-group-members into master

What does this MR do?

  1. Use Members::CreateService instead of add_users for Admin::GroupsController#members_update method
  2. Add specs

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

  1. Improve code quality
  2. Show users and error when no users added

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/14709

Merge request reports