Fix notes_on_personal_snippets_spec

What does this MR do?

EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1846

Check for all possible timeago strings that can be rendered in a few minutes.

We cannot rely on just "less than a minute ago", as for whatever reason, we could see delays that update timeago to have a different string. Looks like @stanhu was thinking of a similar fix.

Fixes these failures: https://gitlab.com/gitlab-org/gitlab-ee/builds/15796069

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/31938

mentioned in issue #31938 (closed)

changed milestone to %9.2

@lbennett thanks! ❤️

This still seems vulnerable to very slow runs, to me. Wdyt about just checking that the element exists? We don't show it when a note hasn't been edited, after all. /cc @jarka

assigned to @smcgivern

assigned to @lbennett

@smcgivern Good point!

added 1 commit

• 4c25701d - Just assert the existence of the timeago element

Compare with previous version

assigned to @smcgivern

approved this merge request

enabled an automatic merge when the pipeline for 4c25701d succeeds

merged

mentioned in commit 1d0aa480

mentioned in issue #31934 (closed)

Picked into 9-2-stable, will go into 9.2.0-rc1.

mentioned in commit 3d6086d0