Fix up some notes.js tech debt

What does this MR do?

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1911

Fix up tech debt comments from @jschatz1 in notes.js. The bulk of the fixes here are refactoring double-quotes to single-quotes.

• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10837#note_28757436
• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10837#note_28757905
• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10837#note_28757952
• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10837#note_28758013

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

• Tests
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

added 1 commit

• a32c6b49 - Fix up some notes tech debt

Compare with previous version

assigned to @jschatz1

marked the checklist item All builds are passing as completed

assigned to @fatihacet

@MadLittleMods a minor comment for you.

assigned to @MadLittleMods

resolved all discussions

assigned to @fatihacet

removed assignee

added 1 commit

• e39731e3 - Fix up some notes tech debt

Compare with previous version

assigned to @fatihacet

changed milestone to %9.3

@MadLittleMods conflicts

assigned to @MadLittleMods

added 324 commits

• e39731e3...0a8f3ba4 - 323 commits from branch master
• 639fe056 - Fix up some notes tech debt

Compare with previous version

assigned to @fatihacet

added 183 commits

• 639fe056...e4eec191 - 182 commits from branch master
• abe477d9 - Fix up some notes tech debt

Compare with previous version

@MadLittleMods build failed.

assigned to @MadLittleMods

added 137 commits

• abe477d9...9ba8512c - 136 commits from branch master
• 6b838afb - Fix up some notes tech debt

Compare with previous version

added 137 commits

• abe477d9...6b838afb - 137 commits from branch master

Compare with previous version

added 137 commits

• abe477d9...6b838afb - 137 commits from branch master

Compare with previous version

assigned to @fatihacet

added 232 commits

• 39f9aab4...8e2fefc6 - 231 commits from branch master
• 20bd76da - Fix up some notes tech debt

Compare with previous version

286 commits behind. Rebased on master just to make sure things are still fine.

@fatihacet Ping for merge

EE MR, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1911

approved this merge request

merged

mentioned in commit 60ceffe4

Thanks @MadLittleMods