Document Promise testing best practice

What does this MR do?

Add a section to the frontend guidelines about writing tests with Promises.

mentioned in commit 72e17e5b

added 1 commit

• 72e17e5b - Document Promise testing best practice (!11284 (merged))

Compare with previous version

mentioned in commit bf473374

added 1 commit

• bf473374 - Document Promise testing best practice (!11284 (merged))

Compare with previous version

mentioned in merge request !11206 (merged)

@ClemMakesApps Could you have a look at this please?

unmarked as a Work In Progress

assigned to @ClemMakesApps

Neat! I like this. Looks like for some reason, this failed the ee_compat check, can you create an ee version of this as well? Just to make the ce=>ee merge easier

Also, can you put a note about this in the frontend call so that everyone is aware of this change?

assigned to @winh

Can you also update the MR description?

can you create an ee version of this as well?

Yes, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1885.

However I think, the conflict just happened because your change to the docs wasn't merged into EE yet (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1866/). So I'd say let's way for that and the ee_compat_check should pass.

can you put a note about this in the frontend call

It's on the agenda already.

Can you also update the MR description?

It's updated now though there is not much to say, I think.

---

I'll leave this assigned to me until the CE → EE merge is done.

added blocked label

mentioned in commit cb3f5677

added 460 commits

• bf473374...319cab41 - 459 commits from branch master
• cb3f5677 - Document Promise testing best practice (!11284 (merged))

Compare with previous version

added 460 commits

• bf473374...319cab41 - 459 commits from branch master
• cb3f5677 - Document Promise testing best practice (!11284 (merged))

Compare with previous version

added 460 commits

• bf473374...319cab41 - 459 commits from branch master
• cb3f5677 - Document Promise testing best practice (!11284 (merged))

Compare with previous version

you can now skip running the full CI test suite for docs-only changes by using a branch that starts with docs/ or ends with -docs

sorry, I see now that this MR was opened before that was the case...

removed blocked label

blocked by !11455 (merged) now

added blocked label

mentioned in commit 4950dd97

added 10 commits

• cb3f5677...fb31c6ce - 9 commits from branch master
• 4950dd97 - Document Promise testing best practice (!11284 (merged))

Compare with previous version

removed blocked label

added 10 commits

• cb3f5677...fb31c6ce - 9 commits from branch master
• 4950dd97 - Document Promise testing best practice (!11284 (merged))

Compare with previous version

@ClemMakesApps this is finally passing. Can you have another look?

assigned to @ClemMakesApps

LGTM, Thanks @winh

changed milestone to %9.3

approved this merge request

merged

mentioned in commit 6ca5a989

mentioned in merge request !11503 (closed)

resolved all discussions

mentioned in merge request !11517 (merged)