Creates link to member reusable component
What does this MR do?
Creates link to member reusable component
Back port link to member avatar component from ee and make it reusable across all places where we currently are repeating this piece of code:
- remove the logic of showing the empty approval
- Make it render the user icon if no link to avatar is provided
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please)
What are the relevant issue numbers?
Closes #32156 (closed)
Merge request reports
Activity
@filipa I'm working on this here: https://gitlab.com/gitlab-org/gitlab-ce/issues/31017 -- I'm just working on porting to EE now. Hopefully should have something for final review in a couple hours.
Edited by username-removed-408230Sorry @brycepj totally missed the issue. I need this for 9.3 deliverables. Do you have an ETA?
This is blocking me atm. :(
Edited by Filipa Lacerda@brycepj since this one is super small and only adds the component what do you think of merging this and using it on your MR?
This way none of us would be blocked
@filipa I'm literally fixing the build right now. It should be quick. If you can give it a re-review and it you it's satisfying, you could merge my branch into yours while we wait for MWPS.
The MR is here: https://gitlab.com/gitlab-org/gitlab-ce/issues/31017 -- you already reviewed it quite a bit :)
Closing in favor of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10718
mentioned in merge request !10718 (merged)
mentioned in issue #31958 (closed)