Add users endpoint to frontend API class (!11374) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged Winnie Hellmann requested to merge winh-frontend-api-users into master 7 years ago

All threads resolved!

What does this MR do?

Add method to access /api/v4/users endpoint from frontend.

Why was this MR needed?

Frontend needs a way to access user display name and avatar for a given user name.

What are the relevant issue numbers?

#30468 (closed)

Edited 7 years ago by Winnie Hellmann

Activity

Winnie Hellmann added 2 commits 7 years ago
added 2 commits

dea0949f - Convert frontend Api class to ES6

c83b6537 - Add users endpoint to frontend API class

Compare with previous version
Winnie Hellmann @winh · 7 years ago

Author Developer

@mikegreiling Could you take a look at this?

I need to access /api/v4/users for #30468 (closed) and thought I do some cleanup along the way.
Winnie Hellmann assigned to @mikegreiling 7 years ago

assigned to @mikegreiling
Winnie Hellmann @winh · 7 years ago

Author Developer

Assigning back to me, tests are failing.
Winnie Hellmann unmarked as a Work In Progress 7 years ago

unmarked as a Work In Progress
Winnie Hellmann assigned to @winh 7 years ago

assigned to @winh
Winnie Hellmann mentioned in commit 10696bfd 7 years ago

mentioned in commit 10696bfd
Winnie Hellmann added 3 commits 7 years ago
added 3 commits

202cc313 - Add tests for frontend API class

f38e3719 - Clean up api.js

10696bfd - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Winnie Hellmann mentioned in commit 199b7853 7 years ago

mentioned in commit 199b7853
Winnie Hellmann added 57 commits 7 years ago
added 57 commits

10696bfd...84199f19 - 54 commits from branch master

454867cc - Add tests for frontend API class

1251734e - Clean up api.js

199b7853 - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Toggle commit list
Winnie Hellmann mentioned in commit 16a5bd01 7 years ago

mentioned in commit 16a5bd01
Winnie Hellmann added 17 commits 7 years ago
added 17 commits

199b7853...8b66e42b - 14 commits from branch master

f81aa2fa - Add tests for frontend API class

2c646eb8 - Clean up api.js

16a5bd01 - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Toggle commit list
Winnie Hellmann mentioned in commit 9dff6343 7 years ago

mentioned in commit 9dff6343
Winnie Hellmann added 1 commit 7 years ago
added 1 commit

9dff6343 - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Winnie Hellmann mentioned in commit c449b21b 7 years ago

mentioned in commit c449b21b
Winnie Hellmann mentioned in commit 027946db 7 years ago

mentioned in commit 027946db
Winnie Hellmann mentioned in merge request !11404 (merged) 7 years ago

mentioned in merge request !11404 (merged)
Winnie Hellmann mentioned in commit e4695468 7 years ago

mentioned in commit e4695468
Winnie Hellmann added 28 commits 7 years ago
added 28 commits

9dff6343...bcc5135b - 25 commits from branch master

ac4bc75c - Add tests for frontend API class

22b2dfa0 - Clean up api.js

e4695468 - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Toggle commit list
Winnie Hellmann mentioned in commit a74bad29 7 years ago

mentioned in commit a74bad29
Winnie Hellmann added 61 commits 7 years ago
added 61 commits

e4695468...6a2bcb4b - 58 commits from branch master

48f31aa7 - Add tests for frontend API class

afa03540 - Clean up api.js

a74bad29 - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Toggle commit list
Luke "Jared" Bennett added 1 commit 7 years ago
added 1 commit

147fdf04 - Fix call to Api.buildUrl in groups_select.js

Compare with previous version
Luke "Jared" Bennett added 1 commit 7 years ago
added 1 commit

147fdf04 - Fix call to Api.buildUrl in groups_select.js

Compare with previous version
Winnie Hellmann mentioned in commit 36b33a20 7 years ago

mentioned in commit 36b33a20
Winnie Hellmann @winh · 7 years ago

Author Developer

tests are finally passing agin

@mikegreiling Could you take a look at this?

Edited 7 years ago by Winnie Hellmann
Winnie Hellmann assigned to @mikegreiling 7 years ago

assigned to @mikegreiling
Winnie Hellmann mentioned in commit 7f1797e8 7 years ago

mentioned in commit 7f1797e8
Winnie Hellmann added 6 commits 7 years ago
added 6 commits

147fdf04...9fde881d - 3 commits from branch master

e0ab28de - Add tests for frontend API class

ac95250e - Clean up api.js

7f1797e8 - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version
Toggle commit list
username-removed-636429 @mikegreiling started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by Winnie Hellmann
Last reply by username-removed-636429 7 years ago

Winnie Hellmann assigned to @winh 7 years ago

assigned to @winh

username-removed-636429 @mikegreiling started a thread on the diff 7 years ago

Resolved 7 years ago by Winnie Hellmann

Winnie Hellmann mentioned in issue #32435 (moved) 7 years ago

mentioned in issue #32435 (moved)

Winnie Hellmann mentioned in commit 7 years ago

mentioned in commit 25c3aa5a

Winnie Hellmann added 42 commits 7 years ago

added 42 commits

7f1797e8...319cab41 - 39 commits from branch master
c7278e6b - Add tests for frontend API class
8e85534d - Clean up api.js
25c3aa5a - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version

Toggle commit list

Winnie Hellmann resolved all discussions 7 years ago

resolved all discussions

Winnie Hellmann changed the description 7 years ago

changed the description

Winnie Hellmann @winh · 7 years ago

Author Developer

@mikegreiling looks goods to you now?

Winnie Hellmann assigned to @mikegreiling 7 years ago

assigned to @mikegreiling

Winnie Hellmann @winh · 7 years ago

Author Developer

Resolved 7 years ago by Winnie Hellmann

blocked by !11455 (merged)

Winnie Hellmann added label 7 years ago

added blocked label

Winnie Hellmann mentioned in commit 7 years ago

mentioned in commit b137b8fe

Winnie Hellmann removed label 7 years ago

removed blocked label

Winnie Hellmann resolved all discussions 7 years ago

resolved all discussions

Winnie Hellmann added 12 commits 7 years ago

added 12 commits

25c3aa5a...fb31c6ce - 9 commits from branch master
38898b82 - Add tests for frontend API class
1e262c71 - Clean up api.js
b137b8fe - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version

Toggle commit list

username-removed-636429 @mikegreiling started a thread on the diff 7 years ago

Resolved 7 years ago by Winnie Hellmann

username-removed-636429 approved this merge request 7 years ago

approved this merge request

username-removed-636429 @mikegreiling · 7 years ago

Maintainer

This LGTM

@ClemMakesApps can you merge this?

username-removed-636429 assigned to @ClemMakesApps 7 years ago

assigned to @ClemMakesApps

Winnie Hellmann resolved all discussions 7 years ago

resolved all discussions

Winnie Hellmann mentioned in issue #32488 (moved) 7 years ago

mentioned in issue #32488 (moved)

Winnie Hellmann resolved all discussions 7 years ago

resolved all discussions

username-removed-408677 @ClemMakesApps started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by Winnie Hellmann

username-removed-408677 @ClemMakesApps started a thread on an old version of the diff 7 years ago

Resolved 7 years ago by username-removed-636429

username-removed-408677 @ClemMakesApps · 7 years ago

Maintainer

Just a few comments @winh

username-removed-408677 assigned to @winh 7 years ago

assigned to @winh

Winnie Hellmann resolved all discussions 7 years ago

resolved all discussions

Winnie Hellmann mentioned in commit 7 years ago

mentioned in commit c45c74fd

Winnie Hellmann added 3 commits 7 years ago

added 3 commits

16e972a6 - Add tests for frontend API class
7fb99697 - Clean up api.js
c45c74fd - Add users endpoint to frontend API class (!11374 (merged))

Compare with previous version

Winnie Hellmann assigned to @ClemMakesApps 7 years ago

assigned to @ClemMakesApps

username-removed-408677 @ClemMakesApps · 7 years ago

Maintainer

@mikegreiling can you review?

username-removed-408677 assigned to @mikegreiling 7 years ago

assigned to @mikegreiling

username-removed-636429 @mikegreiling · 7 years ago

Maintainer

This looks good to me... @winh you can ignore the object spread comment, just an alternative syntax to consider in the future. no need to make yet another round of changes. when it's compiled, it gets turned into Object.assign by babel anyway.

@ClemMakesApps can you merge this?

username-removed-636429 resolved all discussions 7 years ago

resolved all discussions

username-removed-636429 assigned to @ClemMakesApps 7 years ago

assigned to @ClemMakesApps

username-removed-408677 @ClemMakesApps · 7 years ago

Maintainer

LGTM, Thanks @winh!

username-removed-636429 approved this merge request 7 years ago

approved this merge request

username-removed-408677 merged 7 years ago

merged

username-removed-408677 mentioned in commit 7 years ago

mentioned in commit 9d2d1042

Winnie Hellmann mentioned in merge request !11402 (merged) 7 years ago

mentioned in merge request !11402 (merged)

Felipe Artur mentioned in issue gitlab#9926 5 years ago

mentioned in issue gitlab#9926

Felipe Artur mentioned in issue gitlab#9941 5 years ago

mentioned in issue gitlab#9941

Please register or sign in to reply