Skip to content

Enable STARTTLS on Gitlab::LDAP::Adapter

username-removed-35497 requested to merge (removed):enable_starttls_ldap_adapter into master

Net::LDAP (=0.3.1) supports encryption method 'STARTTLS', but Gitlab::LDAP::Adapter doesn't use it. This causes "Access denied for your LDAP account." on LDAP Signin when LDAP server requires STARTTLS.

This MR fixes Gitlab::LDAP::Adapter can handle both 'ssl' and 'tls' on ldap=>method in gitlab.yml.

For reference, see my slapd.log. before: https://gitlab.com/snippets/1273, after: https://gitlab.com/snippets/1274

Merge request reports