Remove readme project_view option
Fixes issue introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11191.
Not caught earlier because the 'Readme' project view can no longer be selected in Profile Settings > Preferences, but there may still be User records with this value for project_view.
Merge request reports
Activity
assigned to @dzaporozhets
@rspeicher I have no idea! We should have done that at time of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9744.
@dzaporozhets Since you merged that, do you remember why we didn't? We should probably do so right now, and forget about this MR.
@rspeicher @dzaporozhets There's a lot of discussion in https://gitlab.com/gitlab-org/gitlab-ce/issues/27882, and some recent discussion in https://gitlab.com/gitlab-org/gitlab-ce/issues/30140#note_27454336. I personally wouldn't be opposed to restoring the "Readme" option.
@DouweM @rspeicher after https://gitlab.com/gitlab-org/gitlab-ce/blob/daf9ec6cd1f88e7462cae9dc68eda2dcf793cecf/db/post_migrate/20170406142253_migrate_user_project_view.rb there should be no users left with README option enabled.
@dzaporozhets Ah! Any reason why we didn't also remove that view?
-
@DouweM probably just forgot. Can you make it happen?
@dzaporozhets Sure
assigned to @DouweM
@dzaporozhets Actually, I'll hold off on that. Did you see the discussion in https://gitlab.com/gitlab-org/gitlab-ce/issues/27882 and https://gitlab.com/gitlab-org/gitlab-ce/issues/30140#note_27454336? I personally wouldn't be opposed to restoring the "Readme" option.
assigned to @dzaporozhets
-
@DouweM ok lets leave it for now
assigned to @DouweM
@dzaporozhets Should I also re-add the option to the form?
-
@DouweM we are not bringing feature back so I believe there is no need to spend time on it right now
@dzaporozhets Okay, so then should we merge this fix, or remove the view? :)
-
@DouweM I would say remove the view since it is not used by our code and is considered as "dead code". If ever we consider bringing README back - we just write new or copy-paste old code.
assigned to @dzaporozhets
added 173 commits
-
6889bb04...01a7f333 - 172 commits from branch
master - 34964762 - Remove readme project_view option
-
6889bb04...01a7f333 - 172 commits from branch
enabled an automatic merge when the pipeline for 34964762 succeeds
mentioned in commit dda66953
mentioned in issue #30140 (moved)
