Get rid of pluck in app/services/members/authorized_destroy_service.rb

What does this MR do?

Get rid of pluck in app/services/members/authorized_destroy_service.rb.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32372

@yorickpeterse This is low-priority issue, take a look if you have time.

I used this hack from MySQL documentation. Maybe you have some better suggestion.

assigned to @yorickpeterse

Alternative solutions comes to my mind:

• Not to use IssueFinder as we don't need issue_assignees there. So we could use query like issue.joins(project: :group).where(group_id: ...)
• Use database type condition to perform "normal" SQL query for PostgreSQL

added 1 commit

• 728e7eae - Get rid of pluck in app/services/members/authorized_destroy_service.rb

Compare with previous version

@yorickpeterse OK, I just picked the first alternative solution as it's almost the same you did in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11426

changed milestone to %9.2

added ~149423 database ~18308 labels

assigned to @vsizov

resolved all discussions

resolved all discussions

added 1 commit

• 63da987f - Get rid of pluck in app/services/members/authorized_destroy_service.rb

Compare with previous version

assigned to @yorickpeterse

@selfup @timothyandrew This solves a regression that will otherwise be introduced in 9.2.0. Could you pick this into 9-2-stable and make sure it's released in 9.2.0 as well? Thanks!

approved this merge request

merged

mentioned in commit daf9ec6c

marked the checklist item Changelog entry added, if necessary as completed

marked the checklist item All builds are passing as completed

marked the checklist item Conform by the merge request performance guides as completed

marked the checklist item Conform by the style guides as completed

marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

marked the checklist item Squashed related commits together as completed

Labeling this MR with regression (I'm assuming that this fix is related to the multiple assignees feature introduced in %9.2). This makes it easier for us to prioritize fixes to pick into the stable branches.

/cc @selfup

added regression label

Picked into 9-2-stable, will go in 9-2-0-rc7

mentioned in commit f0caffe9