Skip to content
Snippets Groups Projects

Fix redirects modifying the host

Merged username-removed-1144264 requested to merge fix-issue-32506 into master
All threads resolved!

What does this MR do?

This MR ensures that the redirect location is correctly constructed when redirecting from a URL in which the old path is a substring in the host.

Example of the bug

  • Modify group with path lab to laboratory
  • Visit https://gitlab.com/lab
  • Get redirected to https://gitlaboratory.com/gitlab instead of https://gitlab.com/laboratory

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #32506

Edited by username-removed-1144264

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @mkozono

  • username-removed-1144264 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 49697bc8 - Refactor to more robust implementation

    Compare with previous version

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan mentioned in commit 5d5e6954

    mentioned in commit 5d5e6954

  • merged

  • Picked into 9-2-stable will go into 9-2 RC7

  • Douwe Maan mentioned in commit ee712af7

    mentioned in commit ee712af7

  • Please register or sign in to reply
    Loading