Show current user immediately in issuable filters

What does this MR do?

Immediately displays the current user in issuable filter dropdowns for author and assignee.

Why was this MR needed?

Now the current user can be selected before the Ajax call for autocompletion is finished.

Screenshots

Before

current-user

After

current-user

What are the relevant issue numbers?

closes #22921 (closed)

failing test: https://gitlab.com/gitlab-org/gitlab-ce/builds/16937816

added Deliverable ~874211 frontend ~14281 ~13921 search labels

changed milestone to %9.3

added 263 commits

• 96c8ca0f...e20eb712 - 260 commits from branch master
• f3e5fea3 - Always show current user in filters
• a9fff6f0 - Add onLoadingFinished callback to Droplab AjaxFilter
• 54cc4ced - Hide current user from dropdown when Ajax call finishes

Compare with previous version

changed title from WIP: Always show current user in filters to WIP: Show current user immediately in issuable filters

changed the description

changed the description

resolved all discussions

@cperessini Some tests are still missing but implementation should be finished in case you want to have a look already.

https://gitlab.com/gitlab-org/gitlab-ce/issues/22921#note_30371332 (hiding No assignee when something is typed that doesn't match none) will be done in a separate merge request.

A feature test still needs to be written.

resolved all discussions

added 4 commits

• 0180a83a - Add failing test for #22921 (closed)
• 9fa4431f - Show current user immediately in issuable filters (!11630 (merged))
• 409546c6 - Add onLoadingFinished callback to Droplab AjaxFilter
• 1d69705e - Hide current user from dropdown when Ajax call finishes

Compare with previous version

changed the description

@ClemMakesApps Can you review please?

unmarked as a Work In Progress

assigned to @ClemMakesApps

@winh just tested it, works great!

One question, did the spinner use to be left aligned before? I think it should be centered, but I can't remember what it was like before.

did the spinner use to be left aligned before?

@cperessini I don't remember changing anything related to it. But I can fix that in a separate merge request!

mentioned in issue #33137 (closed)

@iamphill can you please review since Clement is away and I will be next week?

assigned to @iamphill

assigned to @winh

resolved all discussions

@iamphill Thank you for the review, I have resolved your comments. Can you have another look please?

assigned to @iamphill

added 223 commits

• 1d69705e...228926da - 214 commits from branch master
• a1f31c90 - Add failing test for #22921 (closed)
• bfa06518 - Add user_avatar_without_link to AvatarsHelper
• 7616caba - Add option to override avatar URL to AvatarsHelper
• ef5ce1f6 - Allow lazy loading of image src in AvatarsHelper
• 7dd2e3bc - Use partial for issuable user filter dropdown items
• c34146c8 - Show current user immediately in issuable filters (!11630 (merged))
• f43b4363 - Add onLoadingFinished callback to Droplab AjaxFilter
• 47ba524a - Hide current user from dropdown when Ajax call finishes
• dae052ef - Ignore hidden elements in Droplab keyboard navigation

Compare with previous version

resolved all discussions

assigned to @winh

added 5 commits

• 3754eb74 - Use partial for issuable user filter dropdown items
• a5f15bc3 - Show current user immediately in issuable filters (!11630 (merged))
• 07d7f0b1 - Add onLoadingFinished callback to Droplab AjaxFilter
• a080da86 - Hide current user from dropdown when Ajax call finishes
• c79a806a - Ignore hidden elements in Droplab keyboard navigation

Compare with previous version

resolved all discussions

@iamphill Comments resolved and pipeline passed.

assigned to @iamphill

approved this merge request

merged

mentioned in commit 15af4d56

mentioned in issue #34013 (moved)