Skip to content

Fix Counter Cache not being disabled for acts-on-taggable

Kamil Trzcińśki requested to merge fix-counter-cache-for-acts-as-taggable into master

What does this MR do?

Metrics forces class loading, and thus it forces load of ActsOnTaggable before defining a default configuration.

The problem is ordering of operations. 8_metrics.rb should be initialized after acts_on_taggable.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/30582 https://gitlab.com/gitlab-org/gitlab-ce/issues/32729

Merge request reports