Skip to content

Fix improperly skipped backups of wikis

username-removed-1144264 requested to merge mk-fix-wiki-backup into master

What does this MR do?

Ensures that non-empty repos are backed up.

Are there points in the code the reviewer needs to double check?

This will expire the exists? cache value for every project and wiki. I don't expect that to be a problem, but if it might be, we could limit this to wikis since that's the known issue.

Why was this MR needed?

In issue https://gitlab.com/gitlab-org/gitlab-ce/issues/28854, some wiki repos are skipped during backup, due to stale cache. I plan to properly expire the cache where necessary in another MR, but this is an immediate fix for a customer pain point, and it makes the backup process more robust, which I believe is worth it, regardless of proper cache expiration.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes #28854 (closed)

Edited by username-removed-1144264

Merge request reports