WIP: Remove GPG status loading indicator if no Ajax request is made

What does this MR do?

Remove the loading indicator from GPG status badges until https://gitlab.com/gitlab-org/gitlab-ce/issues/36046 has been implemented.

Screenshots

Before	After

What are the relevant issue numbers?

fixes #35699 (closed)

added 130 commits

• de14a7cb...03b816f3 - 129 commits from branch master
• f54a1d61 - Hide loading spinner for missing GPG status on repository page

Compare with previous version

changed title from WIP: Resolve GPG status on repository page to WIP: Remove GPG status loading indicator from repository page

changed the description

@iamphill could you please review?

assigned to @iamphill

I don't really understand why we aren't solving the problem straight away? Seems like a massive opportunity we are missing. Shouldn't be that difficult to plug-in a new endpoint to return this data right?

@iamphill I'd rather have this regression fixed earlier and then take enough time to get it back in well tested. There is currently no test for the endpoint (https://gitlab.com/gitlab-org/gitlab-ce/issues/36047) and for me it wasn't straight forward to write one. My request for help in Slack is still unanswered.

Having the missing controller test in place would also allow us to create a dynamic fixture for the JSON response.

@winh I'd also rather have it fixed & in my eyes the regression is the badge not displaying. So hiding it isn't really solving it

in my eyes the regression is the badge not displaying

I'm asking for backend help again then and will open a new merge request.

closed

closed

It must already be setup for individual commits as looking at https://dev.gitlab.org/gitlab/gitlabhq/commit/0ead0ea43eff258e8e44dffb7ce5457d92745578 it has the verified badge

It must already be setup for individual commits

Thank you for finding this. It looks like this is not being loaded as Ajax request. So I'll try to solve it the same way.

mentioned in merge request !13337

assigned to @winh

changed title from WIP: Remove GPG status loading indicator from repository page to WIP: Remove GPG status loading indicator if no Ajax request is made

changed the description

Reopening after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13337#note_37358385 / https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13337#note_37358547.

Closed in favor of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13526 because it used the same branch as !13337.

mentioned in issue #28921 (moved)