Skip to content

update gpg_signed_commit to use 0xLONG format for gpg list keys

username-removed-106644 requested to merge kpankonen/gitlab-ce:gpg into master

See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html

What does this MR do?

Newer versions of gnupg default to display keys in short format (https://lists.gnupg.org/pipermail/gnupg-devel/2016-January/030726.html):

$ gpg --version
gpg (GnuPG) 2.1.15

$ gpg --list-keys 
/home/kevin/.gnupg/pubring.kbx
------------------------------
pub   rsa4096 2017-08-25 [SC]
      5F7985A26AF18A9229D9276F35EDADF6F3EB73D5
uid           [ultimate] Kevin Pankonen <kevin@example.com>
sub   rsa4096 2017-08-25 [E]

This MR updates the commands to using the 0xLONG key format so that it matches the rest of the documentation:

$ gpg --list-keys --keyid-format 0xLONG
/home/kevin/.gnupg/pubring.kbx
------------------------------
pub   rsa4096/0x35EDADF6F3EB73D5 2017-08-25 [SC]
uid                   [ultimate] Kevin Pankonen <kevin@example.com>
sub   rsa4096/0x77A6EED421AF8A96 2017-08-25 [E]

Moving docs to a new location?

See the guidelines: http://docs.gitlab.com/ce/development/doc_styleguide.html#changing-document-location

  • Make sure the old link is not removed and has its contents replaced with a link to the new location.
  • Make sure internal links pointing to the document in question are not broken.
  • Search and replace any links referring to old docs in GitLab Rails app, specifically under the app/views/ directory.
  • If working on CE, submit an MR to EE with the changes as well.

Merge request reports