Fix bottom spacing for dropdowns that open upwards
What does this MR do?
Fix bottom spacing for dropdowns that open upwards
Before | After |
---|---|
Before | After |
---|---|
Are there points in the code the reviewer needs to double check?
- What spacing do we actually want?
- I set it to 4px based on the top navigation margin for dropdowns.
- Are there other dropdowns that open upwards to check?
Why was this MR needed?
It looks like like the margin gap was introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13584/diffs#4b8ec5ff8ab825db349011c80b5bc9f401b2085d_731_731 for dropdowns that position below so they aren't covered up by the Chrome address hint.
https://gitlab.com/gitlab-org/gitlab-ce/issues/38315#note_41279736
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/38187, https://gitlab.com/gitlab-org/gitlab-ce/issues/38315
Edited by username-removed-892863