Make file list more compact
Signed-off-by: Dmitriy Zaporozhets dmitriy.zaporozhets@gmail.com
Merge request reports
Activity
Related to #3149 (moved)
-
@rspeicher I think 28px is a fair compromise between @skyruler 32px and yours 24px
😃 mentioned in commit c83da875
mentioned in issue #3149 (moved)
Sorry, but I had to do a triple-take to see the difference. That is to say, there's hardly any difference at all.
@dzaporozhets Did you really reduce it by only 4 pixels? 12.5%?
This is not a matter of fine-tuning; it's grossly excessive. There's still room for two more files to be listed between each one. Not that it must be narrowed to that extent, but the screenshot posted here is still beyond excessive in padding.
Why do you think there needs to be so much padding? Look at GitHub's file list. Do you hear people complaining that it's not padded enough? Do you hear people complaining that they can see too many files one one screen? There's no reason to have so much padding. I am not poking at the file list with fat, greasy thumbs--I am clicking on them with a mouse cursor.
Even the links in the left-hand nav bar are not as padded as the file list! The nav bar's rows are only about half as tall as the file list's rows!
-
That is to say, there's hardly any difference at all.
@alphapapa Sorry screenshots are from big monitor. I can make close screenshot if necessary.
Did you really reduce it by only 4 pixels? 12.5%?
Yes I did. I think small improvements are better than no improvements.
Look at GitHub's file list
GitHub has own designers and way how they see/make UI.
Why do you think there needs to be so much padding?
Design is mostly about content and space around it. I am not UI expert but @skyruler is, so I hope he can give a proper explanation.
