Public Groups

This is the initial work (meaning no tests) for making groups public if they have a public project (or internal for logged in users). This allows issues and merge requests to be viewed, but not group membership. As part of this I have also added back the link in the public project title section (it was removed as it didn't make sense before).

This addesses the following suggestions/issues:

http://feedback.gitlab.com/forums/176466-general/suggestions/5314461-groups-containing-one-or-more-public-projects-shou Issue #32 (closed) https://github.com/gitlabhq/gitlabhq/issues/5203 as well as a few closed issues.

This also changes the public user page to only show groups that are accessible to the user in some manner.

This still needs tests, which I plan on doing, but the functionality is there. Screen captures to follow.

First, here is the public group page. It actually has 2 projects, but only Puppet is public. You'll notice there is no Members nav option. I also removed the badges for Issues and Merge Requests as these show the numbers assigned to the current user. I will remove the To dashboard link in the next iteration, when I complete the tests.

Here is the issues page. This lacks the Assigned to me, Created by me and Everyone's which you would see if you were logged in. It just occurs to me that the To see all issues you should visit dashboard page. sentence should probably be removed, so I will handle that in the next iteration.

This one is very similar to the Issues page, except it contains merge requests.

Lastly, the new user page. This user is actually a member of 4 groups, but only one of those groups has a public project (Gitlabhq).

I am thinking about adding in the Members nav, but not displaying the membership roles (e.g. Owner, Master, etc.)

I went ahead and removed the text referencing the 'dashboard' and added the Members page. Here is what a non-group member will see on the Members page. I figure this isn't an issue as they can see the Team events and put the team together if they wanted to.

@dzaporozhets Can you give Jason feedback on this?

@jason Hollingsworth +1 for members tab.

Also we need security tests for it

To prevent any possibility of unauthorised access

Take a look at this https://gitlab.com/gitlab-org/gitlab-ce/tree/master/spec/features/security

@dzaporozhets I do like my ternary operators, but I will remove them all. I will also clean up the code and try to make it a little more understandable for others who come across it (it made sense to me, but I wrote it). I will get some tests in and make sure to include some in the security portion.

@jason Hollingsworth thank you

@dzaporozhets I believe this latest version addresses all of the feedback items and includes tests. I realize that you are about to release a new version and this won't make it into that version.

Jason Hollingsworth thank you. I will review it right after 6.6 released

Looks good.

mentioned in issue #116 (closed)

mentioned in commit 3e71e568