Tests for diff notes
requested to merge 19957-write-tests-for-adding-comments-for-different-line-types-in-diff into master
What does this MR do?
Adds rspec feature tests for the diff notes feature.
Are there points in the code the reviewer needs to double check?
Swapped out the XPath selectors for mainly CSS selectors, I still need some .find(:xpath, '..')
to select the parent of the hardcoded .line_content
/.diff-line-num
id
s.
/cc @DouweM @jschatz1 @fatihacet
Why was this MR needed?
Coverage of a fiddly feature.
What are the relevant issue numbers?
Closes #19957 (closed).
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together Closes #19957 (closed)