Skip to content

Move to project dropdown with infinite scroll for better performance

Paco Guzman requested to merge 17932-move-to-project-dropdown-improve into master

What does this MR do?

Improve the Move to dropdown component using plain SQL to retrieve the projects where the user can move the current issue.

Are there points in the code the reviewer needs to double check?

We move the projects filtering entirely to SQL so we duplicate the ability class logic to check admin_issue permission but I think the new SQL method is understandable and with a good naming

Why was this MR needed?

See #17932 (closed)

What are the relevant issue numbers?

Relates with #17932 (closed) but maybe we want o add infinite scrolling too !5686 (merged)

Screenshots (if relevant)

These are some tests I did on my local machine with an user with 27 authorized projects (19 belonging to a the same group). I cannot profile these on staging because there are a lot of changes related with the project_team class that are not yet on staging.

Current local master (59ce1af5) Screen_Shot_2016-08-09_at_09.43.32

This MR Screen_Shot_2016-08-09_at_16.48.20

Does this MR meet the acceptance criteria?

Merge request reports