Skip to content

WIP: Add diff hunks to note notification emails

What does this MR do?

It adds highlighted diff hunks to notification emails for comments on merge requests. Makes more consistent the template for a commit vs. a merge request and minimizes the amount of places to change both at the same time. Adds email testing for diff note emails and unit testing for truncated diff lines

Are there points in the code the reviewer needs to double check?

Have been checked! :)

Why was this MR needed?

In a notification email, a comment on a line of code on a merge request is out of context without the relevant diff to refer to.

What are the relevant issue numbers?

#21027 (closed)

Screenshots (if relevant)

Hacky collage of html/text for diff comment/merge request comment Screenshot_2016-08-31_13.26.02

Before: Screenshot_2016-08-18_23.19.36

Does this MR meet the acceptance criteria?

Merge request reports