Conditionally remove indices that may not exist in pre-GitLab v6.7 installations

In pre-GitLab v6.7 installations, the tagging indices were directly added to the init schema and not added in a migration. Anyone using this older DB schema may not have these indicies, so only remove them if they are there.

Closes #1593 (closed)

cc: @JobV, @vsizov

@stanhu I would prefer create new migration with conditional creating indices.

Added 1 commit:

• f6c0ef55 - Conditionally remove indices that may not exist in pre-GitLab v6.7 installations

@vsizov Makes sense. I'll close this one out.

Status changed to closed

I did attempt to conditionally create the original indices (see https://github.com/mbleigh/acts-as-taggable-on/blob/master/db/migrate/1_acts_as_taggable_on_migration.rb#L22), but if the 7.10.2 migrations were run successfully, the migration to remove these same indices would already have been run. Another words, I think the user would either have to rollback or another migration to delete these indices would have to be added. I'll leave it to you to decide what to do.

Status changed to reopened

I analysed the problem more carefully - it is OK. Thank you for the fix.

Status changed to merged

mentioned in commit e1727f60

mentioned in commit 99976128

Mentioned in commit maxraab/gitlab-ce@99976128