Fixed search dropdown labels not displaying (!6277) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Phil Hughes requested to merge search-filters-label-fix into master 8 years ago

What does this MR do?

Returns the search controller method after finding the project & group.

Why was this MR needed?

The search controller was returning early when the search term was empty causing a bug where the dropdown toggles wouldn't show the correct text - instead defaulting to Any.

Screenshots (if relevant)

What are the relevant issue numbers?

Closes #21783 (closed)

Activity

Phil Hughes Added 32 commits: 8 years ago
Added 32 commits:

ec009eea...3a59efd5 - 31 commits from branch master

47b49624 - Fixed search dropdown labels not displaying
Phil Hughes Reassigned to @jschatz1 8 years ago

Reassigned to @jschatz1
Jacob Schatz Added ~149423 label 8 years ago

Added ~149423 label
Jacob Schatz Added ~12980 label 8 years ago

Added ~12980 label
Jacob Schatz Status changed to merged 8 years ago

Status changed to merged
Jacob Schatz Mentioned in commit 2a423e03 8 years ago

Mentioned in commit 2a423e03
Jacob Schatz @jschatz1 · 8 years ago

Maintainer

Thanks @iamphill. You are great! ⭐
Rubén Dávila @rdavila · 8 years ago

Maintainer

Picked into 8-12-stable, will go into 8.12.1.
Rubén Dávila Removed ~149423 label 8 years ago

Removed ~149423 label
Rubén Dávila Mentioned in issue #22469 (closed) 8 years ago

Mentioned in issue #22469 (closed)
Jacob Schatz Mentioned in commit 5793529a 8 years ago

Mentioned in commit 5793529a
username-removed-128633 Mentioned in merge request !6464 (closed) 8 years ago

Mentioned in merge request !6464 (closed)

Please register or sign in to reply