Add limit to the number of events showed in cycle analytics
This is part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24800 to provide a limit to the number of events shown so there are no performance problems - and a better UX.
TODO - from the frontend, add a note about the maximum or an X out of Y events shown.
-
Changelog entry added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
Merge request reports
Activity
Marked the task Changelog entry added as completed
Marked the task Conform by the merge request performance guides as completed
Marked the task Conform by the style guides as completed
Reassigned to @smcgivern
@smcgivern quick one to review! thanks!
@jameslopez so this isn't expected to implement pagination, just the limiting to stop the 502s?
Reassigned to @jameslopez
@smcgivern correct - see Job's suggestion https://gitlab.com/gitlab-org/gitlab-ce/issues/24800#note_18812405 We'll do pagination later, as that will require some UX design, etc... And this is a quick fix for now...
Added 1 commit:
- 339721e6 - user project and not empty_project as we need the repo stuff
@jameslopez What's the status here?
changed milestone to %8.15
@DouweM we need a frontend change in order to merge this MR first.
@alfredo has this been done in the frontend? See https://gitlab.com/gitlab-org/gitlab-ce/issues/24800 for the details...
mentioned in issue #22940 (closed)
mentioned in issue #27622 (closed)
added 4312 commits
-
339721e6...178626ed - 4308 commits from branch
master - 2e54454e - Add limit to the number of events showed in cycle analytics and spec
- 0c4c5408 - undo local changelog change
- 40bc96c9 - fix typo [ci skip]
- 58a5d4a9 - user project and not empty_project as we need the repo stuff
Toggle commit list-
339721e6...178626ed - 4308 commits from branch
Hey @jameslopez quick question on this. I'd like to help do the frontend piece, but was curious on how it should work.
I don't see a
pagequery parameter or any way to signify which subset of events are being viewed. Is the intent to limit it to the only last 50 events (no pagination)?@samrose3 yes, this is something temporary, until we decide to do the whole pagination. https://gitlab.com/gitlab-org/gitlab-ce/issues/24800 has no milestone yet.
I've just picked this up again as I thought I can do the frontend myself - requirements are pretty straightforward: https://gitlab.com/gitlab-org/gitlab-ce/issues/24800#note_19176379
But let me know if you can do it (that would be great too!)
👍🏻 -
@jameslopez I can help out with this real quick
💪 😁 @samrose3 thanks a lot!
changed milestone to %8.17
@smcgivern this should be pretty much the same as when you first reviewed, but there was a big refactoring so I had to move things around. Feel free to have another quick look! Thanks :)
assigned to @smcgivern
added 1 commit
- 8dced28a - Display number of shown events on Plan stage of Cycle Analytics
-
@mikegreiling can you take a look at my commit to make sure everything looks solid?
💯 @jameslopez LGTM, I think my comments are for @samrose3!
I'm moving to %9.0.
changed milestone to %9.0
assigned to @samrose3
assigned to @smcgivern
mentioned in merge request gitlab-com/www-gitlab-com!4780 (merged)
mentioned in issue #30046 (moved)
mentioned in issue gitlab#8963
