Skip to content
Snippets Groups Projects

Nested groups improvements pt 2

Merged username-removed-444 requested to merge dz-nested-groups-improvements-2 into master
All threads resolved!

What does this MR do?

  1. Expose full_name and full_path attributes of the Group to API
  2. Use full_name and full_path for different dropdown/search autocomplete
  3. When search inside group - look for results in nested groups too
  4. Update group api doc with some attributes that are already exists but not mention in docs

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

Make nested groups more integrated into GitLab

Screenshots (if relevant)

Screenshot_2017-01-27_16.04.01

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 19700d92 - Improve search within group logic

    Compare with previous version

  • username-removed-444 resolved all discussions

    resolved all discussions

  • @DouweM done, should be better now

  • removed assignee

  • @dzaporozhets Looks good. Please fix the conflicts, and merge yourself.

  • added 265 commits

    • 19700d92...4468104f - 259 commits from branch master
    • 15ad1d88 - Use full group name/path in UI dropdowns
    • d6febcaf - Include nested groups items into search results
    • b4bf3cd6 - Add tests for nested groups in search service and search helper
    • bbd8d0d1 - Update group api doc with full_name and full_path attributes
    • fae9814e - Add changelog item about new attributes in group api
    • ba2d7eda - Improve search within group logic

    Compare with previous version

  • username-removed-444 enabled an automatic merge when the pipeline for ba2d7eda succeeds

    enabled an automatic merge when the pipeline for ba2d7eda succeeds

  • mentioned in commit d6450bb2

  • mentioned in issue #2772 (closed)

  • Please register or sign in to reply
    Loading