use url helpers to construct URLs for push_message
What does this MR do?
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
added 6 commits
- 5e8b3d7b - refactoring project’s name, path, namespace and url
- 0d5e74a4 - build message service to use Rails url helpers
- 79beee50 - note message service to use Rails url helpers
- 04d40fac - standardise attr_reader declaration with other message service
- 497a482c - pipeline message service to use Rails url helpers
- 87540532 - complete changelog
Toggle commit listadded 1 commit
- acc1ac63 - remove project_name (it has been refactored out)
@adamniedzielski welcome to check
😺 @adamco Hey, thanks for the merge request, that was quick!
🎱 31 31 resource :avatar, only: [:show, :destroy] 32 32 resources :commit, only: [:show], constraints: { id: /\h{7,40}/ } do 33 33 member do 34 get :builds Oh, it's really broken in master - https://gitlab.com/gitlab-org/gitlab-ce/commit/9a82aa70e3f3ff679c7a27ccbb9d497576b20822#071195278a2a363e4984496399b061354ccc649f.
I created an issue to fix that - https://gitlab.com/gitlab-org/gitlab-ce/issues/27463.
I can visit >> https://gitlab.com/adamco/gitlab-ce/commit/acc1ac63b7e5c9f629a5eac4b9415913c94a507b/builds , tho. The URL matched with this pattern:
/:namespace/:project/commit/:sha/builds
.@adamco GitLab.com is not running the latest master. Please check on your local development machine and it will be broken
thanks @adamniedzielski I was very confused with this behavior, cannot trace where the
builds
came from
14 12 @ref_type = params[:tag] ? 'tag' : 'branch' 15 13 @ref = params[:ref] 16 14 @project_name = params[:project_name] 17 @project_url = params[:project_url] 18 15 @status = params[:commit][:status] 19 16 @user_name = params[:commit][:author_name] 20 17 @duration = params[:commit][:duration] 18 19 path_with_namespace = params[:project][:path_with_namespace] 20 @project_namespace, @project_path = path_with_namespace.split('/') I don't think that splitting the path is a way to go here, especially considering https://gitlab.com/gitlab-org/gitlab-ce/issues/2772 that we are working on. Can we pass project and / or namespace instance here and use it to construct URLs?
or, can I modify the
params
object, @adamniedzielski ? currently if not mistaken, there's no path, just the namespace.I just read about the #2772 (closed) proposal; agreed, splitting would be a serious disaster
assigned to @adamco
added technical debt label
@adamco are you still willing this finish this merge request?
😄 hi @adamniedzielski yess certainly, but been extremely busy last week, just had visiting 3 different cities. I'll look it up again in two days :)