Skip to content
Snippets Groups Projects

use url helpers to construct URLs for push_message

3 unresolved threads

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#27149 (moved)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
31 31 resource :avatar, only: [:show, :destroy]
32 32 resources :commit, only: [:show], constraints: { id: /\h{7,40}/ } do
33 33 member do
34 get :builds
  • 30 41 def attachment_color
    31 42 '#345'
    32 43 end
    44
    45 def routes
    46 Rails.application.routes.url_helpers
  • 14 12 @ref_type = params[:tag] ? 'tag' : 'branch'
    15 13 @ref = params[:ref]
    16 14 @project_name = params[:project_name]
    17 @project_url = params[:project_url]
    18 15 @status = params[:commit][:status]
    19 16 @user_name = params[:commit][:author_name]
    20 17 @duration = params[:commit][:duration]
    18
    19 path_with_namespace = params[:project][:path_with_namespace]
    20 @project_namespace, @project_path = path_with_namespace.split('/')
  • username-removed-378947 added ~19173 ~164274 labels

    added ~19173 ~164274 labels

  • @adamco are you still willing this finish this merge request? 😄

  • added ~65372 label

  • hi @adamniedzielski yess certainly, but been extremely busy last week, just had visiting 3 different cities. I'll look it up again in two days :)

  • username-removed-378947 removed ~65372 label

    removed ~65372 label

  • Please register or sign in to reply
    Loading